[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

w2yehia added a comment. @alanphipps thanks for handling the AIX case. From inspection it looks sufficient. I wasn't able to apply the patch with `arc`, so I'll wait for it to land and report/fix any AIX specific issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https:

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

w2yehia added a comment. Please update InstrProfilingPlatformAIX.c as well, specifically add new dummy vars for the new section. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846 __

[PATCH] D153583: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rG534e23e47b03: [ThinLTO][Matrix] Forward -enable-matrix flag to the LTO plugin (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

w2yehia added inline comments. Comment at: clang/test/Driver/fprofile-update.c:18 +// RUN: %clang -### %s --target=powerpc-unknown-aix -fprofile-generate -fprofile-update=atomic 2>&1 | FileCheck %s --check-prefix=AIX +// RUN: %clang -### %s --target=powerpc-unknown-aix -fprofile

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

w2yehia added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + if (NeedsProfileRT || needsGCovInstrumentation(Args)) +CmdArgs.push_back("-lpthreads"); + The change in `compiler-rt/lib/profile/InstrProfilingFile.c` affects non-AIX platf

[PATCH] D155700: [ThinLTO][AIX] Enable thinLTO on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG645f6dcd69a5: [ThinLTO][AIX] Enable thinlto on AIX (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Rep

[PATCH] D154239: [Doc][clang] Some PGO documentation improvements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec844c881a2: [Doc][clang] Some PGO documentation improvements. (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D146431: [AIX][Driver] Implement -mxcoff-build-id option.

This revision was automatically updated to reflect the committed changes. Closed by commit rGda92f2fb33c4: [AIX][Driver] Implement -mxcoff-build-id option (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

w2yehia accepted this revision. w2yehia added a comment. This revision is now accepted and ready to land. LGTM. Would be nice to get @daltenty 's approval too. Comment at: clang/test/Driver/aix-ld.c:1094 +// CHECK-RELOCATABLE-NOT: "[[SYSROOT]]/usr/lib{{/|}}crti.o" +// C

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

w2yehia added a comment. testcase? Comment at: clang/lib/Driver/ToolChains/AIX.cpp:236 + if (Args.hasArg(options::OPT_r)) { +const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath()); +C.addCommand(std::make_unique( nit: can we avoid the code du

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

w2yehia added inline comments. Comment at: clang/test/Driver/ppc-roptr.c:10 +// ROPTR-NOT: "-mroptr" +// ROPTR-NOT: "-bforceimprw" + hubert.reinterpretcast wrote: > Do we pass the option through to the LTO codegen when `-fprofile-generate` is > used? > We may ne

[PATCH] D140628: [flang] Add driver install directory to AIX toolchain program paths list

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e72407635a4: [flang] Add driver install directory to AIX toolchain program paths list. (authored by pscoro, committed by w2yehia). Changed prior to commit: https://reviews.llvm.org/D140628?vs=485112&id

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

w2yehia added a comment. > I wasn't included as a reviewer on D124857 > and I missed that change so couldn't comment there, but I'm not a fan of > including the AIX support in InstrProfilingPlatformLinux.c. AIX is neither > Linux nor ELF-based and big chunks o

[PATCH] D136192: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG461a1836d3d7: [PGO][AIX] Improve dummy var retention and allow -bcdtors:csect linking. (authored by w2yehia). Herald added projects: clang, Sanitizer

[PATCH] D134222: [clang][deps] Report module map describing compiled module

w2yehia added a comment. In D134222#3815956 , @jansvoboda11 wrote: > In D134222#3815793 , @w2yehia wrote: > >> @jansvoboda11 >> FYI, this is breaking AIX buildbot: >> https://lab.llvm.org/buildbot/#/builders/214

[PATCH] D134222: [clang][deps] Report module map describing compiled module

w2yehia added a comment. @jansvoboda11 FYI, this is breaking AIX buildbot: https://lab.llvm.org/buildbot/#/builders/214/builds/3436/steps/6/logs/FAIL__Clang__modules-header-sharing_m Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134222/new/ https:

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

w2yehia added inline comments. Herald added a project: All. Comment at: libcxx/trunk/include/istream:1222 { -this->setstate(ios_base::badbit); +__state |= ios_base::badbit; return -1; Hi @ldionne, you'

[PATCH] D130889: [llvm] Introduce a pass plugin registry and loader

w2yehia added a comment. Looks good. Thanks. Comment at: llvm/lib/Passes/PassPluginLoader.cpp:23 +void PassPluginLoader::operator=(const std::string &Filename) { + sys::SmartScopedLock Lock(*PluginsLock); + auto PassPlugin = PassPlugin::Load(Filename); why do

[PATCH] D124857: [AIX][PGO] Enable linux style PGO on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2407c13aa4a4: [AIX][PGO] Enable linux style PGO on AIX (authored by w2yehia). Herald added projects: clang, Sanitizers. Herald added subscribers: San

[PATCH] D124046: [AIX] Always pass namedsects option when linking with PGO.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf296b4c44462: [AIX] Always pass namedsects option when linking with PGO. (authored by w2yehia). Herald added a project: clang. Herald added a subscri

[PATCH] D114540: Big-endian version of vpermxor

This revision was automatically updated to reflect the committed changes. Closed by commit rG0850655da69a: Big-endian version of vpermxor (authored by tislam, committed by w2yehia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114540/new/ https://r

[PATCH] D104837: [PowerPC] Add XL compat __compare_and_swap builtins

w2yehia accepted this revision. w2yehia added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-cas.c:19 +// CHECK-NEXT:[[TMP2:%.*]] = cmpxchg weak volatile i32* [[A]], i32 [[TMP1]], i32 [[TMP0]] monotonic

[PATCH] D100350: [AIX] Diagnose thinLTO usage in clang on AIX.

This revision was automatically updated to reflect the committed changes. Closed by commit rG369c0e0f48dd: [AIX] Diagnose thinLTO usage in clang on AIX. (authored by w2yehia). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN