jojo closed this revision.
jojo added a comment.
Committed r278890.
https://reviews.llvm.org/D23293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jojo created this revision.
jojo added a reviewer: rengolin.
jojo added a subscriber: cfe-commits.
Some missing usage of TargetParser in Tools.cpp and Targets.cpp.
https://reviews.llvm.org/D23293
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
=
jojo added a comment.
I'm sorry that I should have submitted this and its fix in one review.
Now the old fix http://reviews.llvm.org/D21276 is abandoned,as a latest fix is
included in http://reviews.llvm.org/D21785.
I will commit http://reviews.llvm.org/D21277 and
http://reviews.llvm.org/D21785,
jojo added a comment.
> I recommend you squash this patch with D21276 before commit.
Hi, Renato,
Do you mean updating the diff to let it include the change of
http://reviews.llvm.org/D21276,or commiting these two reviews as one commit?
Repository:
rL LLVM
http://reviews.llvm.org/D21277
jojo updated this revision to Diff 60658.
jojo added a comment.
Herald added a subscriber: mehdi_amini.
Update according to inline comments.
Repository:
rL LLVM
http://reviews.llvm.org/D21277
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
=
jojo added inline comments.
Comment at: lib/Basic/Targets.cpp:5709
@@ -5715,1 +5708,3 @@
+
+return false;
}
echristo wrote:
> compnerd wrote:
> > Please collapse this:
> >
> > return Name == "generic" || llvm::AArch64::parseCPUArch(Name) !=
> > llvm::
jojo created this revision.
jojo added reviewers: rengolin, jmolloy, bsmith, rsmith, labrinea.
jojo added a subscriber: cfe-commits.
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Her
jojo added inline comments.
Comment at: include/llvm/Support/TargetParser.h:173
@@ +172,3 @@
+StringRef getArchName(unsigned ArchKind);
+bool getArchFeatures(unsigned ArchKind, std::vector &Features);
+unsigned getArchAttr(unsigned ArchKind);
rengolin wrote:
> Nit
jojo updated this revision to Diff 58381.
jojo added a comment.
1.include/llvm/Support/TargetParser.h
Move move the declaration of getArchFeatures to a more reasonable place.
Remove unnecessary parameter for getDefaultCPU.
2.lib/Support/TargetParser.cpp
Make adjustments according to Targe
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
jojo updated this revision to Diff 58210.
jojo added a comment.
Adjust "getAArch64ArchFeaturesFromMarch" logic.In file lib/Driver/Tools
jojo added a comment.
> While I agree with Bradley that the repetition is not pretty, I think it will
> expose all issues to make a class design simple and straightforward, once we
> get all the sharp edges out. But we need to know what are the difficulties on
> Clang, llc and the back-ends, an
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
jojo updated this revision to Diff 58205.
jojo added a comment.
1.include/llvm/Support/AArch64TargetParser.def
Format this file.
2.
jojo added inline comments.
Comment at: include/llvm/Support/AArch64TargetParser.def:20
@@ +19,3 @@
+AARCH64_ARCH("armv8-a", AK_ARMV8A, "8-A", "v8", ARMBuildAttrs::CPUArch::v8_A,
+ FK_CRYPTO_NEON_FP_ARMV8, (AArch64::AEK_CRC | AArch64::AEK_CRYPTO |
AArch64::AEK_FP | AArch
jojo added a comment.
> There is an awful lot of duplication/passing through to another class in
> this, it strikes me that this whole thing could benefit from some level of
> inheritance. I think it would be good to have a base class that defines the
> interface and have both ARM/AArch64 (and
jojo removed rL LLVM as the repository for this revision.
jojo changed the visibility of this Differential Revision from "All Users" to
"Public (No Login Required)".
jojo updated this revision to Diff 58071.
jojo added a comment.
1.unsigned llvm::AArch64::getArchAttr(unsigned ArchKind)
Correct
jojo removed rL LLVM as the repository for this revision.
jojo changed the visibility of this Differential Revision from "All Users" to
"Public (No Login Required)".
jojo updated this revision to Diff 58072.
jojo added a comment.
Remove checkARMArchValid & checkAArch64ArchValid logic.
http://re
jojo added inline comments.
Comment at: lib/Driver/Tools.cpp:707
@@ -696,3 +706,3 @@
std::string MArch = arm::getARMArch(ArchName, Triple);
- if (llvm::ARM::parseArch(MArch) == llvm::ARM::AK_INVALID ||
+ if (!checkARMArchValid(MArch) || llvm::ARM::parseArch(MArch) ==
llvm::A
jojo added inline comments.
Comment at: lib/Support/TargetParser.cpp:441
@@ +440,3 @@
+ if (Extensions & AArch64::AEK_PROFILE)
+Features.push_back("+spe");
+
bsmith wrote:
> For ARM there is a table that defines these extensions and how they map to
> backend
jojo added a comment.
Dear Bradley,Renato
Sorry for late reply,I have been on leave the last three days.
Thank you very much for your review and suggestons.I will re pondering the
changes.
Repository:
rL LLVM
http://reviews.llvm.org/D20088
___
jojo added a comment.
Dear Bradley,Renato
Sorry for late reply,I have been on leave the last three days.
Thank you very much for your review and suggestons.I will re pondering the
changes.
Repository:
rL LLVM
http://reviews.llvm.org/D20089
___
jojo created this revision.
jojo added reviewers: bsmith, jmolloy, rengolin.
jojo added subscribers: llvm-commits, cfe-commits.
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Herald a
21 matches
Mail list logo
