jojo added inline comments. ================ Comment at: include/llvm/Support/TargetParser.h:173 @@ +172,3 @@ +StringRef getArchName(unsigned ArchKind); +bool getArchFeatures(unsigned ArchKind, std::vector<const char *> &Features); +unsigned getArchAttr(unsigned ArchKind); ---------------- rengolin wrote: > Nitpick, move this declaration with the others that use &Features. That would be more reasonable.
================ Comment at: include/llvm/Support/TargetParser.h:184 @@ +183,3 @@ +unsigned getDefaultExtensions(StringRef CPU, unsigned ArchKind); +StringRef getDefaultCPU(StringRef Arch, std::vector<const char *> &Features); + ---------------- rengolin wrote: > You don't need the &Features any more. Same of the implementation in the cpp > file. Sorry, I missed it. Repository: rL LLVM http://reviews.llvm.org/D20089 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
