https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/140116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/140116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/140116
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/140116
This fixes an issue reported by the sanitizer with the following error message:
`copy_constructor_call: IndexOpts` is passed by value as a parameter to`
clang::index::IndexingOptions::IndexingOptions` instead o
https://github.com/zahiraam approved this pull request.
Looks good. Thanks.
https://github.com/llvm/llvm-project/pull/138374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
May be an [NFC] in the title of the PR?
https://github.com/llvm/llvm-project/pull/138374
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam approved this pull request.
Looks good. Thanks.
https://github.com/llvm/llvm-project/pull/138341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> Two of the fixes were to code that was removed while resolving the merge
> conflict on the LANG_OPT declaration, I thought with the revert of
> [c2a62af](https://github.com/llvm/llvm-project/commit/c2a62af2a51d58183bcd72ee8a86c37ddd526758)
> I got all the changes but I'll rec
zahiraam wrote:
@ojhunt I think there a more than one revert. Can you please read from
https://github.com/llvm/llvm-project/issues/137600#issuecomment-2842037532 to
see all the reverts that need to be done. Thanks.
https://github.com/llvm/llvm-project/pull/137661
__
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/138283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
Thanks for your input. I will close this PR.
https://github.com/llvm/llvm-project/pull/138283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> This is not needed IMO. This is a simple matcher, `op` is expected to always
> be bound.
>
> One might say that it can't hurt to add extra checks, but I don't think
> that's good justification for adding more code / bloat, even if in this case
> it's a single line. Still, 5%
zahiraam wrote:
> Did you run code sanitizer over all clang-tidy code or you only interested in
> this particular file? I think there are many more places where such `nullptr`
> dereference can happen, e.g.
>
> https://github.com/llvm/llvm-project/blob/52d2b589b2d7adc3e2b4ea503df4131e088de61f/
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/138283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/138283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/138283
A `nullptr` dereference is signaled by the code sanitizer. Adding an assert to
make sure it's caught.
Rate limit · GitHub
body {
background-color: #f6f8fa;
zahiraam wrote:
@ojhunt In https://github.com/llvm/llvm-project/issues/137600 there are a list
of a few temporary PRs that were merged in to silence the warning. These need
to be reverted after this one gets merged in. Do you want to revert them or you
want me to do that?
https://github.com/
https://github.com/zahiraam approved this pull request.
Looks good. Thanks.
https://github.com/llvm/llvm-project/pull/137661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@ojhunt Please go ahead and merge this in. Thanks for your patience.
https://github.com/llvm/llvm-project/pull/137661
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> I think this is a reasonable way forward for right now; we can bring back the
> enumerator once we're actually using it. WDYT @zahiraam ?
I tend to think so too. But I am waiting for a response from the math library
people internally to make sure that we don't loose compatibi
zahiraam wrote:
> > > > > > @zahiraam @AaronBallman a different option would be to add a signed
> > > > > > vs unsigned storage option to the `OPTION` and
> > > > > > `BENIGN_ENUM_LANGOPT` macros so we can store negative enumerations
> > > > > > safely
> > > > >
> > > > >
> > > > > I think I
zahiraam wrote:
> > > @zahiraam @AaronBallman a different option would be to add a signed vs
> > > unsigned storage option to the `OPTION` and `BENIGN_ENUM_LANGOPT` macros
> > > so we can store negative enumerations safely
> >
> >
> > I think I would prefer this solution. We need to be able t
zahiraam wrote:
> @zahiraam @AaronBallman a different option would be to add a signed vs
> unsigned storage option to the `OPTION` and `BENIGN_ENUM_LANGOPT` macros so
> we can store negative enumerations safely
I think I would prefer this solution. We need to be able to set the evaluation
met
zahiraam wrote:
> @zahiraam it's currently causing a warning (@Endilll asking for an update is
> why I ended up looking at this on my phone)
What is the warning?
https://github.com/llvm/llvm-project/pull/137247
___
cfe-commits mailing list
cfe-commi
zahiraam wrote:
> > I've reverted, not sure why I thought it had been reviewed?
>
> Thanks! And I'm happy enough blaming GitHub's poor Ux for all confusion. :-)
>
> @zahiraam -- any chance you can look into this?
Yes I can in a couple of days. @ojhunt I hope this is OK?
https://github.com/llv
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/135463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/135463
>From 51a9237094437e0b9db57fd071e295939234a3ac Mon Sep 17 00:00:00 2001
From: Ernesto Su
Date: Fri, 11 Apr 2025 16:12:10 -0700
Subject: [PATCH 1/2] [clang][OpenMP] Fix/enforce order-concurrent-nestable
rules
zahiraam wrote:
if @alexey-bataev doesn't have additional comments, I or he can merge it in for
you.
https://github.com/llvm/llvm-project/pull/135463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/zahiraam approved this pull request.
A few nit things.
Looks good. Thanks.
https://github.com/llvm/llvm-project/pull/135463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/135463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -411,9 +411,11 @@ bool isOpenMPCapturingDirective(OpenMPDirectiveKind DKind);
/// directive that can be nested within region corresponding to construct
/// on which order clause was specified with concurrent as ordering argument.
/// \param DKind Specified directive.
+/// \p
https://github.com/zahiraam approved this pull request.
Looks good. Just a few NIT things to edit. Thanks.
https://github.com/llvm/llvm-project/pull/131477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -360,6 +360,14 @@ Improvements to Clang's diagnostics
- An error is now emitted when a ``musttail`` call is made to a function
marked with the ``not_tail_called`` attribute. (#GH133509).
+- ``-Whigher-precisision-for-complex-divison`` warns when:
+
+ -The divisor is
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/131477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics
- Now correctly diagnose a tentative definition of an array with static
storage duration in pedantic mode in C. (#GH50661)
+- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns
when the divisor i
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics
- Now correctly diagnose a tentative definition of an array with static
storage duration in pedantic mode in C. (#GH50661)
+- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns
when the divisor i
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros
,Gergely Meszaros
Message-ID:
In-Reply-To:
@@ -10685,6 +10724,7 @@ QualType Sema::CheckMultiplyDivideOperands(ExprResult
&LHS, ExprResult &RHS,
if (compType.isNull() || !compType->isArithmeticType())
return InvalidOperand
=?utf-8?q?Mészáros?= Gergely
Message-ID:
In-Reply-To:
@@ -10685,6 +10724,7 @@ QualType Sema::CheckMultiplyDivideOperands(ExprResult
&LHS, ExprResult &RHS,
if (compType.isNull() || !compType->isArithmeticType())
return InvalidOperands(Loc, LHS, RHS);
if (IsDiv) {
+
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros
,Gergely Meszaros
Message-ID:
In-Reply-To:
@@ -10685,6 +10724,7 @@ QualType Sema::CheckMultiplyDivideOperands(ExprResult
&LHS, ExprResult &RHS,
if (compType.isNull() || !compType->isArithmeticType())
return InvalidOperand
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros
,Gergely Meszaros
Message-ID:
In-Reply-To:
zahiraam wrote:
> Don't know what's up with buildkite, it looks as if it doesn't like multiple
> commits? The commit ID its trying to check out is the first in the series,
> but `git fetch -v --prune -
=?utf-8?q?Mészáros?= Gergely ,Gergely Meszaros
,Gergely Meszaros
Message-ID:
In-Reply-To:
@@ -0,0 +1,58 @@
+// RUN: %clang_cc1 %s -complex-range=promoted -triple x86_64-unknown-linux
-verify=no-diag \
+// RUN: -DDIV_CC -DDIV_RC -DDIVASSIGN -DDIVMIXEDFD -DDIVMIXEDID
+
+// RUN:
=?utf-8?q?Mészáros?= Gergely
Message-ID:
In-Reply-To:
@@ -10591,6 +10591,45 @@ static void checkArithmeticNull(Sema &S, ExprResult
&LHS, ExprResult &RHS,
<< LHS.get()->getSourceRange() << RHS.get()->getSourceRange();
}
+static void DetectPrecisionLossInComplexDivisio
=?utf-8?q?Mészáros?= Gergely
Message-ID:
In-Reply-To:
@@ -0,0 +1,58 @@
+// RUN: %clang_cc1 %s -complex-range=promoted -triple x86_64-unknown-linux
-verify=no-diag \
+// RUN: -DDIV_CC -DDIV_RC -DDIVASSIGN -DDIVMIXEDFD -DDIVMIXEDID
+
+// RUN: %clang_cc1 %s -complex-range=promote
@@ -0,0 +1,49 @@
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify -complex-range=promoted -o - | FileCheck %s
+
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify=nopromotion -complex-range=promoted -target-fe
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/133152
>From 56a000612da3f58928362229a46800c6f077cc71 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 26 Mar 2025 13:18:36 -0700
Subject: [PATCH 1/3] Fix complex long division with -mno-x87.
---
clang/
@@ -0,0 +1,49 @@
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify -complex-range=promoted -o - | FileCheck %s
+
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify=nopromotion -complex-range=promoted -target-fe
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134385
>From 02ae197808f19541127b3e80448aa8034a8e8b1d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 4 Apr 2025 07:05:26 -0700
Subject: [PATCH 1/2] [NFC] Remove dead code detected by code santizer.
---
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/134385
None
>From 02ae197808f19541127b3e80448aa8034a8e8b1d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 4 Apr 2025 07:05:26 -0700
Subject: [PATCH] [NFC] Remove dead code detected by code santizer.
-
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> In general, I don't fully understand the scope of this patch. Surely, there's
> thousands of things that could be improved in the codebase. Which of those
> belong to this patch? Reviewers can always point out things that could be
> improved ad infinitum, leading to a patch w
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/4] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
zahiraam wrote:
> The changes to the clang-tidy check should be reverted IMO.
>
> Also, please provide more information. What do you mean by "code sanitizer",
> what is the exact error message, etc.
Please see above the error message from sanitizer. I can revert the change if
you think the do
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/3] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/2] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/133152
>From 56a000612da3f58928362229a46800c6f077cc71 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 26 Mar 2025 13:18:36 -0700
Subject: [PATCH 1/2] Fix complex long division with -mno-x87.
---
clang/
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/133152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/133152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/133152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/133152
None
>From 56a000612da3f58928362229a46800c6f077cc71 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 26 Mar 2025 13:18:36 -0700
Subject: [PATCH] Fix complex long division with -mno-x87.
---
clan
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/132078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/132078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/132078
…uct.
>From f9c704c3fe15c2925aae8f3fb026c43256858f1a Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 19 Mar 2025 11:32:35 -0700
Subject: [PATCH] [Clang][OpenMP] Add support for additional argumen
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/128197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/128184
>From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 21 Feb 2025 07:14:02 -0800
Subject: [PATCH 1/3] [CLANG-CL] Remove the 'static' declaration specifier
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@alexey-bataev Thanks for the reviews.
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/5] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam deleted
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/4] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/128184
>From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 21 Feb 2025 07:14:02 -0800
Subject: [PATCH 1/2] [CLANG-CL] Remove the 'static' declaration specifier
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/128184
MSVC mode.
>From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 21 Feb 2025 07:14:02 -0800
Subject: [PATCH] [CLANG-CL] Remove the 'static' declaration sp
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2882,6 +2882,12 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/3] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/2] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/127113
None
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH] [OpenMP] Missing implicit otherwise clause in metad
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/126927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/126927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/126927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> @zahiraam I've reverted your PR. I'm happy to test your revised version
> though my build environment is no secret -- `-DLLVM_ENABLE_WERROR=On` along
> with clang as the host compiler.
Sorry about that! I will fix the error and merge it back.
https://github.com/llvm/llvm-pro
1 - 100 of 784 matches
Mail list logo