@@ -0,0 +1,49 @@
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify -complex-range=promoted -o - | FileCheck %s
+
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify=nopromotion -complex-range=promoted -target-fe
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/133152
>From 56a000612da3f58928362229a46800c6f077cc71 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 26 Mar 2025 13:18:36 -0700
Subject: [PATCH 1/3] Fix complex long division with -mno-x87.
---
clang/
@@ -0,0 +1,49 @@
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify -complex-range=promoted -o - | FileCheck %s
+
+// RUN %clang_cc1 %s -O0 -emit-llvm -triple x86_64-unknown-unknown \
+// RUN -verify=nopromotion -complex-range=promoted -target-fe
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134385
>From 02ae197808f19541127b3e80448aa8034a8e8b1d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 4 Apr 2025 07:05:26 -0700
Subject: [PATCH 1/2] [NFC] Remove dead code detected by code santizer.
---
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/134385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/134385
None
>From 02ae197808f19541127b3e80448aa8034a8e8b1d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 4 Apr 2025 07:05:26 -0700
Subject: [PATCH] [NFC] Remove dead code detected by code santizer.
-
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> In general, I don't fully understand the scope of this patch. Surely, there's
> thousands of things that could be improved in the codebase. Which of those
> belong to this patch? Reviewers can always point out things that could be
> improved ad infinitum, leading to a patch w
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/4] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
zahiraam wrote:
> The changes to the clang-tidy check should be reverted IMO.
>
> Also, please provide more information. What do you mean by "code sanitizer",
> what is the exact error message, etc.
Please see above the error message from sanitizer. I can revert the change if
you think the do
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
@@ -260,7 +260,7 @@ static IntegerRange createFromType(const ASTContext
&Context,
llvm::APSInt LowerValue(PrecisionBits + 2, /*isUnsigned*/ false);
LowerValue.setBit(PrecisionBits);
LowerValue.setSignBit();
-return {LowerValue, UpperValue};
+return {std::mo
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/3] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/134138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134138
>From 608f5827cedbbc65441cefab80fbcdba7a053933 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 2 Apr 2025 11:52:13 -0700
Subject: [PATCH 1/2] [NFC] Fixes proposed by code sanitizer.
---
.../bugp
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/133152
>From 56a000612da3f58928362229a46800c6f077cc71 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 26 Mar 2025 13:18:36 -0700
Subject: [PATCH 1/2] Fix complex long division with -mno-x87.
---
clang/
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/133152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/133152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/133152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/133152
None
>From 56a000612da3f58928362229a46800c6f077cc71 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 26 Mar 2025 13:18:36 -0700
Subject: [PATCH] Fix complex long division with -mno-x87.
---
clan
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/132078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/132078
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/132078
…uct.
>From f9c704c3fe15c2925aae8f3fb026c43256858f1a Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Wed, 19 Mar 2025 11:32:35 -0700
Subject: [PATCH] [Clang][OpenMP] Add support for additional argumen
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/128197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/128184
>From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 21 Feb 2025 07:14:02 -0800
Subject: [PATCH 1/3] [CLANG-CL] Remove the 'static' declaration specifier
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@alexey-bataev Thanks for the reviews.
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/5] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam deleted
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
@@ -2882,6 +2882,13 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/4] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/128184
>From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 21 Feb 2025 07:14:02 -0800
Subject: [PATCH 1/2] [CLANG-CL] Remove the 'static' declaration specifier
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/128184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/128184
MSVC mode.
>From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Fri, 21 Feb 2025 07:14:02 -0800
Subject: [PATCH] [CLANG-CL] Remove the 'static' declaration sp
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2882,6 +2882,12 @@ StmtResult
Parser::ParseOpenMPDeclarativeOrExecutableDirective(
/*ReadDirectiveWithinMetadirective=*/true);
break;
}
+// If no match is found and no otherwise clause is present, skip
+// OMP5.2 Chapter 7.4: If no otherwise cla
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/3] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/127113
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH 1/2] [OpenMP] Missing implicit otherwise clause in
metadi
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/127113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/127113
None
>From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 13 Feb 2025 11:24:32 -0800
Subject: [PATCH] [OpenMP] Missing implicit otherwise clause in metad
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/126927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/126927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/126927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> @zahiraam I've reverted your PR. I'm happy to test your revised version
> though my build environment is no secret -- `-DLLVM_ENABLE_WERROR=On` along
> with clang as the host compiler.
Sorry about that! I will fix the error and merge it back.
https://github.com/llvm/llvm-pro
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> > @alexey-bataev I haven't gotten any response from @Meinersbur , can I merge
> > this in? Thanks.
>
> Go ahead
Thanks.
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
zahiraam wrote:
> > > > Not sure I understand your question? Which assertion? `clang.exe t.c`
> > > > is triggering an assertion?
> > >
> > >
> > > I don't understand why you say
> > > > The value `CX_None` is the defaut value given to the `Range` when no
> > > > `fcomplex-arithmetic` is used
zahiraam wrote:
> > Not sure I understand your question? Which assertion? `clang.exe t.c` is
> > triggering an assertion?
>
> I don't understand why you say
>
> > The value `CX_None` is the defaut value given to the `Range` when no
> > `fcomplex-arithmetic` is used on the command lin
>
> but
zahiraam wrote:
> > > @zahiraam the default of the `ComplexRange`, `CX_None` does overflow the
> > > `2` storage bits. That means we were probably still using `CX_Full` (4
> > > should overflow to `0`) even after #78330 (I am not sure why why that
> > > changed the default in the first place).
zahiraam wrote:
> @zahiraam the default of the `ComplexRange`, `CX_None` does overflow the `2`
> storage bits. That means we were probably still using `CX_Full` (4 should
> overflow to `0`) even after #78330 (I am not sure why why that changed the
> default in the first place). Also it's impos
zahiraam wrote:
@alexey-bataev I haven't gotten any response from @Meinersbur , can I merge
this in? Thanks.
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
zahiraam wrote:
ping? @Meinersbur
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@Meinersbur Would love to check this off. Can you please take another look?
Thanks.
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
Please let me know if there are any issues that I haven't addressed. Thanks.
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
zahiraam wrote:
@mjklemm @Meinersbur any more things to add? thanks.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
ping @Meinersbur and @alexey-bataev
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
ping @mjklemm.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> Yes, I think that would be helpful. Also, avoid duplicating lines with
> multiple `-verify=` prefixes.
I have made an attempt to edit the 2 LIT tests. I had a hard time finding good
names for the `verify` prefixes. Please don't hesitate to suggest better ones.
We could also u
zahiraam wrote:
> I don't think it is necessary to test each value of `-fopenmp-version=`
> separately, but don't mind either as long it doesn't affect maintanability.
>
> * Instead of repeating each clang diagnositic, consider passing multiple
> values to `-verify`, e.g. `-verify=omp51,omp60`
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
@@ -14477,6 +14485,268 @@ StmtResult
SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses,
buildPreInits(Context, PreInits));
}
+StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef
Clauses,
+
https://github.com/zahiraam approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/123417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8454,26 +8454,43 @@ static bool IsInfOrNanFunction(StringRef calleeName,
MathCheck Check) {
llvm_unreachable("unknown MathCheck");
}
+static bool IsInfinityFunction(const FunctionDecl *FDecl) {
+ if (FDecl->getName() != "infinity")
+return false;
+
+ if (const CXX
@@ -8454,26 +8454,43 @@ static bool IsInfOrNanFunction(StringRef calleeName,
MathCheck Check) {
llvm_unreachable("unknown MathCheck");
}
+static bool IsInfinityFunction(const FunctionDecl *FDecl) {
+ if (FDecl->getName() != "infinity")
+return false;
+
+ if (const CXX
zahiraam wrote:
> Thanks for revising the PR. I have added some comments.
>
> To unblock #119891, wouldn't it be sufficient that `-fopenmp-version=60`
> becomes a valid value? Do we need to modify all these tests to test only this
> flag?
Yes it's sufficient and that's what's done in #119891.
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> Please address @saiislam's questions. I also think that the title and
> description of the PR should reflect that this PR not only introduces the 6.0
> flag, but also moves several of the tests to test against 5.1 and 6.0.
I responded to the question.
The changes in the tests
@@ -8454,26 +8454,43 @@ static bool IsInfOrNanFunction(StringRef calleeName,
MathCheck Check) {
llvm_unreachable("unknown MathCheck");
}
+static bool IsInfinityFunction(const FunctionDecl *FDecl) {
+ if (FDecl->getName() != "infinity")
+return false;
+
+ if (const CXX
zahiraam wrote:
> Aldo, update OpenMPSupport page
Question about this. I see that the table for `OpenMP 6.0 Implementation
Details` chapter has an entry for `Loop transformation constructs`. Should the
`#pragma omp stripe` be listed here as a bullet item? Do you have a preference
of how this
zahiraam wrote:
> Please resolve open feedback items before the next round of reviews. Thanks.
Sorry I might have been ahead of myself!
I think this time I might have gotten it.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing
@@ -19,6 +19,8 @@ typedef void *omp_depend_t;
void foo() {}
void tmainc(){
omp_depend_t obj;
+ int omp_all_memory;
zahiraam wrote:
Removed.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits maili
zahiraam wrote:
@alexey-bataev, @kparzysz can you please review this? Thanks.
https://github.com/llvm/llvm-project/pull/119891
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@mjklemm, @saiislam can you please review this? Thanks.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public
OMPLoopTransformationDirective {
}
};
+class OMPStripeDirective final : public OMPLoopTransformationDirective {
+ friend class ASTStmtReader;
+ friend class OMPExecutableDirective;
+
+ /// Default list of offse
@@ -68,15 +70,15 @@ int fun(int arg) {
{}
#pragma omp target map(mapper(aa :vv) //
expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected
')'}} expected-error {{call to undeclared function 'mapper'}} expected-note
@@ -68,15 +70,15 @@ int fun(int arg) {
{}
#pragma omp target map(mapper(aa :vv) //
expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected
')'}} expected-error {{call to undeclared function 'mapper'}} expected-note
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/122339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@mjklemm and @saiislam would you mind taking a look at this please? Thanks.
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/122339
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/122339
None
>From d8268afeafb61f95f1fa917ab26214e84372eba3 Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Thu, 9 Jan 2025 10:58:29 -0800
Subject: [PATCH] Initialize value.
---
.../clang-tidy/modernize/Use
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> Not sure this level of support is enough to make 6.0 the default version.
> We're missing support for some 5.2 features still
That's what I thought! So the macro should continue being set to `202011?
https://github.com/llvm/llvm-project/pull/122108
___
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> {
let association = AS_Loop;
let category = CA_Executable;
}
+def OMP_Stripe : Directive<"stripe"> {
+ let allowedOnceClauses = [
+VersionedClause,
zahiraam wrote:
@alexey-bataev draft PR for thi
zahiraam wrote:
@alexey-bataev Can you please take a look at this draft PR? I think there are
still some LIT tests failing but I want to make sure the changes I am proposing
are correct before making further changes. I am not sure if the macro `_OPENMP`
should be set to `202411` or if it shoul
https://github.com/zahiraam converted_to_draft
https://github.com/llvm/llvm-project/pull/122108
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 741 matches
Mail list logo
