https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/134385
>From 02ae197808f19541127b3e80448aa8034a8e8b1d Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat <zahira.ammarguel...@intel.com>
Date: Fri, 4 Apr 2025 07:05:26 -0700
Subject: [PATCH 1/2] [NFC] Remove dead code detected by code santizer.
---
.../clang-tidy/misc/RedundantExpressionCheck.cpp | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
b/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
index c249244b1a1b2..fd72b8f5fd522 100644
--- a/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
@@ -929,16 +929,6 @@ static bool areExprsSameMacroOrLiteral(const
BinaryOperator *BinOp,
const auto *LStrl = dyn_cast<StringLiteral>(Lhs);
const auto *RStrl = dyn_cast<StringLiteral>(Rhs);
- if (Lil && Ril) {
- const llvm::StringRef L = Lexer::getSourceText(
- CharSourceRange::getTokenRange(LStrl->getBeginLoc()), SM,
- Context->getLangOpts(), 0);
- const llvm::StringRef R = Lexer::getSourceText(
- CharSourceRange::getTokenRange(RStrl->getBeginLoc()), SM,
- Context->getLangOpts(), 0);
- return L.compare(R) == 0;
- }
-
const auto *Lbl = dyn_cast<CXXBoolLiteralExpr>(Lhs);
const auto *Rbl = dyn_cast<CXXBoolLiteralExpr>(Rhs);
if (Lbl && Rbl)
>From 61eb6fead4fab5908ddc7d1320e5217ee54f784f Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat <zahira.ammarguel...@intel.com>
Date: Fri, 4 Apr 2025 07:37:42 -0700
Subject: [PATCH 2/2] Addressed Firewave's review comments.
---
clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp | 2 --
1 file changed, 2 deletions(-)
diff --git a/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
b/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
index fd72b8f5fd522..8e5a528bc5d3e 100644
--- a/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
@@ -927,8 +927,6 @@ static bool areExprsSameMacroOrLiteral(const BinaryOperator
*BinOp,
if (Lil && Ril)
return Lil->getValue() == Ril->getValue();
- const auto *LStrl = dyn_cast<StringLiteral>(Lhs);
- const auto *RStrl = dyn_cast<StringLiteral>(Rhs);
const auto *Lbl = dyn_cast<CXXBoolLiteralExpr>(Lhs);
const auto *Rbl = dyn_cast<CXXBoolLiteralExpr>(Rhs);
if (Lbl && Rbl)
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
