[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356220: Fixed global constant/variable naming check on C++ class for ObjC++ files. (authored by Wizard, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard updated this revision to Diff 190750. Wizard added a comment. add new line Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59283/new/ https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-ti

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard updated this revision to Diff 190462. Wizard added a comment. fix ObjC++ test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59283/new/ https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard updated this revision to Diff 190461. Wizard added a comment. Resolve comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59283/new/ https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clan

[PATCH] D59283: Fixed global constant/variable naming check on C++ class for ObjC++ files.

Wizard created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59283 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/google-objc-global-variable-declaration.m te

[PATCH] D56896: Update property prefix regex to allow numbers.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354485: Update property prefix regex to allow numbers. (authored by Wizard, committed by ). Herald added a subscriber: jdoerfert. Herald added a project: clang. Changed prior to commit: https://review

[PATCH] D56896: Update property prefix regex to allow numbers.

Wizard created this revision. Herald added subscribers: cfe-commits, jfb. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56896 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-declaration.m

[PATCH] D54288: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method.

This revision was automatically updated to reflect the committed changes. Closed by commit rC346566: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when… (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D54288?vs=173258&id=173457#toc

[PATCH] D54288: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346566: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llv

[PATCH] D54288: Fix ClangFormat issue of recognizing ObjC subscript as C++ attributes when message target is a result of a C-style method.

Wizard updated this revision to Diff 173258. Wizard added a comment. remove blank lines Repository: rC Clang https://reviews.llvm.org/D54288 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D54288: Fix ClangFormat issue of recognizing ObjC subscription as C++ attributes when message target is a result of a C-style method.

Wizard created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D54288 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D53955: Fix the issue that not recognizing single acronym with prefix as ObjC property name.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345858: Fix the issue that not recognizing single acronym with prefix as ObjC property… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews

[PATCH] D53955: Fix the issue that not recognizing single acronym with prefix as ObjC property name.

Wizard updated this revision to Diff 172172. Wizard added a comment. format change Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53955 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-dec

[PATCH] D53955: Fix the issue that not recognizing single acronym with prefix as ObjC property name.

Wizard updated this revision to Diff 172169. Wizard added a comment. Format code. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53955 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-decla

[PATCH] D53955: :Fix the issue that not recognizing single acronym with prefix as ObjC property name.

Wizard created this revision. Herald added subscribers: cfe-commits, jfb. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53955 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-declaration.m

[PATCH] D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

Wizard added inline comments. Comment at: clang-tidy/google/FunctionNamingCheck.cpp:50 + +void FunctionNamingCheck::registerMatchers(MatchFinder *Finder) { + // This check should only be applied to Objective-C sources. Can we do some simple check to see if some

[PATCH] D48039: - Add "AV" as new default acronym. - Add support for "I" and "A" in lowerCamelCase pattern

This revision was automatically updated to reflect the committed changes. Closed by commit rL334448: - Add "AV" as new default acronym. - Add support for "I" and "A" in… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/

[PATCH] D48039: - Add "AV" as new default acronym. - Add support for "I" and "A" in lowerCamelCase pattern

Wizard created this revision. Herald added a subscriber: cfe-commits. Wizard edited the summary of this revision. Wizard added reviewers: benhamilton, hokein. Now we can support property names like "hasADog" correctly. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48039 Files:

[PATCH] D44539: [Sema][Objective-C] Add check to warn when property of objc type has assign attribute

Wizard added a comment. Is there any case for property of ObjC types that we should use `unsafe_unretained` or `assign` rather than `weak`? In my understanding, `weak` is for properties of ObjC types as the replacement of `unsafe_unretained` and `assign` is for properties of primitive types.

[PATCH] D46895: add AR to acronyms of clang-tidy property check

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE332382: add AR to acronyms of clang-tidy property check (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D46895?vs=146874&id=146886#toc Repository: rCTE Clang

[PATCH] D46895: add AR to acronyms of clang-tidy property check

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46895 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp Index: clang-tidy/objc/PropertyDeclarationCheck.cpp ==

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

This revision was automatically updated to reflect the committed changes. Wizard marked an inline comment as done. Closed by commit rL331545: Add support for ObjC property name to be a single acronym. (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL L

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard marked an inline comment as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222 + [MatchedDecl](std::string const &s) { +auto Acronym = llvm::Regex("^" + s + "$"); +retur

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard updated this revision to Diff 145226. Wizard added a comment. optimize matching Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration-custom.m test/clang-tidy/objc-property

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: test/clang-tidy/objc-property-declaration.m:24 @property(assign, nonatomic) int enableGLAcceleration; +@property(assign, nonatomic) int ID; @end benhamilton wrote: > Please add a

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard updated this revision to Diff 145145. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration-custom.m test/clang-tidy/objc-property-

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:222 + [MatchedDecl](std::string const &s) { +return s == MatchedDecl->getName(); + })) { benhamilton wrote: > `s` is a reg

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard updated this revision to Diff 144970. Wizard edited the summary of this revision. Wizard added a comment. fix format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m

[PATCH] D46374: Add support for ObjC property name to be a single acronym.

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D46374 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-declaration.

[PATCH] D45936: update readability-identifier-naming-objc test to use interface ivar. Implementation ivars are not supported in 32-bits OS.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCTE330562: update readability-identifier-naming-objc test to use interface ivar. (authored by Wizard, committed by ). Chan

[PATCH] D45936: update readability-identifier-naming-objc test to use interface ivar. Implementation ivars are not supported in 32-bits OS.

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45936 Files: test/clang-tidy/readability-identifier-naming-objc.m Index: test/clang-tidy/readability-identifier-naming-objc.m ==

[PATCH] D45912: update test to use ivar in implementation instead of class extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL330559: update test to use ivar in implementation instead of class extension (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D

[PATCH] D45912: update test to use ivar in implementation instead of class extension

Wizard updated this revision to Diff 143494. Wizard added a comment. add back objc update for identifier naming check. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45912 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming-

[PATCH] D45912: update test to use ivar in implementation instead of class extension

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45912 Files: test/clang-tidy/readability-identifier-naming-objc.m Index: test/clang-tidy/readability-identifier-naming-objc.m ==

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE330492: [clang-tidy] add new check to find out objc ivars which do not have prefix '_' (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D45392?vs=142057&id=143408

[PATCH] D45750: add extra acronyms for objc property names

This revision was automatically updated to reflect the committed changes. Closed by commit rL330286: add extra acronyms for objc property names (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45750 Files: clang-tool

[PATCH] D45750: add extra acronyms for objc property names

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:42 constexpr llvm::StringLiteral DefaultSpecialAcronyms[] = { +"[2-9]G", "ACL", benhamilton wrote: > Probably should just make this: > > "\\d+G" > It seems llvm::

[PATCH] D45750: add extra acronyms for objc property names

Wizard updated this revision to Diff 142985. Wizard marked 2 inline comments as done. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45750 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.

[PATCH] D45750: add extra acronyms for objc property names

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45750 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-declaration

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added inline comments. Comment at: test/clang-tidy/readability-identifier-naming-objc.m:4 +// RUN: [{key: readability-identifier-naming.ObjcIvarPrefix, value: '_'}]}' \ +// RUN: -- + alexfh wrote: > The `--` and the trailing backslash above can be removed

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added inline comments. Comment at: test/clang-tidy/readability-identifier-naming-objc.m:8-9 +// RUN: ]}' -- -fno-delayed-template-parsing \ +// RUN: -I%S/Inputs/readability-identifier-naming \ +// RUN: -isystem %S/Inputs/readability-identifier-naming/system + ---

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 142057. Wizard added a comment. remove unnecessary flags Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming-objc.m Index: test/clan

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1063164, @alexfh wrote: > In https://reviews.llvm.org/D45392#1061960, @Wizard wrote: > > > In https://reviews.llvm.org/D45392#1061433, @alexfh wrote: > > > > > I wonder whether the readability-identifier-naming check could be > > > exten

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 141938. Wizard added a comment. move check to readability-identifier-naming Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/readability/IdentifierNamingCheck.cpp test/clang-tidy/readability-identifier-naming-objc.m

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1061433, @alexfh wrote: > I wonder whether the readability-identifier-naming check could be extended to > support this use case instead of adding a new check specifically for > underscores in ivar names? Hmm readability-identifier-nam

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 141574. Wizard added a comment. reorder release note for alphabetical order Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/IvarDeclarationCheck.cpp clang-tidy/objc/IvarDeclara

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1060971, @Eugene.Zelenko wrote: > In https://reviews.llvm.org/D45392#1060912, @Wizard wrote: > > > In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote: > > > > > In https://reviews.llvm.org/D45392#1060845, @Wizard wrote: > >

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard added a comment. In https://reviews.llvm.org/D45392#1060854, @Eugene.Zelenko wrote: > In https://reviews.llvm.org/D45392#1060845, @Wizard wrote: > > > In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote: > > > > > If this is Apple guideline, check name should reflect this. I

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 141515. Wizard edited the summary of this revision. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/IvarDeclarationCheck.cpp clang-tidy

[PATCH] D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'

Wizard marked 4 inline comments as done. Wizard added a comment. In https://reviews.llvm.org/D45392#1060485, @Eugene.Zelenko wrote: > If this is Apple guideline, check name should reflect this. I think will be > good idea to have general check for Apple naming conventions instead of > separate

[PATCH] D45392: add new check to find out objc ivars which do not have prefix '_'

Wizard updated this revision to Diff 141444. Wizard added a comment. fix doc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/IvarDeclarationCheck.cpp clang-tidy/objc/IvarDeclarationCheck.h clang-tidy/objc/ObjCTi

[PATCH] D45392: add new check to find out objc ivars which do not have prefix '_'

Wizard created this revision. Herald added subscribers: cfe-commits, mgorny, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45392 Files: clang-tidy/objc/CMakeLists.txt clang-tidy/objc/IvarDeclarationCheck.cpp clang-tidy/objc/IvarDeclarationCheck.h clang-tidy/objc/

[PATCH] D44634: [clang-format] Detect Objective-C for #import

Wizard added a comment. For some ObjC headers it uses #import to import other headers instead of system framework, so I think we should also detect #import "*.h" as well. The only usage of #import in C++ is to import type library, which won't have suffix of ".h". Repository: rC Clang http

[PATCH] D44634: [clang-format] Detect Objective-C for #import

Wizard added a comment. Why do we only detect system framework? I think any #import could indicate ObjC header. Repository: rC Clang https://reviews.llvm.org/D44634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D44174: do not register matcher for objc-only checks when analyzing non-objc sources to save resources

This revision was automatically updated to reflect the committed changes. Closed by commit rL326928: do not register matcher for objc-only checks when analyzing non-objc sources to… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://review

[PATCH] D44174: do not register matcher for objc-only checks when analyzing non-objc sources to save resources

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44174 Files: clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp clang-tidy/objc/AvoidNSErrorInitCheck.cpp clang-tidy/objc/ForbiddenSubclassingCheck

[PATCH] D43775: add UUID to the acronyms list of objc property name checks

This revision was automatically updated to reflect the committed changes. Closed by commit rL326222: add UUID to the acronyms list of objc property name checks (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43775 Fil

[PATCH] D43775: add UUID to the acronyms list of objc property name checks

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE326222: add UUID to the acronyms list of objc property name checks (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D43775?vs=136100&id=136102#toc Repository:

[PATCH] D43775: add UUID to the acronyms list of objc property name checks

Wizard updated this revision to Diff 136100. Wizard added a comment. resolve comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43775 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp Index: clang-tidy/objc/PropertyDeclarationCheck.cpp

[PATCH] D43775: add UUID to the acronyms list of objc property name checks

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Wizard added reviewers: benhamilton, hokein. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43775 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp Index: clang-tidy/objc/PropertyDeclarationCheck.c

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

This revision was automatically updated to reflect the committed changes. Closed by commit rL326046: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧 (authored by Wizard, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: http

[PATCH] D43581: [clang-tidy/google] Improve the Objective-C global variable declaration check 🔧

Wizard added a comment. In https://reviews.llvm.org/D43581#1018584, @stephanemoore wrote: > In https://reviews.llvm.org/D43581#1018499, @aaron.ballman wrote: > > > This LGTM! Do you need someone to commit on your behalf? > > > I would be happy to commit assuming that I am able to and can meet sub

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

Wizard added inline comments. Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92 + "an appropriate prefix (see " + "http://google.github.io/styleguide/objcguide#constants).") << Decl->getName() << generateFixItHint(Decl, true); --

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

Wizard accepted this revision. Wizard added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D43581#1016318, @stephanemoore wrote: > In https://reviews.llvm.org/D43581#1016300, @Wizard wrote: > > > Please update the warning info to indicate that prefix 'k' i

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

Wizard updated this revision to Diff 135485. Wizard added a comment. fix format Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43640 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/google-objc-global-variable-declaration.m Index: test/clang-tid

[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

Wizard requested changes to this revision. Wizard added a comment. This revision now requires changes to proceed. Please update the warning info to indicate that prefix 'k' is not the only option for constants. Something like: "const global variable '%0' must have an appropriate prefix or a name

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

Wizard added a comment. In https://reviews.llvm.org/D43640#1016287, @stephanemoore wrote: > I have this change out for review as well: > https://reviews.llvm.org/D43581 Ah cool. Your change looks good. Technically the same as mine. I will discard this diff. Repository: rCTE Clang Tools Ex

[PATCH] D43640: add support for constants with appropriate prefix. Start with 'k' is not the only option. This is according to http://google.github.io/styleguide/objcguide.html#constants

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43640 Files: clang-tidy/google/GlobalVariableDeclarationCheck.cpp test/clang-tidy/google-objc-global-variable-declaration.m Index: test/clang-tidy/goo

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324407: Support special acronyms inside property names and allow plural forms (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D42947?vs=133069&id=133071#toc Rep

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133069. Wizard added a comment. minor fix according to comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133066. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:142 - return StartMatcher + "((" + - llvm::join(EscapedAcronyms.begin(), EscapedAcronyms.end(), "|") + - ")[A-Z]?)?[a-z]+[a-z0-9]*([A-Z][a-z0-9]+)*" + "(" + - llvm::j

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 132938. Wizard added a comment. resolve conflict in doc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-pr

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-property-declarati

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323722: add prefix with '_' support for property name. Corresponding apple dev doc… (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D42464?vs=131904&id=131907#to

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131904. Wizard added a comment. merge changes and add EscapedAcronyms to store the actual acronyms during runtime. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp clang-tidy/objc/

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:151 + hasCategoryPropertyPrefix(MatchedDecl->getName())) { +const auto *CategoryDecl = (const ObjCCategoryDecl *)(DeclContext); +if (!prefi

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131877. Wizard marked 2 inline comments as done. Wizard added a comment. add more tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declara

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131869. Wizard added a comment. resolve comments and fix some logic Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clan

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:115 + +bool prefixedPropertyNameMatches(const llvm::StringRef &PropertyName, + const std::vector &Acronyms) { --

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131741. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-propert

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131511. Wizard marked 8 inline comments as done. Wizard added a comment. update some documents and comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/o

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:93 + [](const std::string &s) { return llvm::Regex::escape(s); }); // Allow any of these names: // foo hokein wrote: > Does the comment still make sense?

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard marked 7 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:120 + auto RegexExp = llvm::Regex( + llvm::StringRef(validPropertyNameRegex(Acronyms).replace(0, 2, "^"))); + return RegexExp.match(llvm::StringR

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131368. Wizard marked an inline comment as done. Wizard added a comment. check for class extentsion Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-prop

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:102 +bool hasCategoryPropertyPrefix(const llvm::StringRef &PropertyName) { + for (size_t i = 0; i < PropertyName.size() - 1; ++i) { +if (PropertyName[i] == '_') { benhamil

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-property-declarati

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

Wizard added a comment. Can you update the doc btw since the acronyms are not only for prefix anymore? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322602: add ID as a special acronym to objc property declaration check for property… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.ll

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Wizard retitled this revision from "add ID as a special acronym to objc property declaration check for property names like bundleID. allow using acronyms as suffix." to "add ID as a special acronym to objc property decla

[PATCH] D40528: add new check to find NSError init invocation

Wizard updated this revision to Diff 124972. Wizard added a comment. restore file names Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40528 Files: clang-tidy/objc/AvoidNSErrorInitCheck.cpp clang-tidy/objc/AvoidNSErrorInitCheck.h clang-tidy/objc/CMakeLists.txt clang-tid

[PATCH] D40528: add new check to find NSError init invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rL319460: add new check to find NSError init invocation (authored by Wizard). Changed prior to commit: https://reviews.llvm.org/D40528?vs=124972&id=124973#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D40528: add new check to find NSError init invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rL319459: add new check to find NSError init invocation (authored by Wizard). Changed prior to commit: https://reviews.llvm.org/D40528?vs=124972&id=124974#toc Repository: rL LLVM https://reviews.llvm.

[PATCH] D40528: add new check to find NSError init invocation

Wizard updated this revision to Diff 124971. Wizard added a comment. change file name cases Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40528 Files: clang-tidy/objc/AvoidNSEErrorInitCheck.cpp clang-tidy/objc/AvoidNSEErrorInitCheck.h clang-tidy/objc/CMakeLists.txt cla

[PATCH] D40528: add new check to find NSError init invocation

Wizard added inline comments. Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10 +``errorWithDomain:code:userInfo:`` to create new NSError objects instead +of ``[NSError alloc] init]``. Otherwise it will lead to a warning message +during compilation in Xcode. -

[PATCH] D40528: add new check to find NSError init invocation

Wizard updated this revision to Diff 124818. Wizard marked 3 inline comments as done. Wizard added a comment. address comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40528 Files: clang-tidy/objc/AvoidNserrorInitCheck.cpp clang-tidy/objc/AvoidNserrorInitCheck.h cla

[PATCH] D40528: add new check to find NSError init invocation

Wizard added inline comments. Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10 +``errorWithDomain:code:userInfo:`` to create new NSError objects instead +of ``[NSError alloc] init]``. Otherwise it will lead to a warning message +during compilation in Xcode. -

[PATCH] D40528: add new check to find NSError init invocation

Wizard updated this revision to Diff 124486. Wizard added a comment. new line for doc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40528 Files: clang-tidy/objc/AvoidNserrorInitCheck.cpp clang-tidy/objc/AvoidNserrorInitCheck.h clang-tidy/objc/CMakeLists.txt clang-tidy/

[PATCH] D40528: add new check to find NSError init invocation

Wizard created this revision. Herald added subscribers: cfe-commits, mgorny, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40528 Files: clang-tidy/objc/AvoidNserrorInitCheck.cpp clang-tidy/objc/AvoidNserrorInitCheck.h clang-tidy/objc/CMakeLists.txt clang-tidy/obj

[PATCH] D40325: add new check to find OSSpinlock usage

This revision was automatically updated to reflect the committed changes. Closed by commit rL319098: add new check to find OSSpinlock usage (authored by Wizard). Repository: rL LLVM https://reviews.llvm.org/D40325 Files: clang-tools-extra/trunk/clang-tidy/objc/AvoidSpinlockCheck.cpp clang

  1   2   >