[clang] [clang] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

vbe-sc wrote: @glandium, this is the fix for your example. Please, feel free to contact if you have any more troubles with this patch https://github.com/llvm/llvm-project/pull/119024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

vbe-sc wrote: > Can you confirm this is a fix for #118003 ? In which case we do not need > changelog entry Yes, you are right https://github.com/llvm/llvm-project/pull/119024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [clang] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

@@ -368,8 +368,8 @@ bool CXXRecordDecl::FindBaseClass(const CXXBaseSpecifier *Specifier, const CXXRecordDecl *BaseRecord) { assert(BaseRecord->getCanonicalDecl() == BaseRecord && "User data for FindBaseClass is not canonical!"); -

[clang] [clang] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/119024 >From ce758d5e8cf958edbfffeee8fe4c978011554b53 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Fri, 6 Dec 2024 23:06:01 +0300 Subject: [PATCH] [clang][NFC] Fix cast for injected types in case name lookup for dependen

[clang] [clang][NFC] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

vbe-sc wrote: @erichkeane, @cor3ntin, could you, please, take a look at this fix? https://github.com/llvm/llvm-project/pull/119024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/119024 >From e3fd6b1d8408439e200622f577451d144ef8f720 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Fri, 6 Dec 2024 23:06:01 +0300 Subject: [PATCH] [clang][NFC] Fix cast for injected types in case name lookup for dependen

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

vbe-sc wrote: @glandium, I've provided the fix in this PR (https://github.com/llvm/llvm-project/pull/119024). https://github.com/llvm/llvm-project/pull/118003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [clang][NFC] Fix cast for injected types in case name lookup for dependent bases (PR #119024)

https://github.com/vbe-sc created https://github.com/llvm/llvm-project/pull/119024 An assertion failure occurs in Clang when attempting to compile such an example: ```c++ template struct MozPromise { class Private; private: int mMagic4 = 42; }; template struct MozPromise::Private : Moz

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

vbe-sc wrote: > I was creducing it (well, cvise-ing). Here's a reproducer: > > ``` > template struct MozPromise { > class Private; > > private: > void *mMagic4; > }; > template > struct MozPromise::Private > : MozPromise { > void SetTaskPriority() { mMagic4 } > } > ``` Thanks, I'll

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

vbe-sc wrote: > I'm hitting an assertion on some Firefox code after this landed: > > ``` > clang++: /tmp/llvm/llvm/include/llvm/Support/Casting.h:566: decltype(auto) > llvm::cast(const From &) [To = cl > ang::RecordType, From = clang::QualType]: Assertion `isa(Val) && > "cast() argument of inc

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

vbe-sc wrote: @cor3ntin, FYI: we reverted the patch you merged before. This is the second attempt https://github.com/llvm/llvm-project/pull/118003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

@@ -1178,17 +1178,61 @@ namespace cwg590 { // cwg590: yes template typename A::B::C A::B::C::f(A::B::C) {} } -namespace cwg591 { // cwg591: no +namespace cwg591 { // cwg591: yes vbe-sc wrote: Done https://github.com/llvm/llvm-project/pull/118003 __

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

@@ -3599,7 +3599,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/591.html";>591 CD4 When a dependent base class is the current instantiation -No +Yes vbe-sc wrote: Done https://github.com/llvm/llvm-proj

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/118003 >From 98583ff617a4d527041c683e98904ed063467c50 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/docs/ReleaseNotes.

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

https://github.com/vbe-sc edited https://github.com/llvm/llvm-project/pull/118003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

vbe-sc wrote: @erichkeane, @nikic This is the second version of this patch. I’m not entirely sure if my suggestion regarding the redundant assertion is correct, but I’d like to share some thoughts on the clang build time regression: According to the actual implementation of `CXXRecordDecl::loo

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

https://github.com/vbe-sc created https://github.com/llvm/llvm-project/pull/118003 Unlike the previous version, this patch also removes an unnecessary assert that causes Clang to crash when compiling such tests. (clang/lib/AST/DeclCXX.cpp) https://lab.llvm.org/buildbot/#/builders/52/builds/402

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: ```c++ void CXXMethodDecl::addOverriddenMethod(const CXXMethodDecl *MD) { assert(MD->isCanonicalDecl() && "Method is not canonical!"); assert(!MD->getParent()->isDependentContext() && "Can't add an overridden method to a class template!"); ``` It seems to me that the s

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: Such an example causes a failure in my patch ```c++ template class X { public: X() = default; virtual ~X() = default; virtual int foo(int x, int y, T &entry) = 0; void bar() { struct Processor : public X { Processor() : X() {} int foo(int, int, T &) ove

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

@@ -268,6 +268,9 @@ Resolutions to C++ Defect Reports by default. (`CWG2521: User-defined literals and reserved identifiers `_). +- Clang now make correct name lookup when dependent base class is the current instantiation

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

@@ -268,6 +268,9 @@ Resolutions to C++ Defect Reports by default. (`CWG2521: User-defined literals and reserved identifiers `_). +- Clang now make correct name lookup when dependent base class is the current instantiation

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 6564e20ae7fc69849b6787afa12f68b712f4df12 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/docs/ReleaseNotes.

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: @cor3ntin could you, please, re-review this patch and resolve the comments if everything is ok? https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: @sdkrystian, can you, please, re-review this patch? It seems like I fixed your test https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: > Can you add a release note I added a release note as you asked https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From d17588af72f845b758a03637c84752dde733200c Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/docs/ReleaseNotes.

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

@@ -170,13 +170,21 @@ bool CXXBasePaths::lookupInBases(ASTContext &Context, QualType BaseType = Context.getCanonicalType(BaseSpec.getType()).getUnqualifiedType(); +bool isCurrentInstantiation = isa(BaseType); +if (!isCurrentInstantiation) { + if (auto

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From e2e490717b1abe440556f2d8c439b3ee18b31642 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 2f7c7634ae22e53c5ffd645c5d544b36d108a25b Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From f3b8ee95f1b3759f7d0dbc12f856a13ca9f01e0f Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 5a48960ab73890b10381b4e7ebd32d3f66246bdd Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 11c24e5592bfdf8849bb415580d37a6f545e4952 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 11c24e5592bfdf8849bb415580d37a6f545e4952 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 0de2ff271efd672bae0b4974c404149da79ff747 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: > I don't think this patch fixes the following case: > > ```c++ > template > struct A > { > struct B > { > using X = int; > > struct C > { > using X = void; > > struct D; > }; > }; > }; > > template > struct

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: > Please wait for a week before pinging someone again. > > I think this is fine to merge as is, if you want to go ahead. We can always > do post commit review later. Sorry, I didn't know. Let's do it this way you want https://github.com/llvm/llvm-project/pull/114978 ___

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: @sdkrystian, could you, please, take a look? We are about to merge this https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: @sdkrystian ping https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: > @vbe-sc I can later today or tomorrow. That's would be great, thank you! https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: @sdkrystian, could you please take a look? https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: @sdkrystian, please, could you take a look? https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

@@ -265,8 +268,8 @@ bool CXXBasePaths::lookupInBases(ASTContext &Context, BaseRecord = nullptr; } } else { -BaseRecord = cast( -BaseSpec.getType()->castAs()->getDecl()); +if (auto *RT = BaseSpec.getType()->getAs()) +

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

@@ -169,14 +169,18 @@ bool CXXBasePaths::lookupInBases(ASTContext &Context, // Find the record of the base class subobjects for this type. QualType BaseType = Context.getCanonicalType(BaseSpec.getType()).getUnqualifiedType(); +bool isCurrentInstantiation = f

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 66f3465737a99a002310b707f7783698adef253a Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: > > @Endilll, please, could you take a look? > > My knowledge of wording about templates is not deep enough, unfortunately. Could you, please, suggest someone who can review this part? https://github.com/llvm/llvm-project/pull/114978 __

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

vbe-sc wrote: @Endilll, please, could you take a look? Also, do you have any ideas why the Win pipeline fails with checkout failure? How can I fix it? https://github.com/llvm/llvm-project/pull/114978 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/114978 >From 0c2363cb2ab24d0b4d9998943772f9105437579e Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/lib/AST/CXXInherit

[clang] [Clang] Fix name lookup for dependent bases (PR #114978)

https://github.com/vbe-sc created https://github.com/llvm/llvm-project/pull/114978 Currently the following example is a compilation failure: ``` template struct A { typedef int M; struct B { typedef void M; struct C; }; }; template struct A::B::C : A { M m; // void

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/100110 >From 2dba8f9f90369f79f97fc5efb1272b75d61d36b2 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Wed, 31 Jul 2024 13:37:34 +0300 Subject: [PATCH] [RISCV] full support for riscv_rvv_vector_bits attribute --- clang/incl

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

@@ -1,7 +1,7 @@ // RUN: %clang_cc1 -triple riscv64-none-linux-gnu %s -emit-llvm -o - \ // RUN: -target-feature +f -target-feature +d -target-feature +zfh \ // RUN: -target-feature +zve64d -target-feature +zvfh -mvscale-min=1 \ -// RUN: -mvscale-max=1 | FileCheck %s --check-

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/100110 >From 2dba8f9f90369f79f97fc5efb1272b75d61d36b2 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Wed, 31 Jul 2024 13:37:34 +0300 Subject: [PATCH] [RISCV] full support for riscv_rvv_vector_bits attribute --- clang/incl

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

vbe-sc wrote: @topperc, ping https://github.com/llvm/llvm-project/pull/100110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

@@ -176,477 +177,3110 @@ typedef vbool1_t fixed_bool1_t __attribute__((riscv_rvv_vector_bits(__riscv_v_fi typedef vbool2_t fixed_bool2_t __attribute__((riscv_rvv_vector_bits(__riscv_v_fixed_vlen/2))); typedef vbool4_t fixed_bool4_t __attribute__((riscv_rvv_vector_bits(__riscv

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

@@ -572,1483 +1121,44 @@ void f() { //===--===// // Structs and unions //===--===// -// CHECK-64: %struct.struct_int8m1 = type { <8 x i

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/100110 >From 33cfa736bb19c6c8ef2d214ecafbc50605eea5eb Mon Sep 17 00:00:00 2001 From: vb-sc Date: Wed, 31 Jul 2024 13:37:34 +0300 Subject: [PATCH] [RISCV] full support for riscv_rvv_vector_bits attribute --- clang/incl

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

vbe-sc wrote: @topperc, could you please have a look at this patch https://github.com/llvm/llvm-project/pull/100110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits