[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

2022-08-17 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added a comment. In D131678#3728412 , @njames93 wrote: > Would you like me to commit it on your behalf again? Yes, the email is the same - vladimir.plyash...@jetbrains.com Reposito

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

2022-08-16 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 452936. vladimir.plyashkun added a comment. - return operand source range in too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131678/new/ https://reviews.llvm.org/D131678 Files: clang-tools-extra

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

2022-08-15 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 452605. vladimir.plyashkun added a comment. - Executed clang-format after changes - Return operator location (in additional range) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131678/new/ https://re

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

2022-08-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. In D131590#3716471 , @njames93 wrote: > In D131590#3716358 , > @vladimir.plyashkun wrote: > >> Sure it's up to you, it's my github >> ac

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

2022-08-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:100 "%select{binary|unary}0 bitwise operator") - << IsUnary << SignedOperand->getSourceRange(); + << IsUnary << Location; } ---

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

2022-08-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. In D131590#3716317 , @njames93 wrote: > In D131590#3713824 , > @vladimir.plyashkun wrote: > >> In D131590#3713731 , @njames93 >> wrot

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

2022-08-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Hi @carlosgalvezp Yes, sorry, maybe screenshot and example from issue in our bugtracker is not the best one. You can check it on this sample from clang-tidy tests: The "hicpp-signed-bitwise" will point to URes = UValue & -

[PATCH] D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning)

2022-08-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: JonasToth, steveire, njames93. vladimir.plyashkun added a project: clang-tools-extra. Herald added a subscriber: carlosgalvezp. Herald added a project: All. vladimir.plyashkun requested review of this revision. Herald add

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

2022-08-10 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. In D131590#3713731 , @njames93 wrote: > Can this be backported as well. I guess someone needs to do it, because i haven't got commit/write access in LLVM repository. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D131590: Fixed page title for abseil-no-internal-dependencies check documentation

2022-08-10 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: aaron.ballman, ivanmurashko, njames93. vladimir.plyashkun added a project: clang-tools-extra. Herald added a project: All. vladimir.plyashkun requested review of this revision. Herald added a subscriber: cfe-commits. It

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-23 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added a comment. In D68694#1711035 , @aaron.ballman wrote: > LGTM aside from a small nit. Thanks, fixed it! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-23 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 226101. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tools-extra/clang-tidy/hicpp/

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-15 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. In D68694#1706204 , @JonasToth wrote: > > Do you know who is responsible for it? Because i haven't worked with > > documentation before and don't know what i need to do to update it. > > The files reside in `clang-tools

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-15 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 224976. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tools-extra/clang-tidy/hicpp/

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. In D68694#1705668 , @JonasToth wrote: > The new switch needs documentation as well, and maybe even a note in the > release notes (as it is publicly discussed as issue?). Do you know who is responsible for it? Because

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 224597. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694 Files: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp clang-tools-extra/clang-tidy/hicpp/

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun marked 2 inline comments as done. vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlob

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun marked an inline comment as done. vladimir.plyashkun added inline comments. Comment at: clang-tools-extra/clang-tidy/hicpp/SignedBitwiseCheck.cpp:23-24 +: ClangTidyCheck(Name, Context), + IgnorePositiveIntegerLiterals( + Options.getLocalOrGlob

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. @aaron.ballman @JonasToth Thanks, i agree too! I've prepared new revision with additional option to preserve old inspection behaviour. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 224557. vladimir.plyashkun added a comment. Provide additional option to preserve current inspection behaviour Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68694/new/ https://reviews.llvm.org/D68694

[PATCH] D68694: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

2019-10-09 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added a reviewer: JonasToth. vladimir.plyashkun added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. Hi! Clang-Tidy has been integrated in CLion some time ago, but a lot of use

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-22 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 130891. vladimir.plyashkun added a comment. Thanks, now all should be fine! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/tool/ClangTidyMain.cpp tes

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-22 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. In https://reviews.llvm.org/D41535#981928, @ilya-biryukov wrote: > This looks good, but we should add a test. > Should've noticed that before, sorry for the slowing this down a bit more. > After the test is there, I'm happy to commit this change for you. II

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-19 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 130589. vladimir.plyashkun added a comment. Some more nits were fixed. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/tool/ClangTidyMain.cpp Index: cl

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-19 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 130578. vladimir.plyashkun added a comment. Fixed code review remarks. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/tool/ClangTidyMain.cpp Index: cl

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

2018-01-19 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 130573. vladimir.plyashkun added a comment. Fixed comment Repository: rC Clang https://reviews.llvm.org/D41947 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp unittests/Tooling/ToolingTest.cpp Index: unittests/Tooling/To

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

2018-01-18 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. In https://reviews.llvm.org/D41947#980298, @ilya-biryukov wrote: > Looks good. Do you have commit access or do you need someone to land this > patch for you? No, i don't have commit access. Repository: rC Clang https://reviews.llvm.org/D41947 ___

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-18 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 130385. vladimir.plyashkun added a comment. Moved logic to `ClangTidyMain` Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/tool/ClangTidyMain.cpp Index

[PATCH] D41947: Provide default virtual filesystem argument to ClangTool constructor

2018-01-18 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 130382. vladimir.plyashkun added a comment. Implemented test-case to check that `BaseFS` is actually used in `ClangTool` Repository: rC Clang https://reviews.llvm.org/D41947 Files: include/clang/Tooling/Tooling.h lib/Tooling/Tooling.cpp

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-17 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Friendly ping Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Second part here (provided default virtual filesystem argument to ClangTool constructor): https://reviews.llvm.org/D41947 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mail

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2018-01-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 129440. vladimir.plyashkun added a reviewer: ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/ClangTidyOptions.cpp clang

[PATCH] D41947: Provide default virtual filesystem argument in ClangTool constructor

2018-01-11 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: alexfh, ilya-biryukov. vladimir.plyashkun added a project: clang. Herald added a subscriber: klimek. This revision is part of another review. Check this link for more details - https://reviews.llvm.org/D41535 Repositor

[PATCH] D41594: Support `ivfsoverlay` option in Tooling

2017-12-28 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: lib/Tooling/Tooling.cpp:287 + if (Files->getVirtualFileSystem() != VirtualFileSystem) { +Files = new FileManager(Invocation->getFileSystemOpts(), VirtualFileSystem); + } ilya-biryukov wrote: > `Files` i

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2017-12-27 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. FYI, i've create revision to support `ivfsoverlay` option in Tooling: https://reviews.llvm.org/D41594 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits

[PATCH] D41594: Support `ivfsoverlay` option in Tooling

2017-12-27 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: bkramer, alexfh, ilya-biryukov. vladimir.plyashkun added a project: clang. Herald added a subscriber: klimek. Previously, this argument had no effect, since it didn't proceeded. For more information, check this review: h

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2017-12-24 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. @ilya-biryukov Yes, this is exactly what i need. Unfortunately, `-ivfsoverlay` in the compile commands works for the compiler invocation, but it doesn't work for tooling. E.g. this call: clang-tidy -checks=* -- -ivfsoverlay= has no effect. Repository:

[PATCH] D41536: Provide public getter for OverlayFileSystem

2017-12-21 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added a reviewer: alexfh. vladimir.plyashkun added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, klimek. This is part of review - https://reviews.llvm.org/D41535 Repository: rC Clang https://reviews.llvm

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2017-12-21 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Second part of review - https://reviews.llvm.org/D41536 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/m

[PATCH] D41535: Add -vfsoverlay option for Clang-Tidy

2017-12-21 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added reviewers: alexfh, benlangmuir. vladimir.plyashkun added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These changes introduce support for -vfsoverlay option in Clang-Tidy The main reason for it: In IDE inte

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-08-16 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. @alexf Thanks for the response! Yes, we re-implemented logic and now use JSON compilation database to pass compiler options to Clang-Tidy. Anyway, i think in general it's useful to support @response_files, see my comment: https://reviews.llvm.org/D34440#813411

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-31 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. > Many build systems normally generate response files on-fly in some > circumstances (e.g. if command line is longer than some platform-imposed > limit). So IMO response files should be a perfect citizen here. friendly ping Repository: rL LLVM https://re

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-18 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Thanks for the response @klimek ! Sorry for possible confusions. > Yes. I'm still confused why in this case clang-tidy @file -- would be > expected to expand the response file? Am I missing something? I think that we discussed use-case when @response files c

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-18 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. > If you want one unified format, the compilation database is it. Is the `clang-tidy ... -- ` meant to be more or less a drop-in replacement for `clang ` (arguments-wise)? If yes, this expansion of response files here is an another step in this direction. O

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-14 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. > Are there any concerns using the alternative? I can't say that it's a big problems, but i think that: //CompilationDatabase.json// is more //CMake //specific format. It can be generated automatically by //CMake//, while other build systems may not do it. So

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-14 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Even if i'll change content of //arguments.rsp// to `-std=c++11 -Ipath/to/include -Ipath/to/include2 -DMACRO ` and will try to call clang-tidy process in this way: `clang-tidy -checks=* main.cpp -export-fixes=... -- @arguments.rsp` it also has no effect, bec

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-14 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Thanks @klimek for the response! Let me give an example. Suppose we want to check //main.cpp// by clang-tidy. As i said before, i cannot use //CompilationDatabase.json// (due to some technical reasons), but there is way to pass all options though command line

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. **To discuss:** This patch is required for correct integration //Clang-Tidy// with //CLion IDE//. By this moment, we unable to use //CompilationDatabase.json// from //CLion //side which is widely used in //Clang-Tidy// and in other common tools. Anyway, there

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 106436. vladimir.plyashkun added a comment. - trailing period - moved test-cases to separate file Repository: rL LLVM https://reviews.llvm.org/D34440 Files: lib/Tooling/CommonOptionsParser.cpp unittests/Tooling/CMakeLists.txt unittests/T

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: unittests/Tooling/CompilationDatabaseTest.cpp:638-652 + ParseCompilationDatabaseFromResponseFileTest() { +std::error_code EC = llvm::sys::fs::createUniqueDirectory("unittest", TestDir); +EXPECT_TRUE(!EC); +llvm::

[PATCH] D35349: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. This is second part of review: https://reviews.llvm.org/D34404 which is contains changes related to clang-tools-extra repository. Repository: rL LLVM https://reviews.llvm.org/D35349 ___ cfe-commits mailing lis

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. I've splitted single revision into two different revisions: https://reviews.llvm.org/D34404 https://reviews.llvm.org/D35349 Also, i fixed failing test-cases in clang-apply-replacements due to changes in output format (so they shouldn't be a problem anymore) R

[PATCH] D35349: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added a project: clang-tools-extra. Herald added subscribers: xazax.hun, JDevlieghere, mgorny. To get properly integration Clang-Tidy with CLion IDE, next things were implemented: - Preserve `Message`, `FileOffset`, `FilePath` in the c

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-13 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 106402. vladimir.plyashkun added a comment. 1. split revision into two 2. fix failing tests Repository: rL LLVM https://reviews.llvm.org/D34404 Files: include/clang/Tooling/DiagnosticsYaml.h unittests/Tooling/CMakeLists.txt unittests/Too

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 105283. vladimir.plyashkun edited the summary of this revision. vladimir.plyashkun added a comment. - made code less verbose - used assignment initialization form - removed extra `.c_str()` call Repository: rL LLVM https://reviews.llvm.org/D344

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added a comment. Thanks, Alex for your suggestions. I agree with your remarks, but i thought it's only style preferences. I'll fix it soon. Repository: rL LLVM https://reviews.llvm.org/D34404 ___ cfe-commits mailing list cfe-co

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 105260. vladimir.plyashkun added a comment. - marked some arguments as `const` - use `{}` instead of explicit variable declarations Repository: rL LLVM https://reviews.llvm.org/D34404 Files: include/clang/Tooling/DiagnosticsYaml.h unittest

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:23 + SmallVector EmptyNotes; + return tooling::Diagnostic(DiagnosticName, Message, Replacements, EmptyNotes, + tooling::Diagnostic::War

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 105240. vladimir.plyashkun added a comment. - use `EXPECT_*` instead of `ASSERT_*` where it's possible - `Diagnostic` constructor now takes `const` references for it's arguments - removed extra namespace qualifiers Repository: rL LLVM https://r

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:18 + +static tooling::Diagnostic makeDiagnostic(const StringRef DiagnosticName, + DiagnosticMessage &Message, --

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun added inline comments. Comment at: unittests/clang-apply-replacements/ApplyReplacementsTest.cpp:23 + SmallVector EmptyNotes; + return tooling::Diagnostic(DiagnosticName, Message, Replacements, EmptyNotes, + tooling::Diagnostic::War

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-07-05 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 105153. vladimir.plyashkun added a subscriber: alexfh. vladimir.plyashkun added a comment. - moved test-case from separate file to existing one - fixed `No newline at end of file` problem and put space inside comment Repository: rL LLVM https:/

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-07-03 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 105078. vladimir.plyashkun added a comment. Herald added a subscriber: JDevlieghere. - fixed `No newline at end of file` problem - provided test-case to check that diagnostics with no fixes will be applied correctly Repository: rL LLVM https:/

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-06-21 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 103353. vladimir.plyashkun added a comment. correct revision with all changes Repository: rL LLVM https://reviews.llvm.org/D34404 Files: include/clang/Tooling/DiagnosticsYaml.h unittests/Tooling/CMakeLists.txt unittests/Tooling/Diagnosti

[PATCH] D34404: [Clang-Tidy] Preserve Message, FileOffset, FilePath in Clang-Tidy YAML output

2017-06-21 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun updated this revision to Diff 103341. vladimir.plyashkun added a comment. Herald added subscribers: xazax.hun, mgorny. updated CMakeLists.txt Repository: rL LLVM https://reviews.llvm.org/D34404 Files: unittests/Tooling/CMakeLists.txt Index: unittests/Tooling/CMakeLists

[PATCH] D34440: [Clang] Expand response files before loading compilation database

2017-06-21 Thread Vladimir Plyashkun via Phabricator via cfe-commits
vladimir.plyashkun created this revision. vladimir.plyashkun added a project: clang. Herald added a subscriber: mgorny. Due to command line length restrictions, arguments can be passed through response files. Before trying to load compilation database from command line, response files should be