[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. In D159115#4641834 , @mgorny wrote: > Is that actually a regression, or merely the test wasn't checking it before? I can't tell because the test didn't exist before. > My educated guess would be that the code in the test redefine

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. Let me elaborate my previous comment... I'm using Fedora, which has switched the default long double on ppc64le to IEEE 128-bit floating point. glibc provides 2 printf implementations on ppc64le (different symbols). The headers control which implementation is used. I won

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. In D159115#4640388 , @mgorny wrote: > I'm sorry, by "new" you mean the version with `uintptr_t` or the original as > well? Both with `uintptr_t` as well as `unsigned long long`. In D159115#4641721

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

tuliom added a comment. This new test does not work on ppc64le. The returned addresses are different: Expected equality of these values: (uintptr_t)&printf Which is: 140735424286016 Addr->getValue() Which is: 140735424167152 Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

tuliom added a comment. Are there any plans to align the names of these built-ins with GCC? Their built-ins do not have the `_ppc` part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158066/new/ https://reviews.llvm.org/D158066 __

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

tuliom accepted this revision. tuliom added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158065/new/ https://reviews.llvm.org/D158065 ___

[PATCH] D155192: [clang] scan-view: Remove unused python import

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1be4db73642f: [clang] scan-view: Remove unused python import (authored by tuliom). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D155192: [clang] scan-view: Remove unused python import

tuliom created this revision. tuliom added a reviewer: clang. tuliom added a project: clang. Herald added a project: All. tuliom requested review of this revision. Herald added a subscriber: cfe-commits. [clang] scan-view: Remove unused python import Python's module imp is not being used and is n

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

tuliom added inline comments. Comment at: clang/test/CodeGenCXX/macro-prefix-map-lambda.cpp:11 + auto *s = lambdatest([](){}); +// CHECK: @"__PRETTY_FUNCTION__._Z10lambdatestIZ4mainE3$_0EDaOT_" = private unnamed_addr constant [{{[0-9]+}} x i8] c"auto lambdatest(f &&) [f = (lamb

[PATCH] D150087: [Clang] Support more stdio builtins

tuliom accepted this revision. tuliom added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150087/new/ https://reviews.llvm.org/D150087 __

[PATCH] D150087: [Clang] Support more stdio builtins

tuliom requested changes to this revision. tuliom added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:109 + {Builtin::BI__builtin___vsnprintf_chk, "__vsnprintfieee128"}, + {Builtin::BI__builtin___vsprintf_chk

[PATCH] D149633: [clang][codegen] Add F128 vsnprintf_chk builtin

tuliom requested changes to this revision. tuliom added a comment. This revision now requires changes to proceed. @tbaeder Keep in mind that I don't think this will completely fix issue 61913 because there are other 2 functions affected. Otherwise, I believe this patch is in the right direction.

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

tuliom added a comment. @qiucf Thanks! I still don't have commit access yet. Could you land this patch for me, please? Please use “Tulio Magno Quites Machado Filho tul...@redhat.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

tuliom created this revision. tuliom added a reviewer: qiucf. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. tuliom requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ensure the tests do not fail during cros

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked an inline comment as done. tuliom added a comment. Thanks @qiucf ! I don't have commit access yet. Could you land this patch for me, please? Please use “Tulio Magno Quites Machado Filho tul...@redhat.com” to commit the change. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked 2 inline comments as done. tuliom added inline comments. Comment at: clang/test/Driver/lit.local.cfg:26 +if config.ppc_linux_default_ieeelongdouble == "ON": + config.available_features.add('ppc_linux_default_ieeelongdouble') qiucf wrote: > tuliom w

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom marked 3 inline comments as done. tuliom added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:74 +const Driver &D, +const llvm::opt::ArgList &Args) const { + if (Args.hasArg(options::OPT_nostdlib, options::OPT_nostdlibxx)) n

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom updated this revision to Diff 481730. tuliom added a comment. Fix the issues pointed by @nikic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139450/new/ https://reviews.llvm.org/D139450 Files: clang/lib/Driver/ToolChains/PPCLinux.cpp c

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom added a comment. In D139450#3981486 , @qiucf wrote: > Thanks for the patch! But does libc++ support to be built with > `-mabi=ieeelongdouble` now? @qiucf libc++ can be built with `-mabi=ieeelongdouble`, but it supports only a single long double

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom updated this revision to Diff 480858. tuliom added a comment. I'm attaching a new version of the patch. > Can you please upload the patch with full context (-U9)? @nikic Done! > The assumption here is that libc++ is being compiled with a compiler that has > the same ieeelongdouble d

[PATCH] D139450: Warn about unsupported ibmlongdouble

tuliom created this revision. tuliom added projects: clang, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. tuliom requested review of this revision. Herald added a subscriber: MaskRay. When -mabi=ieeelongdouble is enabled by default, libc++ does not support -mabi=ibmlong