[clang] [llvm] Revert "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations" (PR #139739)

2025-05-22 Thread Tristan Labelle via cfe-commits
tristanlabelle wrote: Hi @michael-jabbour-sonarsource , thanks for the ping! I agree with your views on how canonicalization should be defined and work in theory, but I am concerned about reconciliating it with the reality that: 1. Code pervasively access files through canonicalized paths rath

[clang] [llvm] Revert "[lit][clang] Avoid realpath on Windows due to MAX_PATH limitations" (PR #139739)

2025-05-14 Thread Tristan Labelle via cfe-commits
tristanlabelle wrote: Hi there, I'm the author of the original change. > The whole point of **canonical** paths is to be unique for a given entity > (directory or file), so that they can be directly compared to determine > whether or not two entities are the same. I agree with that intended d

[clang] [clang][ExtractAPI] Ensure LocationFileChecker doesn't try to traverse VFS when determining file path (PR #74071)

2023-12-01 Thread Tristan Labelle via cfe-commits
https://github.com/tristanlabelle approved this pull request. Looks good, thanks for catching this. https://github.com/llvm/llvm-project/pull/74071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang][ExtractAPI] Ensure LocationFileChecker doesn't try to traverse VFS when determining file path (PR #74071)

2023-12-01 Thread Tristan Labelle via cfe-commits
tristanlabelle wrote: @daniel-grumberg It's me. I'm looking at this https://github.com/llvm/llvm-project/pull/74071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits