tristanlabelle wrote:

Hi @michael-jabbour-sonarsource , thanks for the ping!

I agree with your views on how canonicalization should be defined and work in 
theory, but I am concerned about reconciliating it with the reality that:

1. Code pervasively access files through canonicalized paths rather than using 
canonicalized paths only for identity comparisons. The two usages are often 
conflated and can't be teased apart easily.
2. Hitting the Windows `MAX_PATH` limitation is a showstopper (broken builds or 
tests)

I don't think higher-level workarounds are possible (in APIs or in tests) 
because there is information loss once the lower levels have performed 
canonicalization, and lower levels can perform file accesses on paths that they 
have canonicalized.

I wish I had more alternatives to offer :/

https://github.com/llvm/llvm-project/pull/139739
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to