[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1844ab770cb9: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes. (authored by tmroeder). Repository: rG LLVM Github Monorepo

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2458715 , @tmroeder wrote: > Looks like I missed the transition of my credentials from SVN from github, so > I can't currently commit this. > > How do I go about getting those credentials restored? Never mind, I found

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. Looks like I missed the transition of my credentials from SVN from github, so I can't currently commit this. How do I go about getting those credentials restored? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 312256. tmroeder added a comment. Rebase to the latest head, mostly to force the CI infrastructure to run again now that it is said to work again: https://github.com/google/llvm-premerge-checks/issues/268#issuecomment-745979134. Repository: rG LLVM Gith

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311961. tmroeder added a comment. Explicitly instantiate the templates in the structural-equivalence test. This seems to work correctly on Windows, and it avoids the need for the extra hooks in the test framework. So, this diff removes those hooks as well a

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311738. tmroeder added a comment. Update to the latest head. No changes from previous diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTM

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2453124 , @tmroeder wrote: > Change the DeclMatcher.h test code to expose the ability to not assert on > null Nodes from a match. > > This allows the tests for GenericSelectionExpr to handle the null case on > Windows

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311706. tmroeder added a comment. Change the DeclMatcher.h test code to expose the ability to not assert on null Nodes from a match. This allows the tests for GenericSelectionExpr to handle the null case on Windows themselves without crashing, and to still

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2452174 , @martong wrote: > Thanks for the update. I checked it, still looks good to me. > > Some notes in parenthesis: > >> It looks like the problem is again due to delayed template parsing: the >> templatized functio

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311081. tmroeder added a comment. Removed an unintentionally added extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatchersRefere

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 311079. tmroeder added a comment. I think I've fixed the Windows tests; I got a build working on a Windows machine and was able to debug. It looks like the problem is again due to delayed template parsing: the templatized functions in the test both came ou

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310974. tmroeder added a comment. Rebased to the latest head version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatchersReference.html

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. In D92600#2445612 , @martong wrote: > I wouldn't worry much about the `ASTMerge` tests, those are mostly legacy and > not actively used nowadays. (At one point we were thinking even to remove > them because we could got rid of t

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310930. tmroeder added a comment. Fixed a formatting problem brought up by clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatc

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310701. tmroeder added a comment. Moved the result-dependent tests into a different test class, one that explicitly uses templates already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://rev

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added a comment. @aaron.ballman It looks like those template tests fail on x64 windows; this is a problem that came up with D58292 as well. It ended up getting rolled back because template-based tests failed on windows, and I had to remove the tests an

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder marked 2 inline comments as done. tmroeder added inline comments. Comment at: clang/test/ASTMerge/generic-selection-expr/Inputs/generic.c:1 +void f() { + int x; aaron.ballman wrote: > Should we also have a C++ test for a result-dependent use of _Generic

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310394. tmroeder edited the summary of this revision. tmroeder added a comment. Added C++ tests for result-dependent uses, and added that fact to the description as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310050. tmroeder added a comment. Fixed the clang-tidy warning as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatchersReferenc

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310047. tmroeder added a comment. Added structural equivalence and a few tests for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatche

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2366 +/// Matches C11 _Generic expression. +extern const internal::VariadicDynCastAllOfMatcher +genericSelectionExpr; aaron.ballman wrote: > Do we have a use case for ad

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 309406. tmroeder added a comment. Renamed context to ToCtx as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatchersReference.ht

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 309344. tmroeder edited the summary of this revision. tmroeder added a comment. Fix a typo in the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: cla

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder created this revision. tmroeder added reviewers: aaron.ballman, klimek. Herald added subscribers: teemperor, martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. tmroeder requested review of this revision. Herald added a project: clang. This allows ASTs to be merg

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

tmroeder added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/LinuxKernelTidyModule.cpp:25 "linuxkernel-must-check-errs"); +CheckFactories.registerCheck( +"linuxkernel-switch-semi"); Please fix the linter error, here a

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL367333: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs. (authored by tmroeder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

tmroeder updated this revision to Diff 212201. tmroeder added a comment. Sync to HEAD to prepare for commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65343/new/ https://reviews.llvm.org/D65343 Files: clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

tmroeder added a comment. Apologies about D59963 ; I should have waited longer to make sure things were resolved. My submission raced with a flip from being approved to land to not approved to land. I'll wait longer next time to make sure comments and approvals

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + tmroeder wrote: > nickdesaulniers wrote: > > tmro

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO``

[PATCH] D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs.

tmroeder created this revision. tmroeder added a reviewer: Eugene.Zelenko. Herald added a subscriber: xazax.hun. Herald added a project: clang. This changes ReleaseNotes.txt to have the first sentence of the full documentation from linuxkernel-must-use-errs.rst. This addresses a comment from the

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO``

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + nickdesaulniers wrote: > tmroeder wrote: > > lebe

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:77 + + This is important in the Linux kernel because ``ERR_PTR``, ``PTR_ERR``, + ``IS_ERR``, ``IS_ERR_OR_NULL``, ``ERR_CAST``, and ``PTR_ERR_OR_ZERO``

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. tmroeder marked an inline comment as done. Closed by commit rL367071: [clang-tidy] Add a module for the Linux kernel. (authored by tmroeder

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 211836. tmroeder added a comment. Synchronize the documentation, as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files: clang-tools-extra/clang-tidy/CM

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked 2 inline comments as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:75 + + Checks Linux Kernel code to see if it uses the results from the functions in + linux/err.h. Also checks to see if code uses the results from fun

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 211783. tmroeder added a comment. Sync'ing to the latest HEAD commit on master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files: clang-tools-extra/clang-tidy/C

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/test/clang-tidy/linuxkernel-must-check-errs.c:6 +// Prototypes of the error functions. +void * __must_check ERR_PTR(long error); +long __must_check PTR_ERR(const void *ptr);

[PATCH] D63533: [analyzer] Fix clang-tidy crash on GCCAsmStmt

tmroeder added a comment. I can confirm that this fixes the clang-tidy crash I observed in trying to analyze the kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63533/new/ https://reviews.llvm.org/D63533 __

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196273. tmroeder added a comment. Remove an unnecessary header and fix the error text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files: clang-tools-extra/clang

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked 5 inline comments as done. tmroeder added a comment. Thanks to everyone for the comments. I've answered them as best I can, and I'm definitely open to changes or to scrapping this entirely. I should have prefixed this patch with a discussion on the main list, perhaps. My main us

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:148 + + FIXME: add release notes. + Eugene.Zelenko wrote: > Please add short description. Should be same as first statements in > docu

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196151. tmroeder added a comment. Fix a line-length issue in the check code and rewrite the doc text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files: clang-to

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196150. tmroeder added a comment. Actually add the documentation in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963 Files: clang-tools-extra/clang

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 196148. tmroeder marked an inline comment as done. tmroeder added a comment. Updated with an initial check. Verified that add_new_check.py works (that's how I added the check). Also added some basic docs and a test. Repository: rG LLVM Github Monorepo

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder updated this revision to Diff 192860. tmroeder added a comment. Changed the module name to linuxkernel as suggested and updated the files to match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59963/new/ https://reviews.llvm.org/D59963

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

tmroeder marked 2 inline comments as done. tmroeder added a comment. In D59963#1447985 , @alexfh wrote: > Looks reasonable in general, but we usually add modules with at least one > check. Let's do the same here. OK, will do. Comment

[PATCH] D59963: Add a clang-tidy module for the Linux kernel.

tmroeder added reviewers: aaron.ballman, gribozavr. tmroeder added a comment. Not sure if you are the right reviewers; I just looked back in the commit history to see who reviewed clang-tidy changes recently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D59963: Add a clang-tidy module for the Linux kernel.

tmroeder created this revision. Herald added subscribers: cfe-commits, jdoerfert, mgorny. Herald added a project: clang. Now that clang is going to be able to build the Linux kernel again on x86, and we have gen_compile_commands.py upstream for generating compile_commands.json, clang-tidy can be u

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354916: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder, committed by ). Herald added

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder added a comment. I'm going to submit this patch again, since that I believe I understand the problem, and I have tested this version on Win10 with the latest MSVC (other than the expectation that I just added, but that test wasn't a problem on the Windows builders, and the new expectat

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188397. tmroeder added a comment. Added the other expectation, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58663/new/ https://reviews.llvm.org/D58663 Files: clang/docs/LibASTMatchersReferenc

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188307. tmroeder added a comment. Dropped the C++ part of the ImportChooseExpr test entirely. This is the part that was breaking the tests on Windows, and after further experimentation, it turns out that clang on Windows never expands the template under th

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder created this revision. tmroeder added reviewers: shafik, a_sidorin, martong, aaron.ballman, rnk. tmroeder added a project: clang. Herald added a reviewer: a.sidorin. This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr construction). This is needed, fo

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354832: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188262. tmroeder added a comment. Updating after switching to the git monorepo model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files: clang/docs/LibASTMatcher

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188224. tmroeder added a comment. Changed to use llvm::find. Given the disagreement about the destructuring assignment, I didn't make that change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.ll

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187990. tmroeder added a comment. Fixed a minor style typo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/AST

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187989. tmroeder added a comment. Added more unit tests. Sorry for the delay; I had to dig into the details to figure out where to put these tests and how to structure them. Please let me know if there are better ways to do this. I don't know any way to w

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) tmroeder wrote: > aaron.ballman wrote: > > tmroeder wrote

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder marked an inline comment as done. tmroeder added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) a_sidorin wrote: > aaron.ballman wrote: > > tmroeder wrot

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187827. tmroeder marked an inline comment as done. tmroeder added a comment. Reverted to the original semantics of CondIsTrue Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files:

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) aaron.ballman wrote: > a_sidorin wrote: > > aaron.ballman wrote: > > > `bool CondIsTrue = E->isCondi

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187823. tmroeder added a comment. Fix a mistake in the comment. CondIsTrue only matters if the value *is* condition dependent, not *is not* condition dependent. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ http

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187821. tmroeder marked an inline comment as done. tmroeder added a comment. Changed the CondIsTrue RHS as suggested. Left the `auto` based on the conclusion of the discussion. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187393. tmroeder marked 6 inline comments as done. tmroeder added a comment. Thanks for the review and the suggestions for improving the tests. This update cleans up the tests as suggested. Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added inline comments. Comment at: test/ASTMerge/choose-expr/Inputs/choose1.c:1 +#define abs_int(x) __builtin_choose_expr( \ +__builtin_types_compatible_p(__typeof(x), unsigned int), \ a_sidorin wrote: > This test duplicates unit

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187113. tmroeder added a comment. Updated Registry.cpp, regenerated the documentation, and added direct tests for the matcher. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files:

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added a comment. In D58292#1399774 , @shafik wrote: > This looks reasonable, I will wait for @martong and/or @a_sidorin to review. > > FYI LLDB is the other big user of ASTImpoter so it is helpful if you can run > `check-lldb` especially on MacOS

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder created this revision. Herald added a reviewer: shafik. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr construction). This is needed, for example, for cross-CTU anal

[PATCH] D54657: [clang] Do not dump compilation-database entries for -E.

tmroeder abandoned this revision. tmroeder added a comment. I found a better way to do this in the Linux kernel build. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54657/new/ https://reviews.llvm.org/D54657 ___ cfe-

[PATCH] D54657: [clang] Add -MJJ for appending to compilation databases.

tmroeder added a comment. In https://reviews.llvm.org/D54657#1303320, @joerg wrote: > I'm sorry, but it still sounds to me like you want to address badly written > build rules by making the driver more complicated. I don't see that is a > reasonable goal forward. My goal is to build a compila

[PATCH] D54657: [clang] Add -MJJ for appending to compilation databases.

tmroeder updated this revision to Diff 174676. tmroeder added a comment. Change CompilationDatabase to not output entries that use -E. These entries cannot be used by the tooling, so they can be skipped. This removes the other code and adds tests to make sure that neither -E or -### entries wri

[PATCH] D54657: [clang] Add -MJJ for appending to compilation databases.

tmroeder added a comment. In https://reviews.llvm.org/D54657#1302086, @joerg wrote: > I don't understand the point here. Why would you want to include > pre-processing-only commands in the compilation database? Sorry for not being clear enough. I don't want to include entries with -E. However

[PATCH] D54657: [clang] Add -MJJ for appending to compilation databases.

tmroeder created this revision. tmroeder added a reviewer: klimek. Herald added a subscriber: cfe-commits. Some build systems compile files more than once (e.g., Kbuild in the Linux kernel compiles with -c once and with -E once). In these cases, the -MJ flag will only record the latest compilation