tmroeder marked an inline comment as done.
tmroeder added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include <c++/8/bits/c++config.h>
+
----------------
nickdesaulniers wrote:
> tmroeder wrote:
> > lebedev.ri wrote:
> > > This looks wrong
> > Yeah, I'm not sure where that came from. I'll remove it.
> Hard to tell, but I don't think this `using` statement was ever removed as 
> requested?
It's not the "using" statement that was requested to be removed in the initial 
diff, but rather "#include <c++/8/bits/c++config.h>", which I did remove.

I'm not sure why the "This looks wrong" gets attached to the "using" statement 
in later diffs.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59963/new/

https://reviews.llvm.org/D59963



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to