https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/156270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
I'm pressing merge because @mrkajetanp is away
https://github.com/llvm/llvm-project/pull/156029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/156029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah approved this pull request.
Flang and flang-rt changes LGTM.
https://github.com/llvm/llvm-project/pull/156270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
Weighing in with my personal opinion here:
- If this can be shown to miss compile any known application then that's
grounds for imediately disabling the pass until it can be fixed.
- If this only breaks some very obscure fortran formulation that it is unlikely
for a human to write
https://github.com/tblah approved this pull request.
Looks great to me.
Just to elaborate on the need to keep the MLIR pass: the logic for which
clauses apply to which directive in a compound construct is non-trivial. We
thought it is better not to try to re-implement that here.
https://githu
@@ -67,6 +81,28 @@ class SimdOnlyConversionPattern : public
mlir::RewritePattern {
LLVM_DEBUG(llvm::dbgs() << "SimdOnlyPass matched OpenMP op:\n");
LLVM_DEBUG(op->dump());
+auto eraseUnlessUsedBySimd = [&](mlir::Operation *ompOp,
+
@@ -0,0 +1,401 @@
+//===-- SimdOnly.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,401 @@
+//===-- SimdOnly.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/150269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah commented:
The overall approach LGTM so long as @kiranchandramohan is happy.
Have you looked at the new canonical loop operation `omp.new_cli` (I think it
was merged since you started this patch)? It isn't obvious if we should allow
tile+unroll (and the OpenMP 6.0 addi
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -31,6 +32,113 @@ namespace fir {
using namespace fir;
using namespace mlir;
+// Extracted here for use in other passes
+
+/// Convert fir::DoLoopOp to control-flow operations
+std::pair
+fir::convertDoLoopToCFG(DoLoopOp loop, mlir::PatternRewriter &rewriter,
---
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/150269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
tblah wrote:
Missing copyright header
https://github.com/llvm/llvm-project/pull/150269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
@@ -208,11 +208,12 @@ void ClauseProcessor::processTODO(mlir::Location
currentLocation,
if (!x)
return;
unsigned version = semaCtx.langOptions().OpenMPVersion;
-TODO(currentLocation,
- "Unhandled clause " + llvm::omp::getOpenMPClauseName(id).upper() +
@@ -0,0 +1,360 @@
+#include "flang/Optimizer/Builder/FIRBuilder.h"
+#include "flang/Optimizer/Transforms/Utils.h"
+#include "mlir/Dialect/ControlFlow/IR/ControlFlowOps.h"
+#include "mlir/Dialect/Func/IR/FuncOps.h"
+#include "mlir/Dialect/OpenMP/OpenMPDialect.h"
+#include "mlir/IR/
https://github.com/tblah commented:
This is great so far
https://github.com/llvm/llvm-project/pull/150269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah approved this pull request.
LGTM with MacDue's comments. Thank you for contributing this!
https://github.com/llvm/llvm-project/pull/146453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/144915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/144915
>From 7bb96a8479a0b351b0d6de33cbab98e498a3ab7c Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 19 Jun 2025 14:57:04 +
Subject: [PATCH 1/3] [flang][OpenMP] Remove experimental warning
RFC:
https://discou
tblah wrote:
[ebd2980](https://github.com/llvm/llvm-project/pull/144915/commits/ebd2980051b3994d1c419d06f3cba22927283aec)
moves the warning to the frontend driver so it can use the checks added in
#145725
https://github.com/llvm/llvm-project/pull/144915
tblah wrote:
I've taken this out of draft.
The only remaining item in #110008 is some improved semantic checks for Loop
transformation constructs. The parsing of these constructs works already and a
TODO is emitted, but semantic checks should be updated to allow loop
transformation constructs
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/144915
>From e41a93accace06b39e8421fddbfd7673a3b429dc Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 19 Jun 2025 14:57:04 +
Subject: [PATCH 1/2] DRAFT: [flang][OpenMP] Remove experimental warning
RFC:
https:/
https://github.com/tblah created
https://github.com/llvm/llvm-project/pull/144915
RFC:
https://discourse.llvm.org/t/rfc-removing-the-openmp-experimental-warning-for-llvm-21/86455
Fixes: #110008
There are a handful of open issues still to resolve before this can go out of
draft. See the linke
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/143508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
Nice catch. I added the -fc1 option because there is a -cc1 option. But it
doesn't seem to actually be used at all by the frontend driver so I just
removed the -fc1 option. I left the clang option just in case.
https://github.com/llvm/llvm-project/pull/143508
_
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/143508
>From 6b567aff65bbd35bbfaa9e15ea36dc67110f8138 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Fri, 6 Jun 2025 13:48:22 +
Subject: [PATCH 1/2] [flang][Driver] Enable support for -mmacos-version-min=
So far as
https://github.com/tblah approved this pull request.
Flang changes LGTM.
nit: I am no clang expert but I wonder if you could use MarshallingInfoFlag in
Options.td to avoid having to set CGOpts.FuseLoops manually for clang (this is
not supported for flang unfortunately). If people more familiar
tblah wrote:
The failing tests are from compiler-rt. I don't think they are related to this
patch.
https://github.com/llvm/llvm-project/pull/143508
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/tblah created
https://github.com/llvm/llvm-project/pull/143508
So far as I can tell this option is driver-only so we can just re-use what
already exists for clang. I've added a unit test based on clang's unit test to
demonstrate that the option is handled.
Still TODO is to
https://github.com/tblah approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/140182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
> Who said it is a temporary solution? Can you point to an RFC?
This specific patch wasn't discussed in the RFC but there is some discussion
here
https://discourse.llvm.org/t/rfc-add-fir-affine-optimization-fir-pass-pipeline/86190/5
https://github.com/llvm/llvm-project/pull/13985
https://github.com/tblah requested changes to this pull request.
The code changes look okay here but I think the naming should reflect that the
lowering to upstream MLIR dialects will be considered experimental (and may
remain so forever, if it cannot be made to fully conform to Fortran semanti
https://github.com/tblah approved this pull request.
LGTM, thanks
https://github.com/llvm/llvm-project/pull/137996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -81,6 +81,8 @@ class CodeGenOptions : public CodeGenOptionsBase {
/// Options to add to the linker for the object file
std::vector DependentLibs;
+ bool InstrumentFunctions{false};
tblah wrote:
This could be stored more efficiently by putting it in Co
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/137194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/137193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/137193
>From fac4240f2c217a9e48ab2eb8eeffb818f5c3a9ff Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 10 Apr 2025 11:43:18 +
Subject: [PATCH 1/3] [mlir][OpenMP] Convert omp.cancel sections to LLVMIR
This is qui
tblah wrote:
The test failures look unrelated to my patch.
https://github.com/llvm/llvm-project/pull/137193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -20,8 +20,13 @@
#include "mlir/IR/OwningOpRef.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/IR/Module.h"
+#include "llvm/Support/CommandLine.h"
+#include "llvm/Support/PGOOptions.h"
#include
+namespace llvm {
+extern cl::opt ClPGOColdFuncAttr;
+} // namespace llvm
--
https://github.com/tblah commented:
Thanks for the updates
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -19,6 +21,7 @@ template class Expected;
template class IntrusiveRefCntPtr;
class Module;
class MemoryBufferRef;
+extern cl::opt ClPGOColdFuncAttr;
tblah wrote:
nit: I would put this `extern` in `BackendUtil.cpp` because it is not part of
BackendUtils's p
@@ -8,6 +8,8 @@
#ifndef LLVM_CLANG_CODEGEN_BACKENDUTIL_H
#define LLVM_CLANG_CODEGEN_BACKENDUTIL_H
+#include "llvm/Support/CommandLine.h"
+#include "llvm/Support/PGOOptions.h"
#include "clang/Basic/LLVM.h"
#include "llvm/IR/ModuleSummaryIndex.h"
tblah wrote
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
It turned out that the Windows failures were due to some UB in my patch. Clang
(with the OMPIRBuilder backend) was actually doing almost exactly the same hack
as I implement in this patch, which then interacted badly by my attempts to do
the same thing in OMPIRBuilder.
I have rem
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/137193
>From fac4240f2c217a9e48ab2eb8eeffb818f5c3a9ff Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Thu, 10 Apr 2025 11:43:18 +
Subject: [PATCH 1/2] [mlir][OpenMP] Convert omp.cancel sections to LLVMIR
This is qui
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/137193
>From ba6d59cdb2bf906a60b7e13448af730bd2019140 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Tue, 8 Apr 2025 17:21:15 +
Subject: [PATCH 1/4] [mlir][OpenMP] Convert omp.cancel parallel to LLVMIR
Support for
@@ -24,6 +24,11 @@ CODEGENOPT(OptimizationLevel, 2, 0) ///< The -O[0-3] option
specified.
CODEGENOPT(DebugPassManager, 1, 0) ///< Prints debug information for the new
///< pass manager.
+ENUM_CODEGENOPT(ProfileInstr, ProfileInstrKind, 2, Pro
@@ -148,6 +148,55 @@ class CodeGenOptions : public CodeGenOptionsBase {
/// OpenMP is enabled.
using DoConcurrentMappingKind = flangomp::DoConcurrentMappingKind;
+ enum ProfileInstrKind {
+ProfileNone, // Profile instrumentation is turned off.
+ProfileClangI
@@ -24,6 +24,11 @@ CODEGENOPT(OptimizationLevel, 2, 0) ///< The -O[0-3] option
specified.
CODEGENOPT(DebugPassManager, 1, 0) ///< Prints debug information for the new
///< pass manager.
+ENUM_CODEGENOPT(ProfileInstr, ProfileInstrKind, 2, Pro
@@ -148,6 +148,55 @@ class CodeGenOptions : public CodeGenOptionsBase {
/// OpenMP is enabled.
using DoConcurrentMappingKind = flangomp::DoConcurrentMappingKind;
+ enum ProfileInstrKind {
+ProfileNone, // Profile instrumentation is turned off.
+ProfileClangI
@@ -909,6 +940,29 @@ void
CodeGenAction::runOptimizationPipeline(llvm::raw_pwrite_stream &os) {
llvm::PassInstrumentationCallbacks pic;
llvm::PipelineTuningOptions pto;
std::optional pgoOpt;
+
+ if (opts.hasProfileIRInstr()){
+// // -fprofile-generate.
@@ -148,6 +148,55 @@ class CodeGenOptions : public CodeGenOptionsBase {
/// OpenMP is enabled.
using DoConcurrentMappingKind = flangomp::DoConcurrentMappingKind;
+ enum ProfileInstrKind {
+ProfileNone, // Profile instrumentation is turned off.
+ProfileClangI
@@ -882,6 +882,14 @@ void Flang::ConstructJob(Compilation &C, const JobAction
&JA,
// TODO: Handle interactions between -w, -pedantic, -Wall, -WOption
Args.AddLastArg(CmdArgs, options::OPT_w);
+
+ if (Args.hasArg(options::OPT_fprofile_generate)){
+CmdArgs.push_back(
https://github.com/tblah commented:
Thanks for contributing this
https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/136098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/133745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6961,6 +6960,52 @@ defm unsigned : OptInFC1FFlag<"unsigned", "Enables
UNSIGNED type">;
def fno_automatic : Flag<["-"], "fno-automatic">, Group,
HelpText<"Implies the SAVE attribute for non-automatic local objects in
subprograms unless RECURSIVE">;
+defm repack_arrays
+
https://github.com/tblah approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/134002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1687,6 +1700,7 @@ void CompilerInvocation::setLoweringOptions() {
const Fortran::common::LangOptions &langOptions = getLangOpts();
loweringOpts.setIntegerWrapAround(langOptions.getSignedOverflowBehavior() ==
Fortran::common::LangOptio
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/134002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah created
https://github.com/llvm/llvm-project/pull/133745
Precise OpenMP standards support information is being documented in #132707
Flang now has good support for OpenMP Version 3.1 and earlier.
>From 3bce8b379641d8e91c8e8ae389a113f8d882b14e Mon Sep 17 00:00:00 2001
F
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/132801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,10 +1,15 @@
! RUN: %flang -### -S -fslp-vectorize %s 2>&1 | FileCheck
-check-prefix=CHECK-SLP-VECTORIZE %s
! RUN: %flang -### -S -fno-slp-vectorize %s 2>&1 | FileCheck
-check-prefix=CHECK-NO-SLP-VECTORIZE %s
+! RUN: %flang -### -S -O0 %s 2>&1 | FileCheck
-check-prefix=C
@@ -0,0 +1,10 @@
+! RUN: %flang -### -S -fslp-vectorize %s 2>&1 | FileCheck
-check-prefix=CHECK-SLP-VECTORIZE %s
+! RUN: %flang -### -S -fno-slp-vectorize %s 2>&1 | FileCheck
-check-prefix=CHECK-NO-SLP-VECTORIZE %s
+! RUN: %flang -### -S -O1 %s 2>&1 | FileCheck
-check-prefix=CH
@@ -0,0 +1,826 @@
+//===- BuildBuiltins.cpp - Utility builder for builtins
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/tblah commented:
The idea behind this sounds good to me, and this patch improves flang's test
results on the fujitsu testsutie, shows no regressions in the gfortran test
suite, and fixes the important remaining flang issues from omp atomic. Atomic
support is one of the most
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/101966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/130788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/130788
>From 5d3c1cc1d40b308b93cc47c78c6c3ca677f55155 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Tue, 11 Mar 2025 15:54:35 +
Subject: [PATCH 1/4] [flang] Add support for -f[no-]verbose-asm
This flag provides ex
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/130788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
No problem. I have moved it to target options in
https://github.com/llvm/llvm-project/pull/130788/commits/6f6f8670887c9eb030412a7eb720242bba2790db
https://github.com/llvm/llvm-project/pull/130788
___
cfe-commits mailing list
cfe-commits@l
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/130788
>From 5d3c1cc1d40b308b93cc47c78c6c3ca677f55155 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Tue, 11 Mar 2025 15:54:35 +
Subject: [PATCH 1/3] [flang] Add support for -f[no-]verbose-asm
This flag provides ex
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/129872
>From 3055b89b8ab937bfd4ba70d87e1733b05156d0ac Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Tue, 4 Mar 2025 17:19:53 +
Subject: [PATCH 1/3] [mlir][OpenMP] fix crash outlining infinite loop
Previously an ex
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/130788
>From 5d3c1cc1d40b308b93cc47c78c6c3ca677f55155 Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Tue, 11 Mar 2025 15:54:35 +
Subject: [PATCH 1/2] [flang] Add support for -f[no-]verbose-asm
This flag provides ex
https://github.com/tblah created
https://github.com/llvm/llvm-project/pull/130788
This flag provides extra commentary in the assembly output. It is in
CodeGenOptions to match what is done in clang, even though the backend treats
it as a target option.
>From 5d3c1cc1d40b308b93cc47c78c6c3ca677f
https://github.com/tblah closed https://github.com/llvm/llvm-project/pull/129872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
> The comment mentions the additional edges might come through cancellations,
> but what test actually tests cancellation points?
Thanks for taking a look. Now I have added clang lit tests (including for
cancel) we can see that there are no changes beyond block names and removing
https://github.com/tblah updated
https://github.com/llvm/llvm-project/pull/129872
>From 3055b89b8ab937bfd4ba70d87e1733b05156d0ac Mon Sep 17 00:00:00 2001
From: Tom Eccles
Date: Tue, 4 Mar 2025 17:19:53 +
Subject: [PATCH 1/2] [mlir][OpenMP] fix crash outlining infinite loop
Previously an ex
https://github.com/tblah approved this pull request.
LGTM thanks
https://github.com/llvm/llvm-project/pull/126026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah commented:
Thank you for up-streaming this
https://github.com/llvm/llvm-project/pull/126026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/119718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,155 @@
+
+
+# `DO CONCURRENT` mapping to OpenMP
+
+```{contents}
+---
+local:
+---
+```
+
+This document seeks to describe the effort to parallelize `do concurrent` loops
+by mapping them to OpenMP worksharing constructs. The goals of this document
+are:
+* Describing h
https://github.com/tblah edited https://github.com/llvm/llvm-project/pull/126026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,155 @@
+
+
+# `DO CONCURRENT` mapping to OpenMP
+
+```{contents}
+---
+local:
+---
+```
+
+This document seeks to describe the effort to parallelize `do concurrent` loops
+by mapping them to OpenMP worksharing constructs. The goals of this document
+are:
+* Describing h
https://github.com/tblah approved this pull request.
Thanks for coming back to this @brad0
https://github.com/llvm/llvm-project/pull/125998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/tblah approved this pull request.
LGTM. As I understand it the test failures were fixed by
https://github.com/llvm/llvm-project/pull/123364
https://github.com/llvm/llvm-project/pull/123606
___
cfe-commits mailing list
cfe-commits@li
@@ -933,10 +933,12 @@ def O : Joined<["-"], "O">, Group,
def O_flag : Flag<["-"], "O">, Visibility<[ClangOption, CC1Option, FC1Option]>,
Alias, AliasArgs<["1"]>;
def Ofast : Joined<["-"], "Ofast">, Group,
- Visibility<[ClangOption, CC1Option, FlangOption]>,
- HelpTextForVar
https://github.com/tblah approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/119536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tblah wrote:
> Hello! Did anyone notice a performance regression after this PR on exchange2?
> I see it on both EPYC 9684X and grace. The slowdown is more than 1.5x.
>
> I verified that performance restores when adding `-fwrapv` with the latest
> flang compiler. The compilation options are `-O
1 - 100 of 336 matches
Mail list logo
