[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:4 TargetParser + FrontendOpenMP ) koops wrote: > ABataev wrote: > > What requires this new dependency? > When cmake uses -DBUILD_SHARED_LIBS=1 shared libraries are built instead of >

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops requested review of this revision. koops added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:4 TargetParser + FrontendOpenMP ) ABataev wrote: > What requires this new dependency? When cmake uses -DBUILD_SHARED_LIBS=1 shared libraries ar

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558146. koops added a comment. Adding libFrontendOpenMP.so as a dependent library when building libclangBasic.so. Shared libraries were not built and tested by default, hence build and failed when checking on ppc64le. CHANGES SINCE LAST ACTION https://revi

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558120. koops added a comment. Moving the declaration and definition of checkFailClauseParameter to include/clang/Basic/OpenMPKinds.h & lib/Basic/OpenMPKinds.cpp respectively. 2 other minor changes suggested by Alexey. CHANGES SINCE LAST ACTION https://revi

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558112. koops added a comment. 1. Added a check for the fail parameter before the instance of OMPFailClause is created in ActOnOpenMPFailClause. An error in fail parameter like `#pragma omp atomic compare fail(capture)` was creating a wrong instance of OMPFail

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558076. koops added a comment. Removing default from switch statements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTV

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added a comment. In clang/lib/AST/OpenMPClause.cpp, OMPClauseWithPreInit::get(const OMPClause *C) { switch(C->getClauseKind()) { case OMPC_schedule: default: break; } It is not possible to list down all possible ``OpenMPClauseKind``` types in the switch. Hence they

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558056. koops added a comment. After the rollback putting the default in the switch case as discussed in the comments earlier. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AS

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:450 +case OMPC_unknown: +default: + return "unknown"; uabelho wrote: > Adding "default:" here silences the warning. > But looks like @ABataev commented on something similar earl

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558051. koops added a comment. To avoid build error in ppc64 adding a "default" to switch statement. This is similar to the way it is currently handled in OMPClauseWithPreInit::get() { switch(C->getClauseKind()) { case ... default: } CHANG

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added a comment. Only on ppc64 this error is being seen because it is expecting a default in the switch statement: OpenMPClauseKind CK = ... switch(CK) This is similar to what has been added in OMPClauseWithPreInit::get() { switch(C->getClauseKind()) { case ... default: } I am about t

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558041. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/DiagnosticSemaKinds.td clan

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558040. koops added a comment. Removing extra brackets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558039. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/DiagnosticSemaKinds.td clan

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 558007. koops added a comment. 1. Removing the Create methods from OMPFailClause class. 2. checkFailClauseParameters removed and the checking is now done in ActOnOpenMPAtomicDirective() itself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 557992. koops added a comment. Moving OMC_fail to use ParseOpenMPSimpleClause instead of ParseOpenMPClause. Other changes suggested by previous review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files:

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2611-2617 + void initFailClause(SourceLocation LParenLoc, OpenMPClauseKind FailParameter, + SourceLocation FailParameterLoc) { + +setLParenLoc(LParenLoc); +setFailParamet

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 557933. koops added a comment. Replacing the storing of "OMPClause *FailMemoryOrderClause" with "OpenMPClauseKind FailParameter" in class OMPFailClause. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. In D158266#4655433 , @ddpagan wrote: > Did anything change after the patch was reverted? I have not changed anything in the code yet. I am still investigating. The test where it is failing has nothing to do with my changes. I do n

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 557920. koops added a comment. Removing the printing of parameter of FailClause. This needed a special if statement in Visit(const OMPClause *C) , which is a generalized Visit for Clauses. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ ht

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. Can someone please backout the changes done with this commit? It is resulting in build failures on debian. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 _

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557877. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/loop_bin

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557876. koops added a comment. Removing multiple calls to Sema::checkNestingOfRegions() in Sema::ActOnOpenMPExecutableDirective() . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/cla

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 557820. koops added a comment. Correcting a git-clang-format error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/OpenMPClause.

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 557808. koops added a comment. 1. In class OMPFailClause, the was a duplication in the storage of parameter to the fail clause because the parameter was stored as FailParameterKind and MemoryOrderClause (FailMemoryOrderClause). There was a possibility of these

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 557749. koops added a comment. Removed the tail-allocation. Other changes suggested in the previous review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6181-6190 + checkNestingOfRegions(*this, DSAStack, Kind, DirName, CancelRegion, +BindKind, StartLoc); Kind = OMPD_for; DSAStack->setCurrentDirective(OMPD_for);

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557639. koops added a comment. Avoiding executing "checkNestingOfRegions( )" multiple times. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOpen

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557506. koops added a comment. Moving checks of Work Sharing Directive in mapLoopConstruct to checkNestingOfRegions(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Sema/Sema.

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557397. koops added a comment. Adding extra test cases to loop_bind_messages.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOpenMP.cpp cl

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. Can someone please review the changes that I uploaded last week? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D158266: Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 554920. koops added a comment. Using isOpenMPWorksharingDirective( ) for the "omp loop bind(parallel)" and "omp loop bind(teams)". Added extra tests in loop_bind_messages.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.

[PATCH] D158266: Patch for Support to loop bind clause : Checking Parent Region

koops created this revision. koops added reviewers: ddpagan, ABataev, jdoerfert, dreachem, tianshilei1992, soumitra, RitanyaB, thakis. Herald added a project: All. koops requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. http

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548886. koops added a comment. Corrected git-clang-format errors. clang/include/clang/AST/OpenMPClause.h clang/lib/AST/OpenMPClause.cpp clang/lib/Parse/ParseOpenMP.cpp clang/lib/Sema/SemaOpenMP.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. Can someone please check for MacOS? Yesterday when this support was committed, the CHECK statements in tests loop_bind_codegen.cpp and loop_bind_enclosed.cpp had failed on Mac and I received a comment as follows: When relanding, please remember to put a link to the rev

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548534. koops added a comment. Pulling in latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/OpenMPClause.h clang/

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 548499. koops added a reviewer: thakis. koops added a comment. Making the CHECK pattern generic to match platforms tested after committing changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: c

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548494. koops added a reviewer: thakis. koops added a comment. Making the CHECK pattern generic to match platforms tested after committing changes (especially MacOS). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 548103. Herald added a subscriber: jplehr. Herald added a reviewer: kiranchandramohan. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 547905. koops added a comment. In clang/test/OpenMP/loop_bind_enclosed.cpp Generalizing the CHECK pattern for aarch64-linux, s390x-linux and ppc64le-linux. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 F

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 547304. koops added a comment. 1. Support for PCH Serilization/deserilization for the PrevMapLoopConstruct variable in OMPExecutableDirective. 2. Modification of clang/test/PCH/pragma-loop.cpp to include "#pragma omp loop bind" with different parameters for bi

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:291 + /// the frontend. + OpenMPDirectiveKind PrevMappedDirective = llvm::omp::OMPD_unknown; + ABataev wrote: > I don't see where this field is stored/loaded for PCH support. You need

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 546159. koops added a comment. 1. clang/test/OpenMP/loop_bind_enclosed.cpp : Converting main and function names within it to use regular expressions to accomodate windows platform. 2. i) Instead of calling setMappedDirective() after the the creation of the Di

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 545728. koops added a comment. 1. clang-format error in clang/include/clang/AST/StmtOpenMP.h corrected. 2. Correcting clang/test/OpenMP/loop_bind_enclosed.cpp to use regular expressions for names of functions to take care of windows platform. CHANGES SINCE LA

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 544892. koops added a comment. 1. Converting prevMapped to PrevMappedDirective 2. Reducing the CHECK patterns in loop_bind_enclosed.cpp to the most essential ones to succeed matching for the IR generation on windows. CHANGES SINCE LAST ACTION https://review

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 544688. koops added a comment. Correction for clang-format errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 544542. koops added a comment. Fixing Alexey's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 544428. koops added a comment. Moving the variable MappedDirective into structure SharingMapTy. Enough comments have been put in place to explain. Modified some of the loop_bind tests to cater to windows and debian platform. CHANGES SINCE LAST ACTION https:

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 541155. koops added a comment. 1. Removing the size for the template constructor, llvm::SmallVectorImpl &ClausesWithoutBind. 2. In the diagnostic message of err_omp_bind_required_on_loop, using single quotes for the name 'loop' construct. 3. Minor changes to t

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 540373. koops added a comment. Addressing Alexey's comments. The name matching in loop_bind_messages.cpp & generic_loop_codegen.cpp tests changed to take care of the failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 539017. koops added a comment. 1. Taking care of Alexy & David suggestions: a) Using update_cc_test_checks.py to generate CHECK statements. b) Change in error message from "handled" to "allowed". c) Adding comments for the bind clause. d) Mangled names of the

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11094 + bool checkLastPrivateForMappedDirectives(ArrayRef Clauses); + bool mapLoopConstruct(llvm::SmallVector *ClausesWithoutBind, ABataev wrote: > const member function? > Add a comment

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/test/OpenMP/generic_loop_ast_print.cpp:26 //PRINT: T j, z; -//PRINT: #pragma omp loop collapse(C) reduction(+: z) lastprivate(j) bind(thread) +//PRINT: #pragma omp simd collapse(C) reduction(+: z) lastprivate(j) //PRINT: f

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 529532. koops added a comment. 1. Taken care of Alexy's comments. 2. Reverting back changes to StmtPrinter.cpp because state of AST needs to be shown as is to the developer of clang when -ast-print/-ast-dump is used. This also meant some changes to the test ca

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. Can someone please let me know the following changes that I did in my latest patch? 1. clang/test/OpenMP/generic_loop_ast_print.cpp is failing because of the mapped directives. It is because of –ast-print & -ast-dump. This is because when the Sema comes across "omp loop

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 527127. koops added a comment. 1. Addition of extra test case loop_bind_enclosed.cpp. 2. Changing of name from Map1D to MappedDirective 3. Printing "omp loop bind" instead of the mapped Directives (e.g. "omp simd") when -ast-print option is used. CHANGES SINC

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. >> However, generic_loop_messages.cpp & generic_loop_ast_print.cpp are present >> and provide a good coverage. > > I rather doubt that these tests provide good coverage, since you're changing > the directive kind here on the fly. This is a very new functionality, which >

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 518341. koops added a comment. 1. Taken care of some of the comments by Alexey. 2. Added extra tests of loop_bind_messages.cpp However, generic_loop_messages.cpp & generic_loop_ast_print.cpp are present and provide a good coverage. CHANGES SINCE LAST ACTION

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 514096. koops added a comment. 1. Adding semantic test clang/test/OpenMP/loop_bind_messages.cpp. 2. Changes suggested by Alexey. 3. >Why need to drop bind clause here? The new Directives to which loop directive is being mapped to, do not contain the bind clause

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/test/OpenMP/loop_bind_codegen.cpp:51-56 +void thread_loop2() { + #pragma omp loop bind(thread) + for (int j = 0 ; j < NNN ; j++) { +aaa[j] = j*NNN; + } +} ABataev wrote: > I think it should trigger the assert

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 512448. koops added a comment. Removing changes from : 1. clang/include/clang/AST/StmtOpenMP.h 2. clang/lib/AST/StmtOpenMP.cpp 3. clang/include/clang/Parse/Parser.h These were useful when the code was in CodeGen to handle the bind clause. CHANGES SINCE LAST

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 512381. koops added a comment. Moving the code to SemaOpenMP.cpp from CodeGen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Basic/Diagno

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 505869. koops added a comment. Herald added subscribers: jplehr, sunshaoce. 1. formatting 2. Adding lit test 3. Removing bind clause from the set of clauses passed during bind(parallel) to the OMPForDirective and bind(teams) to the OMPDistributeDirective. CHA

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7791 +OpenMPBindClauseKind bindParam = C->getBindKind(); +switch (bindParam) { +case OMPC_BIND_parallel: { carlo.bertolli wrote: > What if you have something like this: > > v

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added a comment. bind(thread) is not working at present. I have uploaded this patch to obtain feedback mainly on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144634/new/ https://reviews.llvm.org/D144634 __

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops created this revision. koops added reviewers: soumitra, RitanyaB, dreachem, ABataev, jdoerfert, sandoval, tianshilei1992. Herald added subscribers: guansong, yaxunl. Herald added a project: All. koops requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 484290. koops added a comment. Taking care of : 1. "The nowait clause may only appear on a taskwait directive if the depend clause is present.". 2. "Please do not add any new tests using -no-opaque-pointers". 3. Added a new test to expect failure for point 1.

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops added a comment. > (There seems to be another unrelated regression at the same time though, > regarding the symbol __kmpc_fork_call_if.) I do not know about this regression. I have not touched this function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://revie

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 481742. koops added a comment. git pull & reloading the earlier patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h c

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops added a comment. mstorsjo, I have uploaded a new patch which has __kmpc_omp_taskwait_51 in dllexports. Can you please check the patch on windows? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 _

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 481740. koops added a comment. Addition of __kmpc_omp_taskwait_51 in dllexports. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRun

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 435831. koops added a comment. Changes suggested by aaron.ballman to avoid failures on windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/inc

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added a comment. Is it possible to move this back from "Closed" state to "Needs Review"? The merge has been rolled back due to a defect in the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added subscribers: cchen, dreachem, tianshilei1992, jdoerfert, soumitra. koops added a comment. Hello Kevin, I am not sure why it is indicating an uninitialized variable at that point. The code at " llvm-project/clang/lib/Sema/SemaOpenMP.cpp:12060 " is as below: for (const OMPClause *C

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops added a comment. In D123286#3527374 , @koops wrote: > In D123286#3513797 , > @tianshilei1992 wrote: > >> Can we have test for right usage? > > I do not understand "test for right usage". From the specific

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 431391. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/incl

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 431385. koops added a comment. Clang formatting for variables in ParseOpenMP.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 431315. koops added a comment. Fixing a minor error : clang formatting of variable names to avoid build errors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTravers

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops added a comment. In D123286#3513797 , @tianshilei1992 wrote: > Can we have test for right usage? I do not understand "test for right usage". From the specifications the only right usage for "omp nothing" will be in the metadirective. If you have

[PATCH] D123286: [Clang][OpenMP] Support for omp nothing

koops updated this revision to Diff 430933. koops added a comment. changes to support clang format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123286/new/ https://reviews.llvm.org/D123286 Files: clang/lib/Basic/OpenMPKinds.cpp clang/lib/Parse/ParseOpenMP.cpp clang/test/OpenMP/

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228 + void Visit(const OMPFailClause *C) { +getNodeDelegate().AddChild([=] { tianshilei1992 wrote: > koops wrote: > > tianshilei1992 wrote: > > > Why would we want a dedica

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 430883. koops added a comment. Further changes in the code to confirm to the clang format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added a comment. I have tried on x64 RH and x64 SuSe. I could not reproduce the failures seen on x64 debian. https://reviews.llvm.org/D118550 also has similar failures on x64 debian. There is a comment " I think the test failures are spurious (but not 100% sure)" So, are these failures

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228 + void Visit(const OMPFailClause *C) { +getNodeDelegate().AddChild([=] { tianshilei1992 wrote: > Why would we want a dedicated function since it is only called once? Th

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

koops updated this revision to Diff 429285. koops added a comment. Took care of the clang format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/OpenMPClause.h cl

[PATCH] D123235: atomic compare fail : Parser & AST support

koops updated this revision to Diff 423956. koops added a comment. 1. changes in flang/lib/Semantics/check-omp-structure.cpp to avoid build failure 2. prevent "requires" directive test from failing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D1232

[PATCH] D123235: atomic compare fail : Parser & AST support

koops added a comment. Can I please have the detailed log for the build failures? I do not have the necessary setup to test those builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 _

[PATCH] D123286: Patch for : omp nothing

koops created this revision. koops added reviewers: dreachem, soumitra, cchen, jdoerfert. Herald added a project: All. koops requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. Patch to support "#pragma omp nothing"

[PATCH] D123235: atomic compare fail : Parser & AST support

koops created this revision. koops added reviewers: dreachem, soumitra, tianshilei1992, cchen. Herald added a subscriber: arphaman. Herald added a project: All. koops requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1