koops added inline comments.
================
Comment at: clang/include/clang/AST/ASTNodeTraverser.h:228
+ void Visit(const OMPFailClause *C) {
+ getNodeDelegate().AddChild([=] {
----------------
tianshilei1992 wrote:
> koops wrote:
> > tianshilei1992 wrote:
> > > Why would we want a dedicated function since it is only called once?
> > The code for this method cannot be put into any other method because it
> > handles only OMPFailClause. All other Visit methods handle either the
> > generalized OMPClause or other types of Clauses.
> I mean, it's only used by the function above, no?
I agree with you but, I cannot understand any better way of coding it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123235/new/
https://reviews.llvm.org/D123235
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
