sscalpone added a comment.
I'm fine with removing or renaming the existing flang shell script.
My proposal is not to wait for a 100% pass rate. My proposal is to wait until
the messages for unimplemented features are converted to TODOs that reference
the program's source line and that legal p
sscalpone added a comment.
Recommend that you contact NAG for more info on the test suite. Here's the
only reference that I could find:
https://fortran-lang.discourse.group/t/fortran-compiler-testing-framework/1573/10
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
sscalpone added a comment.
My proposal is:
If the compiler compiles it, it ought to run.
If the compiler can't compile it, it ought to clearly say why.
1. All tests of legal Fortran that compile & link must also execute correctly
(which excludes tests that expect to catch a problem at runtime)
sscalpone added a comment.
My belief is that we should wait until f18 hits a reasonable quality bar for
executables before making flang-new the default. My reasoning seems not to
have carried the day.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
sscalpone added a comment.
As I said this morning, I prefer to wait with this patch until the upstreaming
is finished. The reason is not only to do with upstreaming, but also with a
concurrent effort to button up any assertion and runtime errors so the initial
user experience is better. Whil
sscalpone added a comment.
@awarzynski, perhaps I am being too dramatic by wondering if we are
compromising support for one or the other language in order to support a common
definition. In the case of -I, there are language-specific semantics that are
important and interesting, such as the re
sscalpone added a comment.
Flang supports include files and module files. The search path is used to look
for both include files and module files. The help text doesn't include info
about module files.
The help text refers to the -isystem option. Is that implemented for flang,
and if so, ou
sscalpone added inline comments.
Comment at: clang/test/Driver/flang/flang-driver-2-frontend01.f90:1
+! Check wich name of flang frontend is invoked by the driver
+
typo //wich//
Comment at: clang/test/Driver/flang/flang-driver-2-frontend02.f90
sscalpone added a comment.
type in the commit message: //esle// the frontend name is hard-coded to
"flang", use that to
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73951/new/
https://reviews.llvm.org/D73951
___
