Author: skalinichev
Date: Sat Dec 3 06:53:06 2016
New Revision: 288582
URL: http://llvm.org/viewvc/llvm-project?rev=288582&view=rev
Log:
[libclang] Fix python tests
It was broken in r286421
Modified:
cfe/trunk/bindings/python/tests/cindex/test_cursor.py
cfe/trunk/bindings/python/tests/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL268366: [libclang] Expose the ElaboratedType (authored by
skalinichev).
Changed prior to commit:
http://reviews.llvm.org/D11797?vs=51109&id=55953#toc
Repository:
rL LLVM
http://reviews.llvm.org/D117
Author: skalinichev
Date: Tue May 3 01:58:29 2016
New Revision: 268366
URL: http://llvm.org/viewvc/llvm-project?rev=268366&view=rev
Log:
[libclang] Expose the ElaboratedType
Differential Revision: http://reviews.llvm.org/D11797
Modified:
cfe/trunk/bindings/python/clang/cindex.py
cfe/tru
skalinichev accepted this revision.
skalinichev added a comment.
LGTM!
Comment at: bindings/python/tests/cindex/test_cursor.py:197
@@ +196,3 @@
+
+def test_is_deleted_method():
+"""Ensure Cursor.is_deleted_method works."""
You should remove it too.
http://
skalinichev added a comment.
Ok, If there are no objections, I'll commit this revision next week then.
http://reviews.llvm.org/D11797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
skalinichev added inline comments.
Comment at: tools/libclang/CIndex.cpp:4311
@@ -4311,1 +4310,3 @@
+ C.kind == CXCursor_ConversionFunction ||
+ C.kind == CXCursor_FunctionDecl) {
if (pieceIndex > 0)
What about function templates?
E.g.: template d
skalinichev added a comment.
I see. There were some changes recently in the indexing functionality. I'm not
sure whether this change is intended or not, but since it's not your fault and
we already have a lot of tests confirming that clang_CXXMethod_isDeleted is
working as expected (e.g. c-inde
skalinichev added a comment.
It reminded me http://reviews.llvm.org/D17278
So it seems like it should be already fixed, no?
Repository:
rL LLVM
http://reviews.llvm.org/D17180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
skalinichev updated this revision to Diff 51109.
skalinichev added a comment.
Looking a bit more at the recent commits in libclang, it seems like all
recently added functions follow this naming convention:
clang_Cursor_*
clang_Type_*
e.t.c.
So I'm renaming the function to follow that style too.
skalinichev accepted this revision.
skalinichev added a comment.
This revision is now accepted and ready to land.
Yes, I've seen that python tests segfaulted too, never had time to investigate
it though.
LGTM, great work!
Repository:
rL LLVM
http://reviews.llvm.org/D17226
___
skalinichev added a comment.
Generally looks pretty good to me. Maybe it's worth to factor out duplicating
code, but I guess it's not so important.
Also the index-file.cpp test failing for me:
test/Index/index-file.cpp:57:11: error: expected string not found in input
// CHECK: [indexDeclaration]
skalinichev updated the summary for this revision.
skalinichev added reviewers: milianw, kfunk.
skalinichev updated this revision to Diff 50027.
skalinichev added a comment.
Ok, after some more testing I found out that elaborated types can have cv
specifiers attached, but after using ET->getNamed
Author: skalinichev
Date: Thu Jan 7 03:20:40 2016
New Revision: 257043
URL: http://llvm.org/viewvc/llvm-project?rev=257043&view=rev
Log:
[libclang] Handle AutoType in clang_getTypeDeclaration
Differential Revision: http://reviews.llvm.org/D13001
Added:
cfe/trunk/test/Index/print-type-declar
skalinichev added a subscriber: skalinichev.
skalinichev added a comment.
I've seen this bug too. Generally this patch looks good to me.
Could you also add a test for includes half-way through a file case?
Comment at: tools/c-index-test/c-index-test.c:1567
@@ -1564,1 +1566,3 @@
skalinichev updated the summary for this revision.
skalinichev updated this revision to Diff 42654.
skalinichev added a comment.
Added tests
http://reviews.llvm.org/D13001
Files:
test/Index/print-type-declaration.cpp
tools/c-index-test/c-index-test.c
tools/libclang/CXType.cpp
Index: tool
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253166: [libclang] Visit TypeAliasTemplateDecl (authored by
skalinichev).
Changed prior to commit:
http://reviews.llvm.org/D13844?vs=37672&id=40234#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: skalinichev
Date: Sun Nov 15 07:48:32 2015
New Revision: 253166
URL: http://llvm.org/viewvc/llvm-project?rev=253166&view=rev
Log:
[libclang] Visit TypeAliasTemplateDecl
This makes TypeAliasTemplateDecl accessible via LibClang and python bindings
Differential Revision: http://reviews.llvm
Author: skalinichev
Date: Sun Nov 15 07:10:10 2015
New Revision: 253165
URL: http://llvm.org/viewvc/llvm-project?rev=253165&view=rev
Log:
[libclang] Expose AutoType
Expose the AutoType via LibClang and python bindings
Differential Revision: http://reviews.llvm.org/D13000
Modified:
cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL253165: [libclang] Expose AutoType (authored by skalinichev).
Changed prior to commit:
http://reviews.llvm.org/D13000?vs=35193&id=40232#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13000
Files:
Author: skalinichev
Date: Sun Nov 15 06:37:01 2015
New Revision: 253164
URL: http://llvm.org/viewvc/llvm-project?rev=253164&view=rev
Log:
Remove some trailing whitespace
Modified:
cfe/trunk/tools/libclang/CXType.cpp
Modified: cfe/trunk/tools/libclang/CXType.cpp
URL:
http://llvm.org/viewvc/
skalinichev added a comment.
Yes, I have commit acces now (didn't test it yet though). I'll try to submit
this patch soon.
Thanks!
http://reviews.llvm.org/D13844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
skalinichev added a comment.
Well, I think it's ok then. Still there is no test for visibility set from
command line case.
Also adding comment to clang_getCursorVisibility explaining that it also works
with visibility set from command line would be very useful.
Comment at: te
skalinichev created this revision.
skalinichev added a reviewer: klimek.
skalinichev added a subscriber: cfe-commits.
This adds support for TypeAliasTemplateDecl in LibClang
http://reviews.llvm.org/D13844
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_cursor_kind.py
skalinichev added a comment.
Isn't r246931 what you're looking for?
> Index: expose visibility attribute
>
> Expose the previously unexposed visibility attribute via the python and C
> bindings.
Can't you use/improve that API instead?
http://reviews.llvm.org/D13388
__
skalinichev created this revision.
skalinichev added a subscriber: cfe-commits.
Now that auto type is fixed by D11976, it also makes sense to support it in
clang_getTypeDeclaration.
I couldn't find any existing tests for this method, so no tests added...
http://reviews.llvm.org/D13001
Files:
skalinichev created this revision.
skalinichev added a subscriber: cfe-commits.
This exposes the AutoType through LibClang interface
http://reviews.llvm.org/D13000
Files:
bindings/python/clang/cindex.py
include/clang-c/Index.h
test/Index/print-type.cpp
tools/libclang/CXType.cpp
Index: t
skalinichev added a comment.
AFAIUI the canonical type could never be an elaborated type, but just type
could.
And yes before we used nested name specifier from the type name as written in
the source code (a.k.a. ElaboratedType), now we use nested name specifier of
the type that the elaborated
skalinichev updated this revision to Diff 34350.
skalinichev added a comment.
Yes, I've noticed that inconsistency too. But, seems like, this is an unrelated
issue: TemplateSpecializationType type for some reasons uses id instead of qid
(See also all other tests with templates in print-type.cpp,
skalinichev created this revision.
skalinichev added a subscriber: cfe-commits.
Make it report correct availability kind for deleted methods
http://reviews.llvm.org/D12666
Files:
test/Index/availability.cpp
tools/libclang/CIndex.cpp
Index: tools/libclang/CIndex.cpp
===
skalinichev updated this revision to Diff 34019.
skalinichev added a comment.
Rebased.
Yes, now it's ready.
http://reviews.llvm.org/D11797
Files:
test/Index/print-type.c
test/Index/print-type.cpp
tools/libclang/CXType.cpp
Index: tools/libclang/CXType.cpp
skalinichev retitled this revision from "[libclang] Expose the ElaboratedType"
to "[LIbClang] Report the named type for ElaboratedType".
skalinichev updated the summary for this revision.
skalinichev updated this revision to Diff 33787.
skalinichev added a comment.
It just occured to me, why do w
skalinichev added a comment.
Yes, please submit it.
http://reviews.llvm.org/D11976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
skalinichev added a comment.
This is actually an unrelated issue (clang_getTypeDeclaration doesn't handle
the auto type)
Using "c-index-test -test-print-type --std=c++14" on your example I get:
VarDecl=z ... [type=std::basic_string] ...
So, as you can see, "z" has correct type.
Anyway here is
skalinichev added a comment.
Ping? Can someone commit it?
http://reviews.llvm.org/D11797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
skalinichev created this revision.
skalinichev added a reviewer: akyrtzi.
skalinichev added a subscriber: cfe-commits.
It used to work, but was accidentally broken by:
r179769 | akirtzidis | 2013-04-18 20:41:15 +0400 (Thu, 1
skalinichev updated this revision to Diff 31576.
skalinichev marked 6 inline comments as done.
skalinichev added a comment.
Address raised issues.
modocache, great review btw, thanks!
http://reviews.llvm.org/D11797
Files:
bindings/python/clang/cindex.py
include/clang-c/Index.h
test/Index
skalinichev updated this revision to Diff 31503.
skalinichev added a comment.
Fixed minor formatting issues.
http://reviews.llvm.org/D11797
Files:
bindings/python/clang/cindex.py
include/clang-c/Index.h
test/Index/print-type.c
test/Index/print-type.cpp
tools/libclang/CXType.cpp
tool
37 matches
Mail list logo
