[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

thesamesam added a comment. In D159115#4638325 , @v.g.vassilev wrote: > In D159115#4638323 , @mgorny wrote: > >> Changing the type from `unsigned long long` to `uintptr_t` fix the test for >> me. > > Ah! Nice ca

[PATCH] D159173: [Driver] Report warnings for unclaimed TargetSpecific options for assembler input

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159173/new/ https://reviews.llvm.org/D159173 _

[PATCH] D143241: [Clang] Reset FP options before function instantiations

thesamesam added a comment. During our regular snapshot testing, we've hit this in Gentoo on 32-bit Linux x86: https://github.com/llvm/llvm-project/issues/63704#issuecomment-1631791518. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143241/new/ htt

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

thesamesam added a comment. This is just a draft which I've only briefly tested so far. I'm wondering if this is the right place to put the option, as i've not had to write anything in tablegen before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D150930: [Driver] Accept and ignore -fno-lifetime-dse argument

thesamesam created this revision. thesamesam added reviewers: MaskRay, jhuber6, tstellar. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since 47f5c54f997a59bb2c65abe6b8b811f6e7553456

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

thesamesam added a comment. Sure & thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150582/new/ https://reviews.llvm.org/D150582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ddae8b94139: [clangd] Fix test failure when it's built with compiler flags unknown by clang (authored by xry111, committed by thesamesam). Reposit

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. (I even struggled to find docs for the fix we used for clang-tidy, although it obviously works.) Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

thesamesam added a comment. Adding to the concerns raised above, I don't think we're there yet. See https://bugs.gentoo.org/buglist.cgi?quicksearch=enum-constexpr-conversion&list_id=6843355 and keep in mind that a bunch of stuff isn't buildable with Clang 16 yet anyway so I expect a bunch more

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Yes, please. Obviously we want to fix it properly but right now it's a known issue and it's noise when checking for regressions weekly. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

thesamesam added a comment. In D133375#4214214 , @tambre wrote: > I've now run into a snag with this. Having `clang++.cfg` with `-std=c++2b` > makes `/usr/bin/clang++ -E -dM -` fail with `error: invalid argument > '-std=c++2b' not allowed with 'C'`. > T

[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

thesamesam closed this revision. thesamesam added a comment. Thanks! Merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144540/new/ https://reviews.llvm.org/D144540 ___ cfe-commits mailing list cfe-co

[PATCH] D144540: [Clang] [Doc] Explicitly note noreturn bug as a miscompilation

thesamesam created this revision. thesamesam added a reviewer: aaron.ballman. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is for 16.x. Bug: https://github.com/llvm/llvm-project/issues/59792

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. I both like it and can't foresee any issues from the vendor side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://revi

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG136f77805fd8: [Clang] [Python] Fix tests when default config file contains -include (authored by thesamesam). Repository: rG LLVM Github Monorepo

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam updated this revision to Diff 491220. thesamesam added a comment. Switch to setting CLANG_NO_DEFAULT_CONFIG via CMake instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141248/new/ https://reviews.llvm.org/D141248 Files: clang/bin

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam added inline comments. Comment at: clang/bindings/python/tests/cindex/util.py:82 +# our tests. +os.environ["CLANG_NO_DEFAULT_CONFIG"] = "1" xen0n wrote: > This is essentially an import-time side effect, IMO it could be better to > instead put the en

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

thesamesam added a comment. This is currently holding back further testing on our end which is concerning me a bit, especially as we approach the branch point. Could you revert this please if a fix isn't imminent? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam updated this revision to Diff 487296. thesamesam added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141248/new/ https://reviews.llvm.org/D141248 Files: clang/bindings/python/tests/cindex/util.py Index: clang

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam updated this revision to Diff 487295. thesamesam added a comment. Set CLANG_NO_DEFAULT_CONFIG in environment instead to reduce cat-and-mouse issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141248/new/ https://reviews.llvm.org/D1412

[PATCH] D141248: [Clang] [Python] Fix tests when default config file contains -include

thesamesam created this revision. thesamesam added a reviewer: mgorny. Herald added a subscriber: arphaman. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In Gentoo, we make use of Clang's recently-e

[PATCH] D140868: [C] Make (c ? e1 : e2) noreturn only if both e1 and e2 are noreturn

thesamesam added a comment. Confirmed this patch fixes the miscompile. Right. While the spec side needs discussion (and almost certainly addressing!), I don't think anyone in the real world is expecting the Clang behaviour vs the GCC one. The Clang one as-is is the one that's less conservative,

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam abandoned this revision. thesamesam added a comment. Done, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136283/new/ https://reviews.llvm.org/D136283 ___ cfe-commits mailing list cfe-c

[PATCH] D138520: [clangd] Make decision forest model optional

thesamesam added a comment. Works on PPC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138520/new/ https://reviews.llvm.org/D138520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam added a comment. In D136283#3911832 , @sammccall wrote: > I don't think we should add significant build-system complexity here in order > to support the completion model on ppc32. > Do people actually use clangd on ppc32 machines? (The linked

[PATCH] D137511: [PPC] Undefine __ppc64__ to match GCC

thesamesam added a comment. This needs to go in Breaking Changes in the release notes, not least so we can link to it when updating upstreams. What do you mean by "while the darwin support has been removed from llvm-project."? I don't think that's the case, if you mean that LLVM.org's LLVM lac

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam updated this revision to Diff 472807. thesamesam added a comment. Use PARENT_SCOPE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136283/new/ https://reviews.llvm.org/D136283 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tool

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

thesamesam added a comment. Thanks for the CC. Yep, I had the same adventure with libedit and was very confused for a moment until we dug into it and realised: https://bugs.gentoo.org/870001. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/ne

[PATCH] D136283: [clang-tools-extra] [clangd] Split huge generated CompletionModel.cpp into smaller files

thesamesam created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. thesamesam requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Previously build system generated sin

[PATCH] D136282: [clang] [CMake] Link libclangBasic against libatomic when necessary.

thesamesam created this revision. thesamesam added reviewers: mgorny, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. thesamesam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary at least on PPC3

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

thesamesam added a comment. In D134337#3865905 , @tstellar wrote: > In D134337#3865753 , @mgorny wrote: > >> In D134337#3865541 , @tstellar >> wrote: >> >>> I know I'm a

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

thesamesam added a comment. My objection based on config support is no longer relevant, as it's been solved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133375/new/ https://reviews.llvm.org/D133375 ___

[PATCH] D129755: Thread safety analysis: Support copy-elided production of scoped capabilities through arbitrary calls

thesamesam added a comment. In D129755#3853809 , @aaronpuchert wrote: > @aaron.ballman, would like some feedback on the release notes. Should I > additionally write something under "Potentially Breaking Changes", or is it > enough to mention this under

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. It fixes a real-life issue I hit with Doxygen, as you know, so I'm happy with this - and I don't see a reason to treat libclang specially. I'll wait to see what any other reviewers say

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

thesamesam added a comment. I could use identical phrasing to `-Wincompatible-function-pointer-types` below (reference how to downgrade the error) but I don't think there's a need. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135545/new/ https://

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

thesamesam created this revision. thesamesam added reviewers: aaron.ballman, mgorny, MaskRay. thesamesam added a project: clang. Herald added a subscriber: StephenFan. Herald added a project: All. thesamesam requested review of this revision. Herald added a subscriber: cfe-commits. -Wimplicit-func

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

thesamesam added a comment. In D133375#3774293 , @aaron.ballman wrote: > So the basic idea here is that the default can be specified by a > configuration file and thus we don't need any configure-time variable for it? > But then why do we need other co

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

thesamesam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:52 + into an error-only diagnostic in the next Clang release. Fixes + `Issue 50055: `_. +- ``-Wincompatible-function-pointer-types`` now defaults to an e

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

thesamesam accepted this revision. thesamesam added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133771/new/ https://reviews.llvm.org/D133771 ___ cfe-commits mailing list cfe-commits@

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Been running with this for some time now (before we added the option). We should address the tests but they look sorted now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116843: [Driver][Gnu] -r: imply -nostdlib like GCC

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Looks good, although the documentation for `-r` and other driver options could be better (not your fault though). From https://gcc.gnu.org/onlinedocs/gcc/Link-Options.html: -r

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. This is working well here on Gentoo. This brings some long-desired feature parity to Clang which we've been wanting downstream: GCC has had this option for quite a few years (after pus