This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ddae8b94139: [clangd] Fix test failure when it's built
with compiler flags unknown by clang (authored by xry111, committed by
thesamesam).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150582/new/
https://reviews.llvm.org/D150582
Files:
clang-tools-extra/clangd/test/CMakeLists.txt
clang-tools-extra/clangd/test/compile_commands.json
Index: clang-tools-extra/clangd/test/compile_commands.json
===================================================================
--- /dev/null
+++ clang-tools-extra/clangd/test/compile_commands.json
@@ -0,0 +1 @@
+[]
Index: clang-tools-extra/clangd/test/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/test/CMakeLists.txt
+++ clang-tools-extra/clangd/test/CMakeLists.txt
@@ -28,6 +28,16 @@
${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py
)
+# Copy an empty compile_commands.json to override the compile_commands.json
+# in the top level build directory. Or if a clangd test involves creating a
+# temporary source file in the build directory and run clangd to check it,
+# it can pick up unrecognizable command options when LLVM is built with
+# another compiler or a different version of Clang.
+configure_file(
+ ${CMAKE_CURRENT_SOURCE_DIR}/compile_commands.json
+ ${CMAKE_CURRENT_BINARY_DIR}/compile_commands.json
+)
+
add_lit_testsuite(check-clangd "Running the Clangd regression tests"
# clangd doesn't put unittest configs in test/unit like every other project.
# Because of that, this needs to pass two folders here, while every other
Index: clang-tools-extra/clangd/test/compile_commands.json
===================================================================
--- /dev/null
+++ clang-tools-extra/clangd/test/compile_commands.json
@@ -0,0 +1 @@
+[]
Index: clang-tools-extra/clangd/test/CMakeLists.txt
===================================================================
--- clang-tools-extra/clangd/test/CMakeLists.txt
+++ clang-tools-extra/clangd/test/CMakeLists.txt
@@ -28,6 +28,16 @@
${CMAKE_CURRENT_SOURCE_DIR}/lit.cfg.py
)
+# Copy an empty compile_commands.json to override the compile_commands.json
+# in the top level build directory. Or if a clangd test involves creating a
+# temporary source file in the build directory and run clangd to check it,
+# it can pick up unrecognizable command options when LLVM is built with
+# another compiler or a different version of Clang.
+configure_file(
+ ${CMAKE_CURRENT_SOURCE_DIR}/compile_commands.json
+ ${CMAKE_CURRENT_BINARY_DIR}/compile_commands.json
+)
+
add_lit_testsuite(check-clangd "Running the Clangd regression tests"
# clangd doesn't put unittest configs in test/unit like every other project.
# Because of that, this needs to pass two folders here, while every other
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
