[clang] [compiler-rt] [flang] [libc] [libcxx] [llvm] [Clang][AMDGPU] Remove special handling for COV4 libraries (PR #132870)

2025-03-28 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. Thanks, Joseph! LGTM. https://github.com/llvm/llvm-project/pull/132870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[LinkerWrapper] Clean up options after proper forwarding" (PR #126495)

2025-02-10 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. https://github.com/llvm/llvm-project/pull/126495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-07 Thread Saiyedul Islam via cfe-commits
saiislam wrote: > > We already have a host-side `libomptarget`: > > https://github.com/llvm/llvm-project/blob/cfd8980fe79872feb9ed81959aa018681c7b3354/offload/src/CMakeLists.txt#L9 > > We can have conflicting names since they're in separate install directories. > I'd like this to have a more 's

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-27 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. Thank you for sticking up with this patch @zahiraam. It mostly looks ok to me, but please wait for @mjklemm and @Meinersbur reviews. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commit

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam commented: Thanks for the revising the PR. I have added some comments. To unblock #119891, wouldn't it be sufficient that `-fopenmp-version=60` becomes a valid value? Do we need to modify all these tests to test only this flag? https://github.com/llvm/llvm-project/

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -63,22 +63,22 @@ class VV { // CHECK-NEXT: int add(int a, int b) __attribute__((cold)){ // CHECK-NEXT: return a + b; // CHECK-NEXT: } - #pragma omp declare simd uniform(this, a) linear(val(b): a) + #pragma omp declare simd uniform(this, a) linear(b: a) --

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -25,16 +36,16 @@ __thread int t; // expected-note {{defined as threadprivate or thread local}} void f(); #pragma omp end declare target shared(a) // expected-warning {{extra tokens at the end of '#pragma omp end declare target' are ignored}} -#pragma omp declare target ma

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -4,19 +4,19 @@ // RUN: %clang_cc1 -verify -std=c++11 -fopenmp -ast-print %s -Wno-openmp-mapping -DOMP5 | FileCheck %s --check-prefix=CHECK --check-prefix=OMP50 // RUN: %clang_cc1 -fopenmp -x c++ -std=c++11 -emit-pch -o %t %s -DOMP5 // RUN: %clang_cc1 -fopenmp -std=c++11 -i

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -68,15 +70,15 @@ int fun(int arg) { {} #pragma omp target map(mapper(aa :vv) // expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected ')'}} expected-error {{call to undeclared function 'mapper'}} expected-note

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -69,11 +80,11 @@ void c(); void func() {} // expected-note {{'func' defined here}} -#pragma omp declare target link(func) allocate(a) // expected-error {{function name is not allowed in 'link' clause}} omp45-error {{unexpected 'allocate' clause, only 'to' or 'link' claus

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -1,10 +1,10 @@ -// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -fopenmp -emit-llvm -o - %s | FileCheck %s -// RUN: %clang_cc1 -fopenmp -triple x86_64-apple-darwin10 -x c++ -std=c++11 -emit-pch -o %t %s -// RUN: %clang_cc1 -fopenmp -triple x86_64-apple-darwin10 -std=

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -19,6 +19,8 @@ typedef void *omp_depend_t; void foo() {} void tmainc(){ omp_depend_t obj; + int omp_all_memory; saiislam wrote: Do we need this new variable? https://github.com/llvm/llvm-project/pull/122108

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Saiyedul Islam via cfe-commits
@@ -68,15 +70,15 @@ int fun(int arg) { {} #pragma omp target map(mapper(aa :vv) // expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected ')'}} expected-error {{call to undeclared function 'mapper'}} expected-note

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

2025-01-08 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam requested changes to this pull request. I agree with both points raised by @mjklemm . Even when we make 6.0 as default, I am pretty sure that many more LIT tests need to be updated. Please see https://reviews.llvm.org/D129635 for last update exercise. We also will

[clang] [Clang][OpenMP] Do not use feature option during packaging (PR #111702)

2024-10-09 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/111702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Do not use feature option during packaging (PR #111702)

2024-10-09 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/111702 Clang-offload-packager allows packaging of images based on an arbitrary list of key-value pairs where only triple-key is mandatory. Using target features as a key during packaging is not correct, as clang does

[clang] [LinkerWrapper] Forward `-mllvm` and `--offload-opt` arguments to device (PR #100424)

2024-07-24 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/100424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangLinkerWrapper] Fix intermediate file naming for multi-arch compilation (PR #99325)

2024-07-17 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/99325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Pass all files to the device linker (PR #97573)

2024-07-17 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/97573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LinkerWrapper] Pass all files to the device linker (PR #97573)

2024-07-17 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. The second commit to "Pass all files to the device linker" looks good to me. Overall, I am fine with the first commit of re-introducing clang-nvlinker-wrapper as well. Last time, we added to only wrap static device archives as cubin files

[clang] [ClangLinkerWrapper] Fix intermediate file naming for multi-arch compilation (PR #99325)

2024-07-17 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/99325 When save-temps is enabled and the given offload-archs differ only in target features with the same arch, the intermediate postlink.bc and postopt.bc files were getting overwritten. This fix, suffixes the interme

[clang] [Clang][OpenMP] Fix multi arch compilation for -march option (PR #92290)

2024-05-16 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/92290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Fix multi arch compilation for -march option (PR #92290)

2024-05-16 Thread Saiyedul Islam via cfe-commits
saiislam wrote: Thanks for the review and comments. Closing the PR. https://github.com/llvm/llvm-project/pull/92290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Fix multi arch compilation for -march option (PR #92290)

2024-05-15 Thread Saiyedul Islam via cfe-commits
saiislam wrote: > > If `-march` is the wrong option then let's start deprecating it and remove > > it altogether in the next llvm release. But, as long as it is here, it > > should be equivalent to `--offload-arch`. > > Honestly not a bad idea. I could make a patch warning users to use > `--o

[clang] [Clang][OpenMP] Fix multi arch compilation for -march option (PR #92290)

2024-05-15 Thread Saiyedul Islam via cfe-commits
saiislam wrote: > > > I don't think we want to support this. `-march` was the wrong option to > > > use in the first place, and upstream LLVM never supported specifying > > > multiple device images with `-march` so there isn't a legacy argument in > > > trunk. However, AOMP did support this an

[clang] [Clang][OpenMP] Fix multi arch compilation for -march option (PR #92290)

2024-05-15 Thread Saiyedul Islam via cfe-commits
saiislam wrote: > I don't think we want to support this. `-march` was the wrong option to use > in the first place, and upstream LLVM never supported specifying multiple > device images with `-march` so there isn't a legacy argument in trunk. > However, AOMP did support this and if it's deemed

[clang] [Clang][OpenMP] Fix multi arch compilation for -march option (PR #92290)

2024-05-15 Thread Saiyedul Islam via cfe-commits
saiislam wrote: It will fix tests like: [targetid_multi_image](https://github.com/ROCm/aomp/tree/aomp-dev/test/smoke/targetid_multi_image) https://github.com/llvm/llvm-project/pull/92290 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [Clang][OpenMP] Fix multi arch compilation for -march option (PR #92290)

2024-05-15 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/92290 Legacy toolchain to handle multiple target architectures specified using `-Xopenmp-target= -march=` was only processing a single architecture. This patch also fixes the use of comma to specify multiple archs for

[clang] [OpenMP][Clang] Enable inscan modifier for generic datatypes (PR #82220)

2024-02-18 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam commented: May be merge the two PRs in one? They both are not independent. https://github.com/llvm/llvm-project/pull/82220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [OpenMP][Clang] Handle unsupported inscan modifier for generic types (PR #79431)

2024-01-31 Thread Saiyedul Islam via cfe-commits
@@ -19520,6 +19520,13 @@ static bool actOnOMPReductionKindClause( bool FirstIter = true; for (Expr *RefExpr : VarList) { assert(RefExpr && "nullptr expr in OpenMP reduction clause."); +if (ClauseKind == OMPC_reduction && +RD.RedModifier == OMPC_REDUCTION_ins

[llvm] [clang] [lld] [AMDGPU] Rename COV module flag to amdhsa_code_object_version (PR #79905)

2024-01-30 Thread Saiyedul Islam via cfe-commits
@@ -25,4 +25,4 @@ entry: } !llvm.module.flags = !{!0} -!0 = !{i32 1, !"amdgpu_code_object_version", i32 500} +!0 = !{i32 1, !"amdhsa_code_object_version", i32 500} saiislam wrote: Can we remove explicit mention of COV5 module flag in all these test files giv

[clang] [OpenMP][Clang] Handle unsupported inscan modifier for generic types (PR #79431)

2024-01-25 Thread Saiyedul Islam via cfe-commits
@@ -12,28 +12,6 @@ void foo() {} -template saiislam wrote: How was this test case working till now when templates were not supported in scan? https://github.com/llvm/llvm-project/pull/79431 ___ cfe-commits maili

[flang] [mlir] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-23 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/79039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[flang] [mlir] [llvm] [clang] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-23 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/79038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [mlir] [flang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-23 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/79039 >From 384a90e5f161e4647a6ab803906a93f730c5df4b Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600 Subject: [PATCH 1/2] [AMDGPU] Change default AMDHSA Code Object version to 5 Al

[mlir] [flang] [clang] [llvm] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-23 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/79038 >From 384a90e5f161e4647a6ab803906a93f730c5df4b Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600 Subject: [PATCH] [AMDGPU] Change default AMDHSA Code Object version to 5 Also u

[llvm] [mlir] [clang] [flang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-23 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/79039 >From 04377914831f54f0572d5b1b233826fd0e204685 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600 Subject: [PATCH 1/2] [AMDGPU] Change default AMDHSA Code Object version to 5 Al

[clang] [llvm] [mlir] [flang] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-23 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/79038 >From 04377914831f54f0572d5b1b233826fd0e204685 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600 Subject: [PATCH] [AMDGPU] Change default AMDHSA Code Object version to 5 Also u

[clang] [llvm] [flang] [mlir] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/79039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [flang] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/79039 >From 9791643aa93f70bcaf89cd9ca679dbd1bed58676 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600 Subject: [PATCH 1/2] [AMDGPU] Change default AMDHSA Code Object version to 5 Al

[mlir] [flang] [llvm] [clang] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-22 Thread Saiyedul Islam via cfe-commits
saiislam wrote: > Should get a mention in the release notes Thanks for pointing it out. I have updated it. https://github.com/llvm/llvm-project/pull/79038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[mlir] [flang] [llvm] [clang] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/79038 >From 9791643aa93f70bcaf89cd9ca679dbd1bed58676 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600 Subject: [PATCH] [AMDGPU] Change default AMDHSA Code Object version to 5 Also u

[mlir] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam edited https://github.com/llvm/llvm-project/pull/79039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [llvm] [clang] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
@@ -99,6 +99,7 @@ class ROCDLDialectLLVMIRTranslationInterface if (!llvmFunc->hasFnAttribute("amdgpu-flat-work-group-size")) { llvmFunc->addFnAttr("amdgpu-flat-work-group-size", "1,256"); } + llvmFunc->addFnAttr("amdgpu-implicitarg-num-bytes", "256"); -

[llvm] [clang] [mlir] [AMDGPU] Update llvm-objdump lit tests for COV5 (PR #79039)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/79039 Depends on #79038 which makes cov5 as the default code object version. >From 4c156a11e943b85c1fe9f7f0ff5b651cf4d3946d Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Mon, 22 Jan 2024 13:11:22 -0600 Subject:

[llvm] [clang] [mlir] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #79038)

2024-01-22 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/79038 Also update LIT tests and docs. For more details, see https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata Corresponding llvm-objdump AMDGPU lit tests are updated in a follow-up PR. >From 4c156a11e943

[llvm] [clang] [LinkerWrapper] Handle AMDGPU Target-IDs correctly when linking (PR #78359)

2024-01-18 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. I tested with different combinations of compatible TargetIDs, the patch seems to work fine. Thanks a lot for working on this. LGTM! https://github.com/llvm/llvm-project/pull/78359 ___ cfe-commits

[clang] [clang-offload-bundler] Add support for -check-input-archive (PR #73709)

2023-11-28 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. Thanks, LGTM! https://github.com/llvm/llvm-project/pull/73709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [mlir] [lld] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-22 Thread Saiyedul Islam via cfe-commits
saiislam wrote: > (patches like this should probably be broken up - test changes to the > defaults in lld and llvm for instance don't depend on the change to the clang > driver which is the only real semantic change in this patch, right? So > probably only change the semantics of clang, and th

[llvm] [mlir] [clang] [lld] [AMDGPU] Change default AMDHSA Code Object version to 5 (PR #73000)

2023-11-21 Thread Saiyedul Islam via cfe-commits
@@ -88,7 +88,7 @@ class TargetOptions { COV_5 = 500, }; /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_None; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_5; s

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-08 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/71234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-08 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/71234 >From a6627248612fd2ab577b456a791e08164674efcc Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Fri, 3 Nov 2023 16:16:25 -0500 Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL Fixes

[clang] [openmp] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-08 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/71234 >From 91c64e83b3d8d405e71f8e3108483b88ee4758d8 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Fri, 3 Nov 2023 16:16:25 -0500 Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL Fixes

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-06 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/71234 >From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Fri, 3 Nov 2023 16:16:25 -0500 Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL Fixes

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-06 Thread Saiyedul Islam via cfe-commits
@@ -88,7 +88,7 @@ class TargetOptions { COV_5 = 500, }; /// \brief Code object version for AMDGPU. - CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_None; + CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_4; s

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-06 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/71234 >From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Fri, 3 Nov 2023 16:16:25 -0500 Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL Fixes

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-03 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/71234 >From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Fri, 3 Nov 2023 16:16:25 -0500 Subject: [PATCH 1/2] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL Fixes

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-03 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam updated https://github.com/llvm/llvm-project/pull/71234 >From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001 From: Saiyedul Islam Date: Fri, 3 Nov 2023 16:16:25 -0500 Subject: [PATCH 1/2] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL Fixes

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-03 Thread Saiyedul Islam via cfe-commits
@@ -3086,10 +3139,14 @@ Error AMDGPUKernelTy::launchImpl(GenericDeviceTy &GenericDevice, // Only COV5 implicitargs needs to be set. COV4 implicitargs are not used. if (getImplicitArgsSize() == sizeof(utils::AMDGPUImplicitArgsTy)) { ImplArgs->BlockCountX = NumBlocks; +

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-03 Thread Saiyedul Islam via cfe-commits
@@ -17468,19 +17468,19 @@ Value *EmitAMDGPUImplicitArgPtr(CodeGenFunction &CGF) { /// Emit code based on Code Object ABI version. /// COV_4: Emit code to use dispatch ptr /// COV_5: Emit code to use implicitarg ptr -/// COV_NONE : Emit code to load a global variable "l

[openmp] [clang] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL (PR #71234)

2023-11-03 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam created https://github.com/llvm/llvm-project/pull/71234 Fixes the DeviceRTL compilation to ensure it is ABI agnostic. Uses already available global variable "oclc_ABI_version" instead of "llvm.amdgcn.abi.verion". It also adds some minor fields in ImplicitArg struct

[clang] [Clang][OpenMP] Check if value is contained in array, not if it's contained in the first element (PR #69462)

2023-10-19 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/69462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-26 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/67366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-12 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam closed https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-05 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam review_requested https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-05 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam review_requested https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-05 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam review_requested https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-05 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam review_requested https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Make default AMDHSA Code Object Version to be 5 (PR #65410)

2023-09-05 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam labeled https://github.com/llvm/llvm-project/pull/65410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f616c3e - [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

2023-08-29 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2023-08-29T06:35:44-05:00 New Revision: f616c3eeb43f3732f53f81d291723a6a34af2de1 URL: https://github.com/llvm/llvm-project/commit/f616c3eeb43f3732f53f81d291723a6a34af2de1 DIFF: https://github.com/llvm/llvm-project/commit/f616c3eeb43f3732f53f81d291723a6a34af2de1.diff

[clang] 0cecc6e - [OpenMP] Add lit test for metadirective device arch inspired

2022-09-06 Thread Saiyedul Islam via cfe-commits
Author: Animesh Kumar Date: 2022-09-06T07:10:15-05:00 New Revision: 0cecc6e8e27c9913cd2d82a77941dc3a6d11318f URL: https://github.com/llvm/llvm-project/commit/0cecc6e8e27c9913cd2d82a77941dc3a6d11318f DIFF: https://github.com/llvm/llvm-project/commit/0cecc6e8e27c9913cd2d82a77941dc3a6d11318f.diff

[clang] 0f6cbde - [clang-offload-bundler] fix "no output file" issue with -outputs

2022-04-08 Thread Saiyedul Islam via cfe-commits
Author: Siu Chi Chan Date: 2022-04-08T17:11:27Z New Revision: 0f6cbdee576160a3b40139bf66b864ce05a1e28f URL: https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f DIFF: https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f.diff LOG:

[clang] 1e78d07 - [clang-offload-bundler] Fix typo in a test case

2022-03-02 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-03-02T13:33:56Z New Revision: 1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb URL: https://github.com/llvm/llvm-project/commit/1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb DIFF: https://github.com/llvm/llvm-project/commit/1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb.diff LOG

[clang] 7a02abf - [clang-offload-bundler] HIP and OpenMP comaptibility for linking heterogeneous archive library

2022-03-01 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-03-02T07:55:06Z New Revision: 7a02abf06ff94762d8cbce71d0249df25d64721b URL: https://github.com/llvm/llvm-project/commit/7a02abf06ff94762d8cbce71d0249df25d64721b DIFF: https://github.com/llvm/llvm-project/commit/7a02abf06ff94762d8cbce71d0249df25d64721b.diff LOG

[clang] 4db88a5 - [OpenMP][Clang] Move partial support of reverse offload to a future version

2022-02-08 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-02-09T07:11:41Z New Revision: 4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e URL: https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e DIFF: https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e.diff LOG

[clang] ae9c074 - [OpenMP][Clang] Allow ancestor device modifier only with reverse offloading

2022-02-04 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-02-04T12:10:14Z New Revision: ae9c0740648fd8f7010c895ddcf78380da94dd57 URL: https://github.com/llvm/llvm-project/commit/ae9c0740648fd8f7010c895ddcf78380da94dd57 DIFF: https://github.com/llvm/llvm-project/commit/ae9c0740648fd8f7010c895ddcf78380da94dd57.diff LOG

[clang] 52fddcd - [clang-format] Format ParseOpenMP.cpp changes

2022-01-27 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-01-27T09:00:34Z New Revision: 52fddcdd9c90a550d7a50cbc2013be3314f91d08 URL: https://github.com/llvm/llvm-project/commit/52fddcdd9c90a550d7a50cbc2013be3314f91d08 DIFF: https://github.com/llvm/llvm-project/commit/52fddcdd9c90a550d7a50cbc2013be3314f91d08.diff LOG

[clang] 6ee9654 - [Doc] Fix wrong indentation

2022-01-19 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-01-19T11:15:31Z New Revision: 6ee965471363972fafbed60ad8d27d0f666f8671 URL: https://github.com/llvm/llvm-project/commit/6ee965471363972fafbed60ad8d27d0f666f8671 DIFF: https://github.com/llvm/llvm-project/commit/6ee965471363972fafbed60ad8d27d0f666f8671.diff LOG

[clang] 0731f6b - [Doc] Add documentation for the clang-offload-wrapper tool (NFC)

2022-01-19 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-01-19T10:45:13Z New Revision: 0731f6ba4f5773071a7b91248caf79a287703a28 URL: https://github.com/llvm/llvm-project/commit/0731f6ba4f5773071a7b91248caf79a287703a28 DIFF: https://github.com/llvm/llvm-project/commit/0731f6ba4f5773071a7b91248caf79a287703a28.diff LOG

[clang] 876b5ea - [OpenMP][Clang] Allow passing target features in ISA trait for metadirective clause

2022-01-11 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-01-12T05:24:49Z New Revision: 876b5ea96bf5890074aec61bc2c6a37b2cdc0617 URL: https://github.com/llvm/llvm-project/commit/876b5ea96bf5890074aec61bc2c6a37b2cdc0617 DIFF: https://github.com/llvm/llvm-project/commit/876b5ea96bf5890074aec61bc2c6a37b2cdc0617.diff LOG

[clang] 49f23af - [OpenMP] Add nec and nvidia as compiler vendors for OpenMP

2022-01-04 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-01-04T12:30:43Z New Revision: 49f23afdc3453ad6834f32f69b48aa88b5d17338 URL: https://github.com/llvm/llvm-project/commit/49f23afdc3453ad6834f32f69b48aa88b5d17338 DIFF: https://github.com/llvm/llvm-project/commit/49f23afdc3453ad6834f32f69b48aa88b5d17338.diff LOG

[clang] 3235726 - [Clang][NFC] Fix multiline comment prefixes in function headers

2022-01-04 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2022-01-04T11:51:31Z New Revision: 32357266fd055e0eba63fc321f31a1c88eae0ea8 URL: https://github.com/llvm/llvm-project/commit/32357266fd055e0eba63fc321f31a1c88eae0ea8 DIFF: https://github.com/llvm/llvm-project/commit/32357266fd055e0eba63fc321f31a1c88eae0ea8.diff LOG

[clang] f565488 - [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

2021-10-12 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-12T16:15:52Z New Revision: f56548829c4c696d798c252bf097b71538bd45d7 URL: https://github.com/llvm/llvm-project/commit/f56548829c4c696d798c252bf097b71538bd45d7 DIFF: https://github.com/llvm/llvm-project/commit/f56548829c4c696d798c252bf097b71538bd45d7.diff LOG

[clang] 35ebe4c - [Clang][OpenMP] Add partial support for Static Device Libraries

2021-10-08 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-08T09:37:51Z New Revision: 35ebe4cc24f87397762e35831953c4bfe5f52def URL: https://github.com/llvm/llvm-project/commit/35ebe4cc24f87397762e35831953c4bfe5f52def DIFF: https://github.com/llvm/llvm-project/commit/35ebe4cc24f87397762e35831953c4bfe5f52def.diff LOG

[clang] 94e2b02 - Revert "[Clang][OpenMP] Add partial support for Static Device Libraries"

2021-10-07 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-07T14:13:24Z New Revision: 94e2b0258a176c7451dd8291cdf060ea048fee44 URL: https://github.com/llvm/llvm-project/commit/94e2b0258a176c7451dd8291cdf060ea048fee44 DIFF: https://github.com/llvm/llvm-project/commit/94e2b0258a176c7451dd8291cdf060ea048fee44.diff LOG

[clang] 1097f48 - Revert "[Clang][OpenMP] Fix fat archive tests for Mac and Windows"

2021-10-07 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-07T14:13:24Z New Revision: 1097f48e3dc3ab6811419f867350e79e280fb0eb URL: https://github.com/llvm/llvm-project/commit/1097f48e3dc3ab6811419f867350e79e280fb0eb DIFF: https://github.com/llvm/llvm-project/commit/1097f48e3dc3ab6811419f867350e79e280fb0eb.diff LOG

[clang] 3eb44f4 - Revert "[Clang][OpenMP] Fix windows buildbot failure for D105191"

2021-10-07 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-07T14:13:24Z New Revision: 3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67 URL: https://github.com/llvm/llvm-project/commit/3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67 DIFF: https://github.com/llvm/llvm-project/commit/3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67.diff LOG

[clang] 2baf7ad - [Clang][OpenMP] Fix fat archive tests for Mac and Windows

2021-10-07 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-07T13:38:46Z New Revision: 2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece URL: https://github.com/llvm/llvm-project/commit/2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece DIFF: https://github.com/llvm/llvm-project/commit/2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece.diff LOG

[clang] 06404d5 - [Clang][OpenMP] Fix windows buildbot failure for D105191

2021-10-06 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-07T05:54:56Z New Revision: 06404d5488ea505b00f711393973db3ae32d01e9 URL: https://github.com/llvm/llvm-project/commit/06404d5488ea505b00f711393973db3ae32d01e9 DIFF: https://github.com/llvm/llvm-project/commit/06404d5488ea505b00f711393973db3ae32d01e9.diff LOG

[clang] 4c41170 - [Clang][OpenMP] Add partial support for Static Device Libraries

2021-10-06 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-10-07T04:45:19Z New Revision: 4c4117089599cb5b6c6fa5635c28462ffd1bddf4 URL: https://github.com/llvm/llvm-project/commit/4c4117089599cb5b6c6fa5635c28462ffd1bddf4 DIFF: https://github.com/llvm/llvm-project/commit/4c4117089599cb5b6c6fa5635c28462ffd1bddf4.diff LOG

[clang] ee31ad0 - [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

2021-09-21 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-09-21T19:24:44+05:30 New Revision: ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0 URL: https://github.com/llvm/llvm-project/commit/ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0 DIFF: https://github.com/llvm/llvm-project/commit/ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0.diff

[clang] 4a25c3f - [clang-offload-bundler] Fix compatibility testing for non-assert builds

2021-09-10 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-09-10T18:57:03+05:30 New Revision: 4a25c3fb61942c629907ae50462087c3fbb8703a URL: https://github.com/llvm/llvm-project/commit/4a25c3fb61942c629907ae50462087c3fbb8703a DIFF: https://github.com/llvm/llvm-project/commit/4a25c3fb61942c629907ae50462087c3fbb8703a.diff

[clang] 543604f - [clang-nvlink-wrapper][docs][NFC] Fix sphinx warning about asterisk

2021-09-09 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-09-09T23:55:15+05:30 New Revision: 543604f30eddc5c9390d0fb01b0ac67937cbba0e URL: https://github.com/llvm/llvm-project/commit/543604f30eddc5c9390d0fb01b0ac67937cbba0e DIFF: https://github.com/llvm/llvm-project/commit/543604f30eddc5c9390d0fb01b0ac67937cbba0e.diff

[clang] 9838076 - [clang-offload-bundler] Make Bundle Entry ID backward compatible

2021-09-08 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-09-08T16:06:12+05:30 New Revision: 98380762c3b734c23d206182605ab9e035c93caa URL: https://github.com/llvm/llvm-project/commit/98380762c3b734c23d206182605ab9e035c93caa DIFF: https://github.com/llvm/llvm-project/commit/98380762c3b734c23d206182605ab9e035c93caa.diff

[clang] e158363 - [clang-nvlink-wrapper] Add documentation in clang docs

2021-09-05 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-09-06T11:43:58+05:30 New Revision: e15836361cdfeb3a717a2ebae94c68286111369b URL: https://github.com/llvm/llvm-project/commit/e15836361cdfeb3a717a2ebae94c68286111369b DIFF: https://github.com/llvm/llvm-project/commit/e15836361cdfeb3a717a2ebae94c68286111369b.diff

[clang] 83f3782 - [clang-nvlink-wrapper] Wrapper around nvlink for archive files

2021-09-01 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-09-01T16:00:29+05:30 New Revision: 83f3782c6129e7a5df3faaf0ae576611d16a8d49 URL: https://github.com/llvm/llvm-project/commit/83f3782c6129e7a5df3faaf0ae576611d16a8d49 DIFF: https://github.com/llvm/llvm-project/commit/83f3782c6129e7a5df3faaf0ae576611d16a8d49.diff

[clang] 94d5f2a - [Clang] Add test dependency on llvm-ar

2021-07-07 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-07-07T14:30:57+05:30 New Revision: 94d5f2afbef0bc18cf92f6d147c336da990e7a40 URL: https://github.com/llvm/llvm-project/commit/94d5f2afbef0bc18cf92f6d147c336da990e7a40 DIFF: https://github.com/llvm/llvm-project/commit/94d5f2afbef0bc18cf92f6d147c336da990e7a40.diff

[clang] f7ce532 - [clang-offload-bundler] Add unbundling of archives containing bundled object files into device specific archives

2021-06-30 Thread Saiyedul Islam via cfe-commits
Author: Saiyedul Islam Date: 2021-06-30T17:55:50+05:30 New Revision: f7ce532d622dc26eddd25f87faec0ff35dc0c2e9 URL: https://github.com/llvm/llvm-project/commit/f7ce532d622dc26eddd25f87faec0ff35dc0c2e9 DIFF: https://github.com/llvm/llvm-project/commit/f7ce532d622dc26eddd25f87faec0ff35dc0c2e9.diff

  1   2   >