https://github.com/saiislam approved this pull request.

The second commit to "Pass all files to the device linker" looks good to me.

Overall, I am fine with the first commit of re-introducing 
clang-nvlinker-wrapper as well. Last time, we added to only wrap static device 
archives as cubin files before passing to nvlink 
(https://reviews.llvm.org/D108291).
But, let's wait for @Artem-B to finish the review.

https://github.com/llvm/llvm-project/pull/97573
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to