[PATCH] D75323: Support relative dest paths in headermap files

2020-05-18 Thread Reid "On Leave"; Kleckner via Phabricator via cfe-commits
rnk added a comment. For more context: https://crbug.com/1056174 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D75323: Support relative dest paths in headermap files

2020-05-18 Thread Reid "On Leave"; Kleckner via Phabricator via cfe-commits
rnk added a comment. @vsapsai @bruno The use case is distributed compilation. I am unfamiliar with the changes in question, but essentially, if every input to clang is rooted in /Users/foo and the build works there, we should be able to move it all to /Users/bar, change directories, and the bui

[PATCH] D80153: [AST] Mangle LambdaContextDecl for top level decl

2020-05-18 Thread Reid "On Leave"; Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:950-952 // If the context of a closure type is an initializer for a class - // member (static or nonstatic), it is encoded in a qualified name. + // member (static or nonstatic)