https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/131942
>From 7f7f0ea87f460a951011ce75926f3e27900bb384 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 18 Mar 2025 13:19:24 -0700
Subject: [PATCH] [IRBuilder] Add new overload for CreateIntrinsic
Add a new `Creat
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/132060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/131942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/131942
>From 248b40f44df94093db8b1c8cd4284894be5b348a Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 18 Mar 2025 13:19:24 -0700
Subject: [PATCH] [IRBuilder] Add new overload for CreateIntrinsic
Add a new `Creat
jurahul wrote:
@nikic any concerns? I'll merge in a couple of days
https://github.com/llvm/llvm-project/pull/131942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/131942
>From 321ac988a49489d910bf8ba90a28d05db853cc0d Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 18 Mar 2025 13:19:24 -0700
Subject: [PATCH] [IRBuilder] Add new overload for CreateIntrinsic
Add a new `Creat
@@ -114,22 +114,23 @@ static Value *handleHlslClip(const CallExpr *E,
CodeGenFunction *CGF) {
CMP = CGF->Builder.CreateIntrinsic(
CGF->Builder.getInt1Ty(), CGF->CGM.getHLSLRuntime().getAnyIntrinsic(),
{FCompInst}, nullptr);
- } else
+ } else {
CMP =
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/132060
- Use `Intrinsic::` directly instead of `llvm::Intrinsic::`.
- Eliminate redundant `nullptr` for some `CreateIntrinsic` calls.
- Eliminate redundant `ArrayRef` casts.
- Use C++17 structured binding instead of `st
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/131942
>From e24106ee27fc6143914e92243556d5206cd230cf Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 18 Mar 2025 13:19:24 -0700
Subject: [PATCH] [IRBuilder] Add new overload for CreateIntrinsic
Add a new `Creat
jurahul wrote:
Even if a variable is defined in the main file, it could conflict with
another one in a library being linked.
In any case, my understanding is that this is a common C++ practice,
thought I do not see it spelled out explicitly in the coding standards doc:
file scoped global variabl
@@ -119,24 +119,24 @@ int main(int argc, char **argv) {
// options as static variables.. some of which overlap with our options.
llvm::cl::ResetCommandLineParser();
- llvm::cl::opt inputFilename(
+ static llvm::cl::opt inputFilename(
jurahul wrote:
Thes
@@ -20,7 +20,7 @@ using namespace mlir::lsp;
LogicalResult mlir::MlirLspServerMain(int argc, char **argv,
DialectRegistry ®istry) {
- llvm::cl::opt inputStyle{
+ static llvm::cl::opt inputStyle{
jurahul wrote:
These are
jurahul wrote:
Also, the commit description should be something like: "[NFC] Make file-local
cl::opt global variables static" or something like that
https://github.com/llvm/llvm-project/pull/126243
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
jurahul wrote:
> > I don't quite follow the motivation for this, can you expand on this in the
> > description please? Right now this seems unnecessary for the changes I can
> > see in MLIR for example.
>
> The linked bug seems to explain it, I think? It seems to be the usual "if
> something
jurahul wrote:
@arsenm did you intent to approve it without splitting? Is this trivial enough
to not need splitting as long as CI checks pass?
https://github.com/llvm/llvm-project/pull/126243
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
jurahul wrote:
You can check the CI logs for the exact command line it uses and replicate
it locally.
On Fri, Feb 7, 2025 at 7:46 AM chrisPyr ***@***.***> wrote:
> OK, I'll do it.
> Except for checking it on CI, is there any other method I can test
> locally? E.g. what options should I add
> I'
jurahul wrote:
Yeah, that’s why the description said most but not all. We should get link
failures if one of these is made static.
On Fri, Feb 7, 2025 at 7:17 AM Joseph Huber ***@***.***>
wrote:
> ***@***. commented on this pull request.
>
> This should definitely be split up. Also some opt
jurahul wrote:
I understand this is mostly mechanical changes, but wondering if review wise it
will help if its split up into 4-5 PRs. For example, bolt, clang, flag, llvm,
mlir etc.
https://github.com/llvm/llvm-project/pull/126243
___
cfe-commits ma
@@ -1908,7 +1908,7 @@ void clang::EmitClangDiagDocs(const RecordKeeper
&Records, raw_ostream &OS) {
for (const Record *G : DiagGroups) {
bool IsRemarkGroup = isRemarkGroup(G, DiagsInGroup);
auto &GroupInfo =
-DiagsInGroup[std::string(G->getValueAsString("Grou
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/119197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/119197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1908,7 +1908,7 @@ void clang::EmitClangDiagDocs(const RecordKeeper
&Records, raw_ostream &OS) {
for (const Record *G : DiagGroups) {
bool IsRemarkGroup = isRemarkGroup(G, DiagsInGroup);
auto &GroupInfo =
-DiagsInGroup[std::string(G->getValueAsString("Grou
https://github.com/jurahul approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/117479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/116491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/116491
None
>From a69664043703506d4331ff008d97de0c978a8aed Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 15 Nov 2024 09:49:12 -0800
Subject: [PATCH] [NFC][Clang][TableGen] Fix file header comments
---
clang/
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/116491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/115959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1419,16 +1412,14 @@ void clang::EmitClangDiagsDefs(const RecordKeeper
&Records, raw_ostream &OS,
InferPedantic inferPedantic(DGParentMap, Diags, DiagGroups, DiagsInGroup);
inferPedantic.compute(&DiagsInPedantic, (RecordVec*)nullptr);
- for (unsigned i = 0, e = Diags.
@@ -1419,16 +1412,14 @@ void clang::EmitClangDiagsDefs(const RecordKeeper
&Records, raw_ostream &OS,
InferPedantic inferPedantic(DGParentMap, Diags, DiagGroups, DiagsInGroup);
inferPedantic.compute(&DiagsInPedantic, (RecordVec*)nullptr);
- for (unsigned i = 0, e = Diags.
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115959
>From d63b8a017e73586cc8c4c9d5afe4b0d59f81ea17 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:38:02 -0800
Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in
ClangDiagnosticEm
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/115212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -145,7 +146,7 @@ static bool diagGroupBeforeByName(const Record *LHS, const
Record *RHS) {
RHS->getValueAsString("GroupName");
}
-using DiagsInGroupTy = std::map>;
+using DiagsInGroupTy = std::map>;
jurahul wrote:
Done.
https://github.com/llvm/l
@@ -117,15 +118,15 @@ namespace {
return CategoryIDs[CategoryString];
}
-typedef std::vector::const_iterator const_iterator;
+typedef std::vector::const_iterator const_iterator;
const_iterator begin() const { return CategoryStrings.begin(); }
const_
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/115962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/115972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115959
>From aa016d306c717ddffc0a7227678d8928be9583b4 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:38:02 -0800
Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in
ClangDiagnosticEm
@@ -145,7 +146,7 @@ static bool diagGroupBeforeByName(const Record *LHS, const
Record *RHS) {
RHS->getValueAsString("GroupName");
}
-using DiagsInGroupTy = std::map>;
+using DiagsInGroupTy = std::map>;
jurahul wrote:
Will do, I see that you added th
@@ -158,21 +159,19 @@ static void groupDiagnostics(ArrayRef
Diags,
continue;
assert(R->getValueAsDef("Class")->getName() != "CLASS_NOTE" &&
"Note can't be in a DiagGroup");
-std::string GroupName =
-std::string(DI->getDef()->getValueAsString("G
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/115972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115962
>From 07c74bee58d1a56978b1cba00755cc3ca14cb71f Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:51:54 -0800
Subject: [PATCH 1/2] [NFC][lang][TableGen] Simplify `EmitClangDiagsIndexName`
Simp
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/115962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/115959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/115972
Use StringRef and range for loops in Clang SACheckers and Syntax emitters.
>From 7e297e5641cead196772b33fc6633efe9837f09d Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 17:06:08 -0800
Subject
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115959
>From 5ba5485bbc8895743130f58779cf5c78eb0941aa Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:38:02 -0800
Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in
ClangDiagnosticEm
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115959
>From 04b7434139ffdb412797e9d4fe7d31ecbdbe7748 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:38:02 -0800
Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in
ClangDiagnosticEm
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/115962
Simplify `EmitClangDiagsIndexName` to directly sort records instead of creating
an array of `RecordIndexElement` containing record name and sorting it.
>From 07c74bee58d1a56978b1cba00755cc3ca14cb71f Mon Sep 17
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115959
>From cdcd09ec7c11a21da0804a6e886aff6410c42daf Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:38:02 -0800
Subject: [PATCH] [NFC][Clang] Use StringRef instead of string in
ClangDiagnosticEm
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/115959
Use StringRef instead of std::string in ClangDiagnosticEmitter.
>From 5f67dd57f3e6333da438dc07a2efdfcb0c1874b1 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Tue, 12 Nov 2024 15:38:02 -0800
Subject: [PATCH] [
jurahul wrote:
Its not clear to me if the failure is real or intermittent:
FAILURE
Failed to match LIBC_NAMESPACE::mkdirat(AT_FDCWD, TEST_DIR, S_IRWXU) against
Succeeds(0).
Expected return value to be equal to 0 but got -1.
Expected errno to be equal to "Success" but got "File exists".
https:
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/115573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1570,8 +1541,7 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
for (auto const &Group : GroupsInPedantic) {
const std::string &GroupName =
std::string(Group->getValueAsString("GroupName"));
- std::map::const_iterator RI =
-
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/115573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -970,10 +942,11 @@ struct DiagTextPrinter : DiagTextVisitor
{
void VisitPlural(PluralPiece *P) {
Result += "%plural{";
assert(P->Options.size() == P->OptionPrefixes.size());
-for (unsigned I = 0, End = P->Options.size(); I < End; ++I) {
- if (P->OptionPre
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
@@ -1553,15 +1526,13 @@ static void emitDiagSubGroups(std::map &DiagsInGroup,
RecordVec &GroupsInPedantic, raw_ostream &OS) {
OS << "static const int16_t DiagSubGroups[] = {\n"
<< " /* Empty */ -1,\n";
- for (auto const &I : DiagsInGroup)
@@ -468,11 +442,9 @@ static StringRef getModifierName(ModifierType MT) {
return "objcclass";
case MT_ObjCInstance:
return "objcinstance";
- case MT_Unknown:
+ default:
jurahul wrote:
Done now.
https://github.com/llvm/llvm-project/pull/115573
_
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115573
>From 635b24a4e057d85de6c2935ed817b93b34916ed3 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 8 Nov 2024 16:04:53 -0800
Subject: [PATCH] [NFC][Clang] Use range for loops in ClangDiagnosticsEmitter
Use ra
@@ -970,10 +942,11 @@ struct DiagTextPrinter : DiagTextVisitor
{
void VisitPlural(PluralPiece *P) {
Result += "%plural{";
assert(P->Options.size() == P->OptionPrefixes.size());
-for (unsigned I = 0, End = P->Options.size(); I < End; ++I) {
- if (P->OptionPre
@@ -468,11 +442,9 @@ static StringRef getModifierName(ModifierType MT) {
return "objcclass";
case MT_ObjCInstance:
return "objcinstance";
- case MT_Unknown:
+ default:
jurahul wrote:
Thanks. I'll revert this back.
https://github.com/llvm/llvm-proj
@@ -185,10 +174,8 @@ static void groupDiagnostics(ArrayRef
Diags,
}
// Assign unique ID numbers to the groups.
- unsigned IDNo = 0;
- for (std::map::iterator
- I = DiagsInGroup.begin(), E = DiagsInGroup.end(); I != E; ++I, ++IDNo)
-I->second.IDNo = IDNo;
+ fo
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/115573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/115573
Use range based for loops in Clang diagnostics emitter.
>From af56060f8d27bb84ce642f6fd53de14ad8765bef Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Fri, 8 Nov 2024 16:04:53 -0800
Subject: [PATCH] [NFC][Clan
jurahul wrote:
> Is there any way you could split up into several patches? It's hard to follow
> when you do multiple things in one patch. Thanks!
Let me try to do it. May be a PR for just range based for loops to start with
https://github.com/llvm/llvm-project/pull/115212
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/115212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115212
>From 381cb66fbf539bb122a9970efca85fdce75f1b36 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 6 Nov 2024 11:22:55 -0800
Subject: [PATCH] [Clang] Refactor ClangDiagnosticEmitter to use more StringRef
Refa
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/115212
>From c3df877042c59ca9c9303de0f1707359cd91e9bd Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 6 Nov 2024 11:22:55 -0800
Subject: [PATCH] [Clang] Refactor ClangDiagnosticEmitter to use more StringRef
Refa
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/115212
Refactor ClangDiagnosticEmitter to use more StringRefs. Also use more range for
loops.
Verified that .inc files generated by clang build are identical with and
without the change.
>From b6c2a0777313c3f378c4bc
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/114331
>From 466b99a4d2f53daeecb4d0cfeb3ed5a05c2af03e Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Oct 2024 16:51:36 -0700
Subject: [PATCH 1/2] [NFC] Remove referenced to deleted `ClangFormattedStatus`
fil
jurahul wrote:
> LGTM - thanks
Thanks. Will merge once checks are green
https://github.com/llvm/llvm-project/pull/114331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul created
https://github.com/llvm/llvm-project/pull/114331
None
>From 466b99a4d2f53daeecb4d0cfeb3ed5a05c2af03e Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Wed, 30 Oct 2024 16:51:36 -0700
Subject: [PATCH] [NFC] Remove referenced to deleted `ClangFormattedStatus`
f
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/114331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/114331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Started https://github.com/llvm/llvm-project/pull/114331
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Let me delete those references. The ones in generated_formatted_state.py are
fine
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
@AaronBallman go ahead with the merge since @owenca has approved?
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jurahul wrote:
Thanks. I haven't seen any responses from @mydeveloperday earlier, hopefully
@owenca can chime in.
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
jurahul wrote:
@AaronBallman can you PTAL?
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/113645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/109220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/113645
>From 9192413d91525ef47cb7ee1837afcd0e89849481 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 24 Oct 2024 15:25:22 -0700
Subject: [PATCH] [Clang][TableGen] Use StringRef::str() instead of
std::string() c
https://github.com/jurahul closed
https://github.com/llvm/llvm-project/pull/113809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/113809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/113809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/113809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/113809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -49,40 +49,38 @@ using namespace llvm;
namespace {
class FlattenedSpelling {
- std::string V, N, NS;
+ StringRef V, N, NS;
jurahul wrote:
In short, I'll defer it to you. If we don't want to commit this, I am fine and
the find the reasoning behind if rea
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/113809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -49,40 +49,38 @@ using namespace llvm;
namespace {
class FlattenedSpelling {
- std::string V, N, NS;
+ StringRef V, N, NS;
jurahul wrote:
> TG is not perf critical
I have seen bugs about Tg perf, but may be not this particular backend,
https://github.
@@ -49,40 +49,38 @@ using namespace llvm;
namespace {
class FlattenedSpelling {
- std::string V, N, NS;
+ StringRef V, N, NS;
jurahul wrote:
In all these instances, the strings are derived from TableGen Records, so they
do outlive. I do agree that TG is no
jurahul wrote:
Thanks. I'll queue this behind https://github.com/llvm/llvm-project/pull/113809.
https://github.com/llvm/llvm-project/pull/113645
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
@@ -54,19 +54,18 @@ class FlattenedSpelling {
const Record &OriginalSpelling;
public:
- FlattenedSpelling(const std::string &Variety, const std::string &Name,
+ FlattenedSpelling(const std::string &Variety, StringRef Name,
const std::string &Namespace,
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/113809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/113809
>From 6b128746e5f6bfa13e0ea9a900f0bc8529437717 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Sun, 27 Oct 2024 06:51:55 -0700
Subject: [PATCH] [Clang][TableGen] Use StringRef in FlattenedSpelling
Change Flatt
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/113809
>From 60da18c88e63612c791ccbb423d752bac311650b Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Sun, 27 Oct 2024 06:51:55 -0700
Subject: [PATCH] [Clang][TableGen] Use StringRef in FlattenedSpelling
Change Flatt
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/113809
>From 5fd76fe7a8fe6a009966cf0d7d67a53b68b601a1 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Sun, 27 Oct 2024 06:51:55 -0700
Subject: [PATCH] [Clang][TableGen] Use StringRef in FlattenedSpelling
Change Flatt
1 - 100 of 432 matches
Mail list logo
