[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

qiucf added a comment. Hi, it seems rG086b65340cca2648a2a91a0a47d28c7d9bafd1e5 causes build failure: llvm-project/clang/lib/Basic/OpenMPKinds.cpp:444:13: error: 97 enumeration values not handled in switch: 'OMPC_adjust_arg

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e97db89ae8e: [PowerPC] Emit IR module flag for current float abi (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D116016?vs=530843&id=557298#toc Repository: rG LLVM Github Mon

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf abandoned this revision. qiucf added a comment. Migrated to https://github.com/llvm/llvm-project/pull/67299 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158066/new/ https://reviews.llvm.org/D158066 __

[PATCH] D159159: [PowerPC] Disable float128 on AIX in Clang

qiucf abandoned this revision. qiucf added a comment. Migrated to https://github.com/llvm/llvm-project/pull/67298 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159159/new/ https://reviews.llvm.org/D159159 __

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf added a comment. Gentle ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D117181: [PowerPC] Use IEEE long double in proper toolchain

qiucf abandoned this revision. qiucf added a comment. Determining float ABI by system library without explicit options may cause confusion. Since Fedora has successfully switched using ieeelongdouble on ppc64le (https://developers.redhat.com/articles/2023/05/16/benefits-fedora-38-long-double-tr

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf updated this revision to Diff 555805. qiucf added a comment. - Add macro alias to `mffs` `mffsl` `mtfsf` and `set_fpscr_rn`, although they don't work in freestanding mode - Add C++ run lines to intrinsics tests. To avoid further messing codegen checks, make them run under `-fsyntax-only`.

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

This revision was automatically updated to reflect the committed changes. Closed by commit rG082c5d7f63c4: [PowerPC] Implement builtin for mffsl (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158065/new/ https://reviews.llvm.org/

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG880f39af6115: [Clang] Enable AIX initial-exec TLS mode (authored by qiucf). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

qiucf added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156076/new/ https://reviews.llvm.org/D156076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D159159: [PowerPC] Disable float128 on AIX in Clang

qiucf created this revision. qiucf added a reviewer: PowerPC. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PowerPC AIX backend does no

[PATCH] D158484: [PowerPC][altivec] Correct modulo number of vec_promote on vector char

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158484/new/ https://reviews.llvm.org/D158484

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

qiucf added inline comments. Comment at: clang/lib/Headers/altivec.h:14662 + vector unsigned char __res = + __builtin_shufflevector(__zero, __zero, -1, -1, -1, -1, -1, -1, -1, -1, + -1, -1, -1, -1, -1, -1, -1, -1); Could we just

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf added a comment. In D158066#4601785 , @nemanjai wrote: > It should be perfectly fine to provide pre-defined macros for these to match > GCC on PowerPC. The reason we went with the macro solution is to avoid > polluting the builtins namespace for o

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf added subscribers: quinnp, amyk. qiucf added a comment. CC @amyk @quinnp Any comments about the naming? I see some `__builtin_ppc_xxx` are aliased into `__builtin_xxx` by `defineXLCompatMacros`. But these are not XL-compatible builtins, and the macros do not always work. Repository: r

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf marked 2 inline comments as done. qiucf added a comment. Thanks, fixed by rG2459ed67805c . `nmmintrin.h` just includes `smmintrin.h` so it's not critical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158066: [PowerPC] Fix use of FPSCR builtins in smmintrin.h

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, stefanp, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `smmintrin.h` uses `__builtin_mf

[PATCH] D158065: [PowerPC] Implement builtin for mffsl

qiucf created this revision. qiucf added reviewers: nemanjai, stefanp, shchenz, PowerPC. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. `mff

[PATCH] D156076: [PowerPC][Clang] Remove constraint for initial-exec TLS mode on AIX

qiucf created this revision. qiucf added reviewers: stefanp, shchenz, amyk, tingwang, PowerPC. Herald added a subscriber: nemanjai. Herald added a reviewer: aaron.ballman. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

qiucf added a comment. Is there any blocker for this to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf abandoned this revision. qiucf added a subscriber: tuliom. qiucf added a comment. There's a glibc patch in review to fix the motivation error in math.h (thanks to @tuliom ): https://patchwork.sourceware.org/project/glibc/patch/20230613215633.3179708-1-tul...@ascii.art.br/ I think this rev

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf updated this revision to Diff 530843. qiucf marked an inline comment as done. qiucf edited the summary of this revision. qiucf removed a reviewer: jsji. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016

[PATCH] D149548: [IR] Update to use new shufflevector semantics

qiucf added subscribers: jonpa, uweigand. qiucf added a comment. Why this changes IR output of following case? // RUN: clang vecpromote.c -S -o - -O0 -target s390x-linux-gnu -fzvector -emit-llvm #include vector int si; int g; int i; void foo() { si = vec_promote(g, i); }

[PATCH] D152351: [clang] Add __builtin_isfpclass

qiucf added a comment. It's necessary to check range of first argument in `SemaChecking.cpp` using `SemaBuiltinConstantArgRange`. _Bool check_isfpclass_1(float x) { return __builtin_isfpclass(123456, x); } // ICE int g; // error: cannot compile this builtin function yet // there's be

[PATCH] D148490: [AIX] use system assembler for assembly files

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. This looks reasonable to me, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___

[PATCH] D150087: [Clang] Support more stdio builtins

This revision was automatically updated to reflect the committed changes. qiucf marked an inline comment as done. Closed by commit rGbaeb85b5a997: [Clang] Support more stdio builtins (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D150087: [Clang] Support more stdio builtins

qiucf marked an inline comment as done. qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:109 + {Builtin::BI__builtin___vsnprintf_chk, "__vsnprintfieee128"}, + {Builtin::BI__builtin___vsprintf_chk, "__vsprintfieee128"}, + {Builtin::BI__builti

[PATCH] D150087: [Clang] Support more stdio builtins

qiucf updated this revision to Diff 523305. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150087/new/ https://reviews.llvm.org/D150087 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGBuil

[PATCH] D150087: [Clang] Support more stdio builtins

qiucf created this revision. qiucf added reviewers: nemanjai, craig.topper, PowerPC, tuliom, tstellar. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add more builtins

[PATCH] D148490: [AIX] use system assembler for assembly files

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:427 + Assembler.reset(buildAssembler()); +return Assembler.get(); + } I saw we have a `ToolChain::getAssemble()` method. Can we use that directly? Comment at

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. Gentle ping .. @kamaub Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D143467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. In D143467#4258380 , @kamaub wrote: > Sorry I should have requested changes before for this comment below, but I do > want these test moved to codegen and expanded, please let me know if anything > is unclear. > > In D143467#42416

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-test.c:47 -int test_test_data_class_f() { -// CHECK-LABEL: @test_test_data_class_f -// CHECK: [[TMP:%.*]] = call i32 @llvm.ppc.test.data.class.f32(float %0, i32 127) -//

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:444 +TARGET_BUILTIN(__builtin_altivec_vcmpnew_p, "iiV4iV4i", "", "power9-vector") +TARGET_BUILTIN(__builtin_altivec_vcmpned_p, "iiV2LLiV2LLi", "", "altivec") + maryammo wrote: > am

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf added a comment. In D143479#4243143 , @erichkeane wrote: > Based on GCC's behavior: https://godbolt.org/z/fxWzPTT9P I suspect our > behavior is consistent/correct now, and the 'regressions' are to be expected, > since GCC diagnoses the same thin

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

This revision was automatically updated to reflect the committed changes. Closed by commit rG608212a0ff2f: [Clang] Check feature requirement from inlined callee (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143479/new/ https://r

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf added a comment. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143479/new/ https://reviews.llvm.org/D143479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. In D143467#4182457 , @nemanjai wrote: > Another note regarding the motivating test case: > Use of `vector double` should require VSX. We don't really seem to have the > ability to turn this off early enough to catch this though. It

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. > However, manually adding the required target feature seems a little > mistakable, like the one below. I guess we can not get the required feature > in the LLVM instruction TDs(if the builtin is mapped to a IR intrinsic and > the intrinsic is selected inside the instruct

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D143467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb90bb986611: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning (authored by tuliom, committed by qiucf). Repository: rG LLVM G

[PATCH] D143736: [PowerPC] Specify the dynamic loader prefix in ppc-float-abi-warning

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. LGTM, thanks for catching this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143736/new/ https://reviews.llvm.org/D143736 __

[PATCH] D143479: [Clang] Emit error when caller cannot meet target feature requirement from always-inlining callee

qiucf created this revision. qiucf added reviewers: echristo, LiuChen3, erichkeane, GBuella. Herald added subscribers: steven.zhang, kbarton, nemanjai. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Curre

[PATCH] D143467: [PowerPC] Add target feature requirement to builtins

qiucf created this revision. qiucf added reviewers: nemanjai, sfertile, amyk, shchenz, lkail, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang has mechanis

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa40ef656d812: [Intrinsic] Rename flt.rounds intrinsic to get.rounding (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

qiucf updated this revision to Diff 483434. qiucf marked 3 inline comments as done. qiucf removed a reviewer: libc++abi. qiucf removed a project: libc++abi. qiucf removed a subscriber: libcxx-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1395

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added a comment. Committed as https://github.com/llvm/llvm-project/commit/5f68c4111ab9c79b902723df3986dd1033813c01 `ppc-float-abi-warning.cpp` would fail when testing on machine with glibc older than 2.32 but `PPC_LINUX_DEFAULT_IEEELONGDOUBLE` enabled, which is known failure even before

[PATCH] D139450: Warn about unsupported ibmlongdouble

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f68c4111ab9: Warn about unsupported ibmlongdouble (authored by tuliom, committed by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139450/new/ https

[PATCH] D139507: [Intrinsic] Rename flt.rounds intrinsic to get.rounding

qiucf updated this revision to Diff 482381. qiucf retitled this revision from "[Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes" to "[Intrinsic] Rename flt.rounds intrinsic to get.rounding". qiucf edited the summary of this revision. qiucf added a comment. Use Aut

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added inline comments. Comment at: clang/test/Driver/lit.local.cfg:26 +if config.ppc_linux_default_ieeelongdouble == "ON": + config.available_features.add('ppc_linux_default_ieeelongdouble') tuliom wrote: > qiucf wrote: > > Can we assume if we are compilin

[PATCH] D139450: Warn about unsupported ibmlongdouble

qiucf added a comment. Thanks for the patch! But does libc++ support to be built with `-mabi=ieeelongdouble` now? (like libstdc++, if it works correctly, it should co-exist and be linked with different long double ABIs) Comment at: clang/lib/Driver/ToolChains/PPCLinux.cpp:96

[PATCH] D112932: [WIP] Use llvm.is_fpclass to implement FP classification functions

qiucf added a comment. Herald added a project: All. This patch looks good and `llvm.is.fpclass` will by default be expanded (except SystemZ which has their own lowering). Is there any blocker for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

qiucf added a comment. In D139507#3978449 , @sepavloff wrote: > Thank you for working on this! > > Is there any reason why we should keep the old intrinsic? In case any user outside of clang references it (although I believe no), we can deprecate it and

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62f20f51ce39: [PowerPC] Support test data class intrinsic of 128-bit float (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

qiucf created this revision. qiucf added reviewers: andrew.w.kaylor, sepavloff, kpn, RKSimon, craig.topper, nemanjai, cameron.mcinally. Herald added subscribers: jeroen.dobbelaere, StephenFan, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, th

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

qiucf updated this revision to Diff 477375. qiucf added a comment. Change error message regarding `__float128`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138105/new/ https://reviews.llvm.org/D138105 Files: clang/include/clang/Basic/Diagnosti

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

This revision was automatically updated to reflect the committed changes. Closed by commit rGcab9c02bd97f: [Clang] Fix behavior of -ffp-model option when overriden (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D137618?vs=475981&id=476309#toc Repository: rG LLVM Githu

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf marked an inline comment as done. qiucf added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137618/new/ https://reviews.llvm.org/D137618 ___ cfe-commits mailing list cfe-commits@

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3034 RoundingFPMath = false; + FPExceptionBehavior = ""; // If fast-math is set then set the fp-contract mode to fast. zahiraam wrote: > FPExceptionBehavior should

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf updated this revision to Diff 475981. qiucf marked an inline comment as done. qiucf added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137618/new/ https://reviews.llvm.org/D137618 Files: clang/lib/Driver/ToolCh

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, PowerPC, quinnp, stefanp. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commit

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf updated this revision to Diff 474142. qiucf marked an inline comment as done. qiucf added a reviewer: michele.scandale. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137618/new/ https://reviews.llvm.org/D137618 Files: clang/lib/Driver/ToolCh

[PATCH] D137536: [NFC] Replace use of PPC64 macro into powerpc64 in intrinsic headers

qiucf abandoned this revision. qiucf added a comment. I think rG7aa90b21b453d1ca52fdfccfd7e01e61d9e5b1f1 has already done that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

qiucf created this revision. qiucf added reviewers: aaron.ballman, mibintc, andrew.w.kaylor, masoud.ataei, zahiraam. Herald added a project: All. qiucf requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. `-ffp-model=strict -ffp-model=f

[PATCH] D137536: [NFC] Replace use of PPC64 macro into powerpc64 in intrinsic headers

qiucf created this revision. qiucf added reviewers: nemanjai, lkail, shchenz, PowerPC. Herald added a subscriber: kbarton. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG708084ec379e: [PowerPC] Support x86 compatible intrinsics on AIX (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 446335. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Headers/ppc_wrapp

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:232 +path::remove_filename(P); +addSystemInclude(DriverArgs, CC1Args, P); } shchenz wrote: > Can we use `path::parent_path(P)` directly in `addSystemInclude()`? > `remove_fil

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/ppc-emmintrin.c:631 // CHECK: %[[ADDR:[0-9a-zA-Z_.]+]] = load double*, double** %{{[0-9a-zA-Z_.]+}}, align 8 -// CHECK: %[[VAL:[0-9a-zA-Z_.]+]] = load double, double* %[[ADDR]], align 8 +// CHECK: %[[VAL:[0-9a-

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 444182. qiucf added a comment. Herald added a subscriber: ormris. Merge conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf updated this revision to Diff 444175. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129461/new/ https://reviews.llvm.org/D129461 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Headers/ppc_wrapp

[PATCH] D129461: [PowerPC] Support x86 compatible intrinsics on AIX

qiucf created this revision. qiucf added reviewers: nemanjai, shchenz, hubert.reinterpretcast, PowerPC. Herald added subscribers: jsji, steven.zhang, kbarton, krytarowski, arichardson, emaste. Herald added a project: All. qiucf requested review of this revision. Herald added subscribers: cfe-commi

[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Abandon this since we have rGe2a1f8ec27b88be670cd867c43588f24516d2bbf . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126302: [PowerPC] Diagnose invalid combination with Altivec, VSX and soft-float

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:450 + // Cannot allow VSX with no Altivec. + if (llvm::is_contained(FeaturesVec, "-hard-float") && Comments in reverse order? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf accepted this revision as: qiucf. qiucf added a comment. This revision is now accepted and ready to land. Looks good to me in my side. Thanks for implementing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122478/new/ https://reviews.llvm.

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9897 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Use `err_target_unsuppo

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf added a comment. In D121992#3418443 , @MaskRay wrote: > To add more why I think the current semantics may need more discussion before > we quickly commit to such a driver option: > > - interaction with --dyld-prefix: --sysroot does not affect the f

[PATCH] D122478: [PowerPC] Add max/min intrinsics to Clang and PPC backend

qiucf added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9899 +def err_ppc_unsupported_argument_type : Error< + "unsupported argument type %0 for target %1">; def err_x86_builtin_invalid_rounding : Error< Can we re-use `err_type

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf added a comment. Hi, > Why is --overlay-platform-toolchain added instead of using -isystem and -L? > > The functionality overlaps with -B. Unsure why introduce a new mechanism. We may want to use an extra toolchain like the Advance Toolchain (https://github.com/advancetoolchain/advance-to

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG406bde9a1513: [PowerPC] [Clang] Add SSE4 and BMI intrinsics implementation (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

This revision was automatically updated to reflect the committed changes. Closed by commit rGd00e8400e2e3: [Clang] Add option to set alternative toolchain path (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://re

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf updated this revision to Diff 417566. qiucf marked 3 inline comments as done. qiucf added a comment. - Move test to another file - Add documentation on option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121992/new/ https://reviews.llvm.org/

[PATCH] D121992: [Clang] [Driver] Add option to set alternative toolchain path

qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, jsji, nemanjai, collinbaker, rpenacob. Herald added a project: All. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In some cases, we need to set alternative

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. LGTM, thanks for the catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121209/new/ https://reviews.llvm.org/D121209 __

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 413336. qiucf added a comment. Herald added a project: All. Add P10 tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2497e54356d: [PowerPC] Add generic fnmsub intrinsic (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-math.c:98 // CHECK-NEXT:store double [[D:%.*]], double* [[D_ADDR]], align 8 +// CHECK-COUNT-3:load double, double* [[D_ADDR]], align 8 // CHECK-NEXT:[[TMP0:%.*]] = load double,

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf updated this revision to Diff 41. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/PowerPC/buil

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf updated this revision to Diff 411046. qiucf marked an inline comment as done. qiucf edited the summary of this revision. qiucf added a comment. Replace existing `ppc.fnmsub` and `ppc.fnmsubs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1160

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. In D116015#3326148 , @shchenz wrote: >> hiding the semantics from the optimizer is sometimes a good thing and >> sometimes a bad thing). > > Agree. Imagining a case when the neg and fma (from fnmsub) can both be CSE-ed > with anot

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 409167. qiucf edited the summary of this revision. qiucf added a comment. Rebase the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang/lib/Headers/CMa

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf planned changes to this revision. qiucf added a comment. This breaks existing smm/tmm tests, will update/clean-up them before this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 __

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf updated this revision to Diff 407444. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119407/new/ https://reviews.llvm.org/D119407 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Headers/ppc_wrappers/bmi2

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D119407: [PowerPC] [Clang] Add SSE4 and BMI compatible intrinsics implementation for PowerPC

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, PowerPC, shchenz. Herald added subscribers: kbarton, krytarowski. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3305014 , @jwakely wrote: > In D112906#3304925 , @qiucf wrote: > >> Is that because clang lacks something required by this feature? (for >> example. clang-12 doesn't have `__ibm1

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

qiucf added a comment. In D112906#3304340 , @jwakely wrote: >> GCC 12 should have proper support for IEEE-754 compliant 128-bit floating >> point in libstdc++. > > Yes, but it's unconditionally disabled when including the headers with Clang. Is that bec

[PATCH] D117972: [PowerPC] Fix SSE translation on FreeBSD

qiucf added a comment. In D117972#3287553 , @pkubaj wrote: > Since I'm not a LLVM committer, can you commit it and merge to 14 branch? Sure. Sorry for late response, I'm on vacation these days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116395: [Clang] Emit warning for -x option without effects

qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116395/new/ https://reviews.llvm.org/D116395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D118110: [CMake] [Clang] Add CMake build option to specify long double format on PowerPC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb797d5e6b21b: [CMake] [Clang] Add option to specify PowerPC long double format (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES S

  1   2   3   >