qiucf added a comment. In D143467#4258380 <https://reviews.llvm.org/D143467#4258380>, @kamaub wrote:
> Sorry I should have requested changes before for this comment below, but I do > want these test moved to codegen and expanded, please let me know if anything > is unclear. > > In D143467#4241667 <https://reviews.llvm.org/D143467#4241667>, @kamaub wrote: > >> Can you add a PowerPC codegen test case for `__attribute__((target(`? All of >> the updated test cases seem to only test `-target-feature`. >> The only test case we have for `__attribute((target(` is a sema test >> `./clang/test/Sema/ppc-attr-target-inline.c`. >> >> Converting the deleted `clang/test/Sema/ppc-mma-builtins.c` and >> `clang/test/Sema/ppc-paired-vector-builtins.c` to a codegen test cases >> like `clang/test/CodeGen/PowerPC/builtins-ppc-htm.c` using FileCheck seems >> like a nice solution since it would reintroduce the testing >> for `+paired-vector-memops,-mma` situations, as well as a for >> `__attribute__((target("no-mma")))` Hi, I updated the case to test builtins used in previous Sema tests when both no-mma and no-paired-vector-memops. There's limitation that such codegen error message only diagnose one function, so I wrapped them into a single function. Not sure if that's the full meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143467/new/ https://reviews.llvm.org/D143467 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
