catenacyber added a comment.
Should I propose a simple patch to bump INSTR_PROF_RAW_VERSION ?
Or will it be part of something bigger, taken care of by someone else ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104556/new/
https://reviews.llvm.org
catenacyber added a comment.
Should we still bump `INSTR_PROF_RAW_VERSION ` so that we are able to
distinguish profraw files produced by clang13 and the ones produced by clang14 ?
Right now, both produce `LLVM raw profile data, version 7`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
catenacyber added a comment.
> Even if `INSTR_PROF_RAW_VERSION` is bumped, I think it is very likely your
> Rust downstream will observe an `if (GET_VERSION(Version) !=
> RawInstrProf::Version)` error in llvm-profdata,
> because from your description it seems you are likely mixing raw profile
>
catenacyber added a comment.
> .profraw are files with the raw profile format. The compiler-rt/lib/profile
> runtime and llvm-profdata only support one version at any commit.
Ok.
> Mixing .profraw files produced by different compiler-rt/lib/profile runtimes
> is unsupported.
I do not think I
catenacyber added a comment.
> Bump the raw profile format version to 6. (Last bump happened in 2019-10.)
This does not seem to be in the patch, ie no change of `INSTR_PROF_RAW_VERSION`
in compiler-rt/include/profile/InstrProfData.inc
Is that missing ?
Repository:
rG LLVM Github Monorepo
CH
catenacyber added a comment.
Thanks for the quick reply
> I don't think this change is responsible. This has been tested by many C++
> downstream groups.
What did I do wrong ?
Adding this only commit makes the scenario fail.
> Rust should use upgrade its lib/ProfileData and compiler-rt/lib/pro
catenacyber added a comment.
This commit has broken oss-fuzz workflow for rust projects.
I do not know if the fix is
https://reviews.llvm.org/rG66e2772e4285588ccc3bcdb5f392c8326debbd7d
Scenario is
export RUSTFLAGS="--cfg fuzzing -Cdebuginfo=1 -Cforce-frame-pointers
-Zinstrument-coverage -C l
