[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/lib/Driver/ToolChains/OHOS.h:38 + bool isPICDefaultForced() const override { return false; } + bool useRelaxRelocations() const override { return false; } + UnwindLibType GetUnwindLibTyp

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. So what are next steps? Are we going for implementation of `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? @dblaikie @aprantl @Michael137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true; Michael137 w

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 512945. kpdev42 added a comment. Thanks for pointing out the bug @Michael137 . It seems that clang assigns arbitrary offsets for non_unique_address so analyzing them brings me nowhere. In this patch I tried assigning no_unique_address to every empty structur

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { + clang::CXXRecordD

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { + clang::CXXRecordD

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511683. kpdev42 edited the summary of this revision. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files: lldb/so

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511362. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserC

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 507272. kpdev42 added a comment. Update patch after landing D145057 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files: lldb/s

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

This revision was automatically updated to reflect the committed changes. kpdev42 marked an inline comment as done. Closed by commit rG21cd04c46fe0: [clang][ASTImport] Add support for import of empty records (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 added a comment. In D145227#4192628 , @DavidSpickett wrote: > Also failing on our Windows on Arm bot: > https://lab.llvm.org/buildbot/#/builders/65/builds/8607 > > I think some lines need to account for Windows slashes, `{{/|}}` should > do

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG28997feb0c3a: [LLVM][OHOS] Clang toolchain and targets (authored by kpdev42). Herald added a subscriber: asb. Changed prior to commit: https://reviews.llvm.org/D145227?vs=504994&id=506511#toc Repositor

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72474afa2757: [LLVM][OHOS] Clang toolchain and targets (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:1171 + /// attribute + void markEmpty() { data().Empty = true; } balazske wrote: > This change looks not related. The `markEmpty` is still n

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 updated this revision to Diff 504956. kpdev42 marked an inline comment as done. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145057/new/ https://reviews.llvm.org/D145057 Files: clang/incl

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 updated this revision to Diff 504647. kpdev42 added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145227/new/ https://reviews.llvm.org/D145227 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Driver

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 updated this revision to Diff 504632. kpdev42 marked an inline comment as done. kpdev42 added a comment. Address review comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145227/new/ https://reviews.llvm.org/D145227 Files:

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked 2 inline comments as done. kpdev42 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:8161 +EXPECT_EQ(true, FD->hasAttr()); +} + balazske wrote: > Does this test fail without the changes applied? And does it not fail aft

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3897 + if (Err) +return std::move(Err); ToField->setAccess(D->getAccess()); balazske wrote: > I am not familiar with this use case, is there

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/test/Driver/ohos.c:240 + +// CHECK-OHOS-PTHREAD-NOT: -lpthread + DavidSpickett wrote: > This one is checking that we do not link to a pthread library, because when > using

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, echristo. kpdev42 added a project: LLVM. Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, s.egerton, ormris, cryptoad, simoncook, hiraditya, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a

[PATCH] D145057: [clang][ASTImport] Add support for import of empty records

kpdev42 created this revision. kpdev42 added reviewers: clayborg, balazske. kpdev42 added a project: LLVM. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. kpdev42 requested review of this revision. Herald added a project: clang. Herald added a subsc

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3896 + if (D->hasAttrs()) +ToField->setAttrs(D->getAttrs()); ToField->setAccess(D->getAccess()); balazske wrote: > The import of attributes is handled in function `ASTImporter::Impor

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, davide, clayborg, k8stone. kpdev42 added projects: LLVM, LLDB. Herald added subscribers: Michael137, JDevlieghere, martong. Herald added a reviewer: shafik. Herald added a reviewer: shafik. Herald added a project: All. kpdev42 r

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 updated this revision to Diff 432478. kpdev42 edited the summary of this revision. kpdev42 added a comment. Well, after some investigation it turned out that: 1. ARMv5 has DMB instruction in the form of mcr p15, #0, , c7, c10, #5 2. There is SWP instruction (deprecated on ARMv6), which do

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. At the moment, in case of compiler-rt, `__sync_add_and_fetch` boils down to `__sync_add_and_fetch_N`, where `N` is the size of data being fetched (4 for int). The implementation of `__sync_fetch_and_add_N` does approximately the following: 1. Sets memory barrier 2. Calls

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. In D116088#3393350 , @efriedma wrote: > D120026 is merged now, which addresses the > issue of the compiler generating __sync calls where it isn't supposed to. > > Does anyone want to continue di

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG910a642c0a5b: [compiler-rt] Implement ARM atomic operations for architectures without SMP… (authored by kpdev42). Repository: rG LLVM Github Mono

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. In D116088#3254400 , @joerg wrote: > Correct me if I'm wrong, but I don't think this stubs are async signal safe > nor will they work for preemptive multitasking systems? Those stubs are basically cas loops (https://en.wikipedi

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

kpdev42 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116088/new/ https://reviews.llvm.org/D116088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D112135: [ARM] Fix inline assembly referencing floating point registers on soft-float targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb9a0dc293cf: [ARM] Fix inline assembly referencing floating point registers on soft-float… (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D112135: [ARM] Fix inline assembly referencing floating point registers on soft-float targets

kpdev42 created this revision. kpdev42 added reviewers: dmgreen, thakis, dcandler, nickdesaulniers, LukeGeeson. kpdev42 added a project: LLVM. Herald added a subscriber: kristof.beyls. kpdev42 requested review of this revision. Herald added a project: clang. Fixes PR: https://bugs.llvm.org/show_bu

[PATCH] D84261: [PGO] Supporting code for always instrumenting entry block

kpdev42 added inline comments. Comment at: llvm/include/llvm/ProfileData/InstrProfData.inc:676 #define VARIANT_MASK_CSIR_PROF (0x1ULL << 57) +#define VARIANT_MASK_INSTR_ENTRY (0x1ULL << 58) #define INSTR_PROF_RAW_VERSION_VAR __llvm_profile_raw_version This revi