[PATCH] D158668: RFC: Add getLikelyBranchWeight helper function

paulkirth added a comment. In D158668#4611842 , @MatzeB wrote: >> My initial reaction to this was that we should keep the >> --unlikely-branch-weights flag available > > I don't feel strongly about it and can put it back. But can you give some > reasoni

[PATCH] D158668: Add getLikelyBranchWeight helper function

paulkirth added a comment. My initial reaction to this was that we should keep the `--unlikely-branch-weights` flag available, even if we decide to move forward with the other changes. but given that you haven't had to update many tests, I think its probably fine to go this way. Probably just a

[PATCH] D157781: [clang] Add cleanup_function field to CleanupAttr json AST dump

paulkirth added a comment. Hi, we're seeing a test failure in our CI after this stack. Not exactly sure which commit though. You can find the failing bot here: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8772753421607483249/overview Some test output fro

[PATCH] D155490: [clang][docs] Fix tag target name in link

paulkirth added a comment. In D155490#4507061 , @MaskRay wrote: > I find that `See patch` is used elsewhere. Does this change fix a sphinx bot? yes: https://lab.llvm.org/buildbot#builders/92/builds/47401 Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D155490: [clang][docs] Fix tag target name in link

paulkirth added a comment. yeah, I did `arc diff` w/o thinking about it, and then realized I should have just pushed immediately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155490/new/ https://reviews.llvm.org/D155490 __

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. Small forward fix for the documentation in D155490 . If something else crops up I can revert both and reland. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.l

[PATCH] D155490: [clang][docs] Fix tag target name in link

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5784c47806cf: [clang][docs] Fix tag target name in link (authored

[PATCH] D155490: [clang][docs] Fix tag target name in link

paulkirth created this revision. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `see patch` tag conflicted w/ one later in the document. Changing the text should fix the documentation build error.

[PATCH] D146777: [clang] Preliminary fat-lto-object support

This revision was automatically updated to reflect the committed changes. Closed by commit rG610fc5cbcc8b: [clang] Preliminary fat-lto-object support (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 540559. paulkirth marked an inline comment as done. paulkirth edited the summary of this revision. paulkirth added a comment. Revise tests + update summary - Add driver tests for -S - Add codegen tests for -S - Test Unified LTO codegen - Use -fdriver-only t

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4733 + types::ID Output; + if (Args.hasArg(options::OPT_S)) +Output = types::TY_LTO_IR; MaskRay wrote: > This part is not tested. oh, feel free to disregard my Q about `-S

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4499608 , @MaskRay wrote: > Thanks for the update. Can you add a comment for the `-funified-lto` > combination? It's unclear what it does... ugh, I had put comments above each compiler invocation, but forgot that

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 540192. paulkirth marked an inline comment as done. paulkirth edited the summary of this revision. paulkirth added a comment. Update summary w/ instructions for using `-ffat-lto-objects` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 539584. paulkirth added a comment. Use `--` for LLD options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 539346. paulkirth added a comment. Rebase and try to accomodate Unified LTO changes. Based on the Unified LTO patches, I think this is the correct handling for FatLTO, but I'd like to get a second opinion before landing this. CC: @ormris Repository: rG

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added a comment. In D146777#4457209 , @MaskRay wrote: > As mentioned, you may consider landing llvm patch then wait a bit so that (a) > people can experiment with the clang patch better (b) prevent the llvm/clang > patches to be both reverted,

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 535472. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/include/clang/Driver/Options.td:2311 MarshallingInfoString>; +defm fat_lto_objects : BoolFOption<"fat-lto-objects", + CodeGenOpts<"FatLTO">, DefaultFalse, MaskRay wrote: > We just need the pos flag for CC1Opt

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 533433. paulkirth marked 12 inline comments as done. paulkirth added a comment. Rebase and address comments - Update & rename tests - Fix typos - Handle options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

paulkirth accepted this revision. paulkirth added a comment. Herald added a subscriber: wangpc. Also LGTM for the changes in MisExpect.rst, modulo feedback from @erichkeane. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151963/new/ https://reviews.

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: clang/test/Driver/fatlto.c:1 + tejohnson wrote: > Is this empty file meant to contain something? No, this was just a mistake in my commit. I had the linker checks in another

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 532272. paulkirth added a comment. Rebase and fix run line in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 532212. paulkirth marked an inline comment as done. paulkirth added a comment. Rebase, address comments, and add missing test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.l

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1065 + if (CodeGenOpts.FatLTO) { +// Set EnableSplitLTOUnit, since the config above won't +if (!TheModule->getModuleFlag("EnableSplitLTOUnit")) tejohnson wrote: > Can you expa

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 531534. paulkirth added a comment. Rebase and pass fat-lto-objects to LLD from clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNot

[PATCH] D152804: [clang-format] Propose a new solution to - Fix overlapping replacements before PPDirectives

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. Thanks for looking into this. LGTM from me. I'll keep an eye on our CI when this lands and let you know if we encounter any problems. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth marked an inline comment as done. paulkirth added a comment. In D152473#4410331 , @MyDeveloperDay wrote: > My additional concern is, is the original patch is the root cause of the > regression?, so I’m struggling to understand why this in part

[PATCH] D152584: [clang-format] Remove redundant test case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa28a46665529: [clang-format] Remove redundant test case (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152584: [clang-format] Remove redundant test case

paulkirth created this revision. paulkirth added reviewers: owenpan, MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks. paulkirth requested review of this revision. Herald added a comment. NOT

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. In D152473#4409975 , @MyDeveloperDay wrote: > In D152473#4409146 , @paulkirth > wrote: > >> The point of this patch was to show a regression. I'm not trying to fix >> anything per se.

[PATCH] D152473: [clang-format] Add test case for issue 63170

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6a718016c0f: [clang-format] Add test case for issue 63170 (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth updated this revision to Diff 530004. paulkirth edited the summary of this revision. paulkirth added reverted changes: rGd2627cf88d25: [clang-format] Add the KeepEmptyLinesAtEOF option, rG4b9764959dc4: [clang-format] Fix overlapping replacements before PPDirectives, D152305: [clang-form

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth updated this revision to Diff 52. paulkirth added a comment. Revert patches introducing regression & add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152473/new/ https://reviews.llvm.org/D152473 Files: clang/docs/ClangFo

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. The point of this patch was to show a regression. I'm not trying to fix anything per se. I'd like https://reviews.llvm.org/D151954 and anything that depends on it reverted, since it breaks `clang-format`. My understanding was that @owenpan was reluctant to revert sin

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. In D152473#4407832 , @owenpan wrote: > Can you add the test to clang/unittests/Format/FormatTest.cpp instead? Please > also include the full diff. See > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-in

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth created this revision. paulkirth added a reviewer: owenpan. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. paulkirth requested review of this revision. Herald added a comment. NO

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. I'd also suggest reverting this until it can be fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151954/new/ https://reviews.llvm.org/D151954 ___ cfe-commits mailing list cf

[PATCH] D151954: [clang-format] Fix overlapping whitespace replacements before PPDirective

paulkirth added a comment. This patch seems to introduce some significant regressions to formatting. I've filed https://github.com/llvm/llvm-project/issues/63170 with some candidate code. I'll try to reduce the case as I can, but I'm guessing something is incorrect w/ how the indentation level

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 527075. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenO

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 525902. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61976af3ba93: [clang][driver] Enable MisExpect diagnostics flag outside of CC1 (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 517706. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 517416. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenO

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth added inline comments. Comment at: clang/test/Driver/clang_f_opts.c:144 +// RUN: %clang -### -S -fprofile-instr-use=%t.profdata -fdiagnostics-misexpect-tolerance=10 -Wmisexpect %s 2>&1 | FileCheck %s --check-prefix=CHECK-MISEXPECT-TOLLERANCE +// CHECK-MISEXPECT-TOLLER

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth updated this revision to Diff 517243. paulkirth marked an inline comment as done. paulkirth added a comment. Update test to check if the flag is in cc1, instead of just looking for a warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. In D146987#4299353 , @Orlando wrote: > In D146987#4299081 , @paulkirth > wrote: > >> @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI >> that reverted the ch

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth updated this revision to Diff 517199. paulkirth added a comment. Migrate to a Driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149206/new/ https://reviews.llvm.org/D149206 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/t

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC1

paulkirth added inline comments. Comment at: clang/test/Profile/misexpect-branch.c:10 // RUN: %clang_cc1 %s -O2 -o - -emit-llvm -fprofile-instrument-use-path=%t.profdata -verify=foo -fdiagnostics-misexpect-tolerance=10 -Wmisexpect -debug-info-kind=line-tables-only +// RUN: %c

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI that reverted the change that disabled this as default and tried it for x86. It looks like this patch is working OK for us now: https://ci.chromium.org/raw/build/logs.chromium.org/fuchsia/led/

[PATCH] D149206: [clang][driver] Enable MisExpect diagnostics flag outside of CC!

paulkirth created this revision. paulkirth added reviewers: hans, tejohnson, phosek. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously we only accepted the `-fdiagnostics-misexpect-tol

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. In D115907#4296154 , @hans wrote: > In D115907#4295923 , @paulkirth > wrote: > >>> 2. Due to inlining etc., it often gets the source locations wrong, which >>> means it points at code

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. Thanks for the report Hans. In D115907#4295363 , @hans wrote: > We gave this a try in Chromium: > https://bugs.chromium.org/p/chromium/issues/detail?id=1434989 > > While the diagnostics are interesting, two things make this le

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth abandoned this revision. paulkirth added a comment. This can be abandoned in favor of https://reviews.llvm.org/D146776, https://reviews.llvm.org/D146777, and https://reviews.llvm.org/D146778 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 515910. paulkirth added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/CodeGenOp

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 515880. paulkirth added a comment. Add relese note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. Here are reduced cases. I didn't bother bisecting flags, but the test case is quite small F27199288: clang-crashreports.zip struct a {}; struct b { struct b *c; struct b *d; }; _Bool e; inline void g(struct b *p1)

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

paulkirth added a comment. Sorry, I missed that this was already reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140722/new/ https://reviews.llvm.org/D140722 ___ cfe-commits mailing list cfe-comm

[PATCH] D140722: [OpenMP] Prefix outlined and reduction func names with original func's name

paulkirth added a comment. I'm seeing some test failures in our CI: Clang :: OpenMP/parallel_masked.cpp Clang :: OpenMP/parallel_masked_target.cpp Bot: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64-rbe/b8783369579855138017/overview If this will be hard to fix, can

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. Here are the reproducers, though I haven't reduced them yet. F27193433: clang-crashreports.zip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D1469

[PATCH] D146987: [Assignment Tracking] Enable by default

paulkirth added a comment. I think we may have an issue due to this. I'm basing that on the blamelist, but I'm still bisecting our build, which may take some time to confirm. Can you take a look, and revert if it's not a quick fix? FAILED: obj/third_party/mesa/src/compiler/nir/nir.nir_opt_uni

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514432. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514430. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 514331. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 513766. paulkirth added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146777/new/ https://reviews.llvm.org/D146777 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/cla

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa1d2693c256: [CodeGen][RISCV] Change Shadow Call Stack Register to X3 (authored by paulkirth). Changed prior to commit: https://reviews.llvm.org/D146463?vs=512489&id=512972#toc Repository: rG LLVM G

[PATCH] D148031: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG723f7d3a0891: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D148034: [clang][driver] Disable GP relaxation with RISC-V ShadowCallStack

paulkirth created this revision. paulkirth added reviewers: phosek, mcgrathr, jrtc27, craig.topper, aaron.ballman. Herald added subscribers: VincentWu, vkmr, luismarques, sameer.abuasal, s.egerton, Jim, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, asb, arichardson. Herald added a project: A

[PATCH] D148031: [clang][driver][NFC] Add hasShadowCallStack to SanitizerArgs

paulkirth created this revision. paulkirth added reviewers: phosek, abrachet, dvyukov, vitalybuka, aaron.ballman. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, we can't check if ShadowCall

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512489. paulkirth marked 2 inline comments as done. paulkirth added a comment. Add spaces to parantheticals. Shorten link to discussion on psABI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ http

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512277. paulkirth added a comment. Remove dead declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/docs/ShadowCallStack.rst clang/lib/Driv

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:573 + Kinds & SanitizerKind::ShadowCallStack) + << "-msmall-data-limit=0"; +} jrtc27 wrote: > jrtc27 wrote: > > paulkirth wrote: > > > jrt

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 512276. paulkirth marked 7 inline comments as done. paulkirth added a comment. Remove `-msmall-data-limit` related changes. There was a misunderstanding on my part about default linker behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:307 +bool shadowCallStackDSLConflicts(const llvm::opt::ArgList &Args, + const llvm::Triple &TT) { mcgrathr wrote: > I'm guessing that "DSL" stands fo

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. @asb Are we happy with the state of consensus w.r.t. using `x3`? I think the lingering concerns from the psABI discussion have been resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llv

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa78816a6b6de: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode (authored by paulkirth). Repository: rG LLVM Github Monorepo

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth updated this revision to Diff 512190. paulkirth added a comment. Remove extra newlines in emulated-tls.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147834/new/ https://reviews.llvm.org/D147834 Files: clang/lib/Driver/ToolChains/Co

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth added inline comments. Comment at: clang/test/Driver/emulated-tls.cpp:57 +// LTO related checks +//LTO_NOEMUTLS: plugin-opt=-emulated-tls=0 +//LTO_NOEMUTLS-NOT: plugin-opt=-emulated-tls=1 vit9696 wrote: > Maybe add a space before LTO here? Good catch. F

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth updated this revision to Diff 512189. paulkirth marked an inline comment as done. paulkirth added a comment. Fix formatting in CHECK lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147834/new/ https://reviews.llvm.org/D147834 Files:

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth created this revision. paulkirth added reviewers: phosek, MaskRay, enh, hiraditya, vit9696. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, asb, arichardson, inglorion. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers:

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511704. paulkirth marked an inline comment as done. paulkirth added a comment. Remove unrelated whitespace changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511575. paulkirth marked an inline comment as done. paulkirth added a comment. Add default small-data-limit for Android and Fuchsia. - update tests - update clang driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511466. paulkirth marked 2 inline comments as done. paulkirth added a comment. Remove extra line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/doc

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 511458. paulkirth added a comment. Fix formatting and update documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/docs/ShadowCallStack.rst

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. whe Comment at: clang/lib/Driver/SanitizerArgs.cpp:546 - if ((Kinds & SanitizerKind::ShadowCallStack) && - ((TC.getTriple().isAArch64() && -!llvm::AArch64::isX18ReservedByDefault(TC.getTriple())) || - (TC.getTriple().isRISCV() &&

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth added a comment. @asb, @craig.topper, @jrtc27 Are there any remaining considerations for us here? From the discussions in psABI and sig-toolchain, I think we have a consensus that this is the approach we'll be taking for RISC-V. We'd prefer to correct this ASAP, so as to prevent futu

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 509811. paulkirth added a comment. Remove blank lines added to test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cp

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to X3

paulkirth updated this revision to Diff 509508. paulkirth retitled this revision from "[CodeGen][RISCV] Change Shadow Call Stack Register to S11" to "[CodeGen][RISCV] Change Shadow Call Stack Register to X3". paulkirth edited the summary of this revision. paulkirth added a comment. update to use

[PATCH] D146777: [clang] Preliminary fat-lto-object support

paulkirth updated this revision to Diff 508773. paulkirth retitled this revision from "[clang] Preliminary fat-lot-object support" to "[clang] Preliminary fat-lto-object support". paulkirth added a comment. Herald added a subscriber: inglorion. Fix typo in title Repository: rG LLVM Github Mon

[PATCH] D131618: [clang][llvm][lld] FatLTO Prototype

paulkirth added a comment. I've split this into smaller patch sets by project: LLVM: https://reviews.llvm.org/D146776 Clang: https://reviews.llvm.org/D146777 LLD: https://reviews.llvm.org/D146778 If we're happy with that, then we can probably abandon this revision in favor of those. Repositor

[PATCH] D146777: [clang] Preliminary fat-lot-object support

paulkirth created this revision. paulkirth added reviewers: phosek, tejohnson, MaskRay, alexander-shaposhnikov. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a project: All. paulkirth requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507811. paulkirth added a comment. Restore check lines in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cpp compil

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507805. paulkirth added a comment. Remove unrelated changes, due to bad commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerA

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth added a comment. ugh. I accidentally commited some temporary work here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 ___ cfe-commits mailing list c

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507801. paulkirth added a comment. Address comments. - Remove `.` from warning message - use `;;` prefix in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Fi

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 507048. paulkirth added a comment. Split out save/restore tests for SCS into its own file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth added inline comments. Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:184 + +; RUN: llc -mtriple=riscv32 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV32I +; RUN: llc -mtriple=riscv64 -mattr=+reserve-x27 < %s | FileCheck %s -check-prefix=RV64I --

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 506790. paulkirth added a comment. Remove outdated diagnostics and add tests for SCS + save/restore. I'm not 100% on if this is the right approach for save/restore testing, so I'm hapy to back this bit out or add more cases. Repository: rG LLVM Github

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth marked an inline comment as done. paulkirth added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { craig.topper wrote: > paulkirth wrote: > > cr

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth marked 2 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:58 const auto *RVFI = MF.getInfo(); if (RVFI->useSaveRestoreLibCalls(MF)) { craig.topper wrote: > Can you add a FIXME her

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

paulkirth updated this revision to Diff 506762. paulkirth added a comment. Fix comment and add `FIXME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 Files: clang/lib/Driver/SanitizerArgs.cpp compile

  1   2   3   4   >