[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas added a comment. Hi, if this patch still LGTY, could you commit it on my behalf? I don't have commit access. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mail

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 231615. nicolas added a comment. Update the comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Type.h clang/lib/AST/ASTContext.cpp c

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 231604. nicolas added a comment. Hi @mordante, thanks for the interest. Here's an updated patch that addresses @aaron.ballman's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/includ

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 212061. nicolas added a comment. Add a default value for `FunctionProtoType::getEllipsisLoc` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 212055. nicolas edited the summary of this revision. nicolas added a comment. - `getEllipsisSourceRange` -> `getEllipsisLoc` - Updated the doc comment - Removed `auto` where necessary CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 211849. nicolas edited the summary of this revision. nicolas added a comment. I added the SourceLocation of the ellipsis to `FunctionProtoType` in addition to the `Variadic` boolean. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas marked an inline comment as done. nicolas added inline comments. Comment at: clang/include/clang/AST/Decl.h:2331 + /// Attempt to compute an informative source range covering the + /// function parameters. This omits the ellipsis of a variadic function. + SourceRange g

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas updated this revision to Diff 206446. nicolas added a comment. - Added tests of instance and static functions - Added tests of parameters with cv qualifiers - Added tests of parameters with attributes - Removed `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ http

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas created this revision. nicolas added reviewers: rsmith, steveire. Herald added a project: clang. Herald added a subscriber: cfe-commits. This source range covers the list of parameters of the function declaration. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63276 Fi

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas added a comment. Yes, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas updated this revision to Diff 193288. nicolas retitled this revision from "Add const children() accessors to Stmts" to "Add const children() accessors to all AST nodes.". nicolas edited the summary of this revision. nicolas added a comment. Added children() const to all AST nodes. CHANG

[PATCH] D60128: Add const children accessors to all nodes.

nicolas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add const children accessors to all AST nodes where non const accessors exist. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60128 Files: clang/include/clang/AST/Expr.h c

[PATCH] D60029: Add const children() accessors to Stmts

nicolas added a comment. In D60029#1448938 , @riccibruno wrote: > Did you go over all the statements on `Stmt.h` systematically ? Yes. > You could also do the same thing for all of the statements/expressions in > `StmtCXX.h`, `Expr.h`, `ExprCXX.h`, and

[PATCH] D60029: Add const children() accessors to Stmts

nicolas created this revision. nicolas added reviewers: bkramer, rsmith. nicolas added a project: clang. Herald added a subscriber: cfe-commits. Exprs already have children() const but not Stmts. All the changes are very simple, except for `DeclStmt` where I used a `const_cast`. Repository: r