[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

2025-07-03 Thread Mythreya Kuricheti via cfe-commits
@@ -1,14 +1,42 @@ struct A { - void foo(this A self, int arg); + void foo(this auto&& self, int arg); + void bar(this A self, int arg); }; -int main() { +int func1() { A a {}; a. } -// RUN: %clang_cc1 -cc1 -fsyntax-only -code-completion-at=%s:%(line-2):5 -std=c++23

[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

2025-07-03 Thread Mythreya Kuricheti via cfe-commits
MythreyaK wrote: The completion for `(&A::foo2)` is just `(A, int)`, not `foo(A, int)`. I tried to add a test case, like in this [godbolt](https://godbolt.org/z/77zE7e3oE) example, ```cpp struct A { void foo1(this A self, int arg) {} template void foo2(this T&& self, int arg, flo

[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

2025-07-03 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/146649 >From 7f8581f01c3c25363b77100635c6df7223badba3 Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Wed, 2 Jul 2025 01:26:25 -0700 Subject: [PATCH 1/2] [clang][CodeComplete] skip explicit obj param in Sign

[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

2025-07-02 Thread Mythreya Kuricheti via cfe-commits
MythreyaK wrote: Seems to be working as expected. I'll add a test case for this as well. ![image](https://github.com/user-attachments/assets/f736c68f-a64d-4af6-876a-d647d0d6541e) ![image](https://github.com/user-attachments/assets/e40ee898-a161-4564-869c-b566e7b3452b) https://github.com/llvm/

[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

2025-07-02 Thread Mythreya Kuricheti via cfe-commits
MythreyaK wrote: > How does completion handle things like this? @cor3ntin Oh I totally forgot about this! Thanks! I'll check it in the evening. https://github.com/llvm/llvm-project/pull/146649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

2025-07-02 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK edited https://github.com/llvm/llvm-project/pull/146649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][CodeComplete] skip explicit obj param in SignatureHelp (PR #146649)

2025-07-02 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/146649 >From 7f8581f01c3c25363b77100635c6df7223badba3 Mon Sep 17 00:00:00 2001 From: Mythreya Kuricheti Date: Wed, 2 Jul 2025 01:26:25 -0700 Subject: [PATCH] [clang][CodeComplete] skip explicit obj param in Signatur