[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

goncharov added a comment. due to this change we have a enourmous number of new warnings, on the other hand -Wunused-variable is a valuable warning. I am not sure what is the policy and best practices for warnings but maybe there is a possiblity to make a transition period for enabling this typ

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

goncharov added a comment. there is a number of unused vaiables in conditional loops there are firing now, I have submitted https://github.com/llvm/llvm-project/commit/74f4daef0412be33002bd4e24a30cb47d0187ecf but I suspect it's just a start. How did you checked the project code for that? Rep

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

goncharov added inline comments. Comment at: .ci/generate-buildkite-pipeline-premerge:163 + +if [[ ! ${SPECIFIC_PIPELINE_AVAILABLE} -eq 1 ]]; then + # Figure out which projects need to be built on each platform ldionne wrote: > goncharov wrote: > > do I understa

[PATCH] D152265: [clang][test] Use a physical copy of FS

goncharov accepted this revision. goncharov added a comment. This revision is now accepted and ready to land. nice Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152265/new/ https://reviews.llvm.org/D152265 _

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

goncharov added a comment. In D135220#3840354 , @benlangmuir wrote: > Okay, I was able to reproduce by symlinking all the 0-byte header files to > header0 (any choice probably works). The behaviour is deterministic before > and after my change. > > Th

[PATCH] D135373: [clang][test] Make headers unique to avoid linking issues

goncharov accepted this revision. goncharov added a comment. This revision is now accepted and ready to land. thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135373/new/ https://reviews.llvm.org/D135373 ___

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

goncharov added a comment. In D135220#3840177 , @dexonsmith wrote: > In D135220#3839671 , @goncharov > wrote: > >> That change might be problematic for content addressing storages. E.g. >> clang/test/Driver/cl-

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

goncharov added subscribers: dexonsmith, goncharov. goncharov added a comment. That change might be problematic for content addressing storages. E.g. clang/test/Driver/cl-pch-showincludes.cpp started to fail as clang/test/Driver/header{0,1,3,4}.h are all identical and can be symlinked. cc @dexo

[PATCH] D122471: [IR] Require intrinsic struct return type to be anonymous

goncharov added a comment. Hi, I have found this test to cs-preinline-sample-profile.test to be flaky around 10% of the runs. Could you please check what might be the issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122471/new/ https://reviews

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

goncharov added a comment. Sorry, had to revert it as this fails under sanitizer : https://lab.llvm.org/buildbot/#/builders/5/builds/8150 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 _

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

goncharov added a comment. I have relanded this in https://github.com/llvm/llvm-project/commit/3b148d6f991181a1b8f089c4bc2126e1a6c1212d . My apologies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://reviews.llvm.org/D96665 _

[PATCH] D96665: Revert "Implement nullPointerConstant() using a better API."

goncharov added a comment. Hi @steveire! Sorry but I reverted this revert. Could you please give some context of "discussed elsewhere" and "pre-existing unit test for the matcher"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96665/new/ https://r

[PATCH] D90673: yet another commit

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. goncharov requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90673 Files: clang-tools-extra/docs/new_file.txt Index: clang-tools-extra/docs/

[PATCH] D90618: chained diff

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. goncharov requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90618 Files: clang-tools-extra/docs/new_file.txt Index: clang-tools-extra/docs/

[PATCH] D90389: Test commit, please ignore

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. goncharov requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90389 Files: clang-tools-extra/docs/new_file.txt Index: clang-tools-extra/docs/

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

goncharov added a comment. In D81408#2105188 , @atrosinenko wrote: > @goncharov > > Meanwhile, looking at the latest Buildkite build > for this > review, we have: > > name=artifacts/CMakeCac

[PATCH] D81086: buildkite is open for beta

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81086

[PATCH] D80509: buildkite test 2

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80509

[PATCH] D79412: buildkite test

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79412 Files: clang-tools-extra/clangd/RIFF.cpp Index: clang-tools-extra/clangd/RIFF.c

[PATCH] D73265: header file warning

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. warning in a header Repository: rG LLVM Github Monorepo https://r

[PATCH] D71661: I broke clangd

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. goncharov removed subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM

[PATCH] D71594: testing clang-tidy

goncharov added a comment. In D71594#1788194 , @Eugene.Zelenko wrote: > Where set of Clang-tidy checks come from? .clang-tidy? Could stricter set of > custom rules be used? Yes, clang-tidy uses the .clang-tidy. Do you want to enable additional rules f

[PATCH] D71594: testing clang-tidy

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71594

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . {icon times-circle color=red} clang-format: fail. Please format your changes

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch .

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch .

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch .

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-format: pass. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . Build artifacts

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233554. goncharov added a comment. add header guards back Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang-tools-extra/clangd/Function.h clang/include

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233530. goncharov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang-tools-extra/clangd/Function.h clang/include/clang/Analysis/

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233383. goncharov added a comment. Herald added subscribers: kadircet, jkorous. more violations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang-tools-e

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233380. goncharov added a comment. header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/include/clang/Analysis/AnalysisDeclContext.h clang/tools/cl

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233376. goncharov added a comment. namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-check/ClangCheck.cpp clang/tools/clang-diff

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233370. goncharov added a comment. wrong imports order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-check/ClangCheck.cpp clang/tools/c

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233310. goncharov added a comment. trigger the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-check/ClangCheck.cpp clang/tools/cla

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon times-circle color=red} Unit tests: fail. 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_en

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon times-circle color=red} Unit tests: fail.60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_ent

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Unit tests: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/assig

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Build artifacts : test-results.xml , clang-format.patch

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Please format your changes with clang-format by running `git-clang-format HEAD^` or apply this patch . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ h

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: SUCCESS - Build artifacts : clang-format.patch , CMakeCache.txt Repository: rG LLVM Github Monorep

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. test `code` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: SUCCESS - Build artifacts :clang-format.patch , CMakeCache.txt Repository: rG LLVM Github Monorepo

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233029. goncharov added a comment. update clang diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp clang/tools/clang

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: pass - 0 tests passed, 0 failed and 0 were skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mai

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233020. goncharov added a comment. more files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp clang/tools/clang-fuzzer

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: fail - 60594 tests passed, 30 failed and 726 were skipped. failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_cons/path.pass.cpp failed: libc++.std/input_output/filesystems/class_directory_entry/directory_entry_mods/ass

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. Build result: SUCCESS - Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 232813. goncharov added a comment. Trigger the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp Index: clang/tool

[PATCH] D71197: llvm premerge: clang format test

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71197 Files: clang/tools/clang-diff/ClangDiff.cpp Index: clang/tools/clang-diff/ClangDiff.cpp ==

[PATCH] D58545: fix the message

goncharov created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. please ignore Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58545 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/SemaCXX/warn-infinite-recursion.cpp