goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang.
Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79412 Files: clang-tools-extra/clangd/RIFF.cpp Index: clang-tools-extra/clangd/RIFF.cpp =================================================================== --- clang-tools-extra/clangd/RIFF.cpp +++ clang-tools-extra/clangd/RIFF.cpp @@ -18,9 +18,9 @@ } llvm::Expected<Chunk> readChunk(llvm::StringRef &Stream) { + Chunk C; if (Stream.size() < 8) return makeError("incomplete chunk header"); - Chunk C; std::copy(Stream.begin(), Stream.begin() + 4, C.ID.begin()); Stream = Stream.drop_front(4); uint32_t Len = llvm::support::endian::read32le(Stream.take_front(4).begin());
Index: clang-tools-extra/clangd/RIFF.cpp =================================================================== --- clang-tools-extra/clangd/RIFF.cpp +++ clang-tools-extra/clangd/RIFF.cpp @@ -18,9 +18,9 @@ } llvm::Expected<Chunk> readChunk(llvm::StringRef &Stream) { + Chunk C; if (Stream.size() < 8) return makeError("incomplete chunk header"); - Chunk C; std::copy(Stream.begin(), Stream.begin() + 4, C.ID.begin()); Stream = Stream.drop_front(4); uint32_t Len = llvm::support::endian::read32le(Stream.take_front(4).begin());
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits