[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost added a comment. In that case, when someone has free time, could you commit on my behalf (name: Micah Weston, email: micahswes...@gmail.com). Thank you all for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139801/new/ ht

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost added a comment. In D139801#3988790 , @HazardyKnusperkeks wrote: > If only the first, I'd say we do that without adding this option. I'll work on doing this without adding the option. (Just reread and noticed you had answered what I asked

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost added a comment. I would always want it first. I agree that `friend` would always go first. Had I not accidentally typed in the wrong order I probably wouldn't have know `friend` could be in any position. In the case of putting `friend` always first, would we want a user facing op

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost created this revision. red1bluelost added a reviewer: MyDeveloperDay. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. For cases of defining friend functions, qualifier ordering can allow multiple positions for the 'friend' to

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost marked an inline comment as done. red1bluelost added a comment. I noticed that the Premerge seemed ran into an issue with 'InsertBraces'. It looks to me that it is unrelated and probably due to the pre-merge machine using a pre-15 clang-format (I ran into similar issue on my local m

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost marked an inline comment as done. red1bluelost added a comment. Made a GitHub issue and addressed the current comments. :) Comment at: clang/lib/Format/TokenAnnotator.cpp:2355 +NextToken->isOneOf(tok::arrow, tok::equal, tok::kw_noexcept, tok::comma, +

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost updated this revision to Diff 474615. red1bluelost added a comment. Adds tests for the TokenAnnotator as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137755/new/ https://reviews.llvm.org/D137755 Files: clang/lib/Format/TokenA

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost created this revision. red1bluelost added a reviewer: curdeius. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ran into an issue where function declarations inside function scopes or u

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost marked an inline comment as done. red1bluelost added a comment. If that's all good, could you commit on my behalf. Here is name and email: Micah Weston (micahswes...@gmail.com) Thanks for the great reviews! It was really helpful with learning the frontend stuff. Repository: rG

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 427627. red1bluelost marked 2 inline comments as done. red1bluelost added a comment. Addresses the last couple comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/new/ https://reviews.llvm.org/D

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113-114 by unary operators. +- ``-Wenum-conversion`` now warns on conversion of signed enum to unsigned enum + and unsigned enum to signed enum rather than ``-Wsign-conversion``. aa

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 426804. red1bluelost marked 4 inline comments as done. red1bluelost added a comment. Addresses comments to improve wording and remove unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/n

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 426786. red1bluelost added a comment. Adds regression tests for enum to int sign conversion warnings and notes the changes in the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123009/new/ ht

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost marked 3 inline comments as done. red1bluelost added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:13555-13557 +DiagnoseImpCast(S, E, T, CC, DiagID); +if (!isa(Target) || !isa(Source)) + return; aaron.ballman wrote: > I do

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost updated this revision to Diff 424053. red1bluelost added a comment. Updates patch based on comments. Silences the sign conversions on enum-to-enum so that only enum-to-enum will warn. Simplifies the test case since now only one warning occurs. Repository: rG LLVM Github Monorepo

[PATCH] D123009: [Sema] Enum conversion warning when one signed and other unsigned.

red1bluelost created this revision. red1bluelost added reviewers: rsmith, lebedev.ri, aaron.ballman. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. Ensures an -Wenum-conversion warning happens when one of the enums is signed and the othe