red1bluelost marked an inline comment as done. red1bluelost added a comment.
Made a GitHub issue and addressed the current comments. :) ================ Comment at: clang/lib/Format/TokenAnnotator.cpp:2355 + NextToken->isOneOf(tok::arrow, tok::equal, tok::kw_noexcept, tok::comma, + tok::r_paren) || NextToken->canBePointerOrReferenceQualifier() || ---------------- MyDeveloperDay wrote: > nowadays we add a TokenAnnotator test (they are very easy to write), this > lets us ensure its getting annotated correctly. (which is really the bug > here), > > but your tests below are great too!. Thanks for the suggestion! Didn't realize there were tests for the tokenizer. I got those added now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137755/new/ https://reviews.llvm.org/D137755 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits