[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rGba7a1d9e4aec: [Driver] move FreeBSD header search path management to the driver (authored by mhjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13818

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476336. mhjacobson added a comment. Make the tests play nice with Windows path separators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Drive

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476320. mhjacobson added a comment. Herald added a subscriber: mstorsjo. Style fixes. Ensure include paths are sequential. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476042. mhjacobson added a comment. Fix a couple warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476031. mhjacobson added a comment. Test for more paths; test C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson added inline comments. Comment at: clang/test/Driver/freebsd.c:217 + +// Check that the driver passes include paths to cc1 on FreeBSD. +// RUN: %clang -### %s --target=x86_64-unknown-freebsd13.1 -r 2>&1 \ MaskRay wrote: > Is this sufficient? For Linux

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson added inline comments. Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:442 + + addExternCSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/include")); MaskRay wrote: > I think Fuchsia way of checking `if (!D.Sys

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476018. mhjacobson added a comment. Clarify comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/lib/D

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476017. mhjacobson added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/lib/

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476009. mhjacobson added a comment. Herald added a subscriber: ormris. Added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolCh

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson created this revision. mhjacobson added a project: clang. Herald added subscribers: fedor.sergeev, krytarowski, emaste. Herald added a project: All. mhjacobson requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. This matches OpenBSD, and it supports Swift'

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdd9f7963e434: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is… (authored by mhjacobson). C

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson added a comment. Hello, and sorry for the delay. The blocking bug was fixed by D112113 . This is ready for review. Please let me know if you have any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D136575: [Headers] remove define of _GNU_SOURCE when including Darwin's unwind.h

mhjacobson created this revision. mhjacobson added a reviewer: chandlerc. Herald added a project: All. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Darwin's unwind.h has never surrounded declarations with _GNU_SOURCE guards. T

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson updated this revision to Diff 451085. Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112049/new/ https://reviews.llvm.org/D112049 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGObjC.cpp clang/lib

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc8b2f3f51bd9: [ObjC] type method metadata `_imp`, messenger routine at callsite with program… (authored by mhjacobson). Herald added a project: All.

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

mhjacobson added a comment. Happy new year! If this change is acceptable, could someone please merge it for me? (And if not, could someone point out what needs more work?) Thanks for your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1121

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

mhjacobson added a comment. Well, I'm hoping it doesn't prove to be //too// much work. 🙂 With this fix and D112049 , most things are working quite well, though I'm sure I'll uncover more interesting things as I go. As for the runtime, I've built my own: https

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

mhjacobson added a comment. Ping. Is there anyone more suited to reviewing this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112113/new/ https://reviews.llvm.org/D112113 ___ cfe-commits mailing

[PATCH] D112113: [ObjC] type method metadata `_imp`, messenger routine at callsite with program address space

mhjacobson created this revision. mhjacobson added reviewers: rjmccall, ddunbar. Herald added subscribers: pengfei, Jim, dylanmckay. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On targets with non-default program address spac

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson added a comment. The test is failing for a different reason (that I'd forgotten I worked around locally). I'll look into fixing that first. Sorry for noise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112049/new/ https://reviews.llv

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson created this revision. mhjacobson added reviewers: rjmccall, ddunbar. Herald added subscribers: Jim, dylanmckay. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On targets where `ptrdiff_t` is smaller than `long`, clan

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added a comment. In D107684#2936033 , @MaskRay wrote: > `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect. > > sysroot is usually a directory which contains `usr/lib` and `lib/`. > `somewhere/usr/lib` is not usually used as a sysroo

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson updated this revision to Diff 365343. mhjacobson added a comment. Rebase atop recent changes; use separate check lines and string substitution for `SYSROOT`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

mhjacobson added a comment. In D107682#2932685 , @benshi001 wrote: > In D107682#2932607 , @mhjacobson > wrote: > >> For other examples of using four `..`s, look in `Gnu.cpp`, where there are >> several places wh

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added inline comments. Comment at: clang/test/Driver/avr-toolchain.c:17 +// RUN: %clang %s -### -no-canonical-prefixes -target avr --sysroot %S/Inputs/basic_avr_tree/usr/lib 2>&1 | FileCheck -check-prefix CC1D %s +// CC1D: clang{{.*}} "-cc1" "-triple" "avr" {{.*}} "-i

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added a comment. In D107684#2932609 , @benshi001 wrote: > In D107684#2932605 , @mhjacobson > wrote: > >> In D107684#2932603 , @benshi001 >> wrote: >> >>> We n

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson updated this revision to Diff 364942. mhjacobson added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.org/D107684 Files: clang/test/Driver/avr-toolchain.c Index: clang/test/Driver

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

mhjacobson added a comment. For other examples of using four `..`s, look in `Gnu.cpp`, where there are several places where `getParentLibPath()` is appended with `/../`. `AddMultilibPaths()`, `PushPPaths()`. `getParentLibPath()`, in turn, is `GCCInstallPath/../../../` CHANGES SINCE LAST ACTI

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson added a comment. In D107684#2932603 , @benshi001 wrote: > We need not add another `basic_avr_tree_opt_local`, since you added `/avr` to > possible avr-libc pathes, you can test your change by specifying `--sysroot > %S/Inputs/basic_avr_tree/

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

mhjacobson added a comment. In D107682#2932599 , @benshi001 wrote: > @mhjacobson Could you please check if my modification also works as expected > on your platform ? Hm... it doesn't, because there aren't enough `..`s. Here's what my directory tree lo

[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

mhjacobson added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:457 + std::string GCCRoot(GCCInstallation.getInstallPath()); + std::string Path(GCCRoot + "/../../../avr"); + if (llvm::sys::fs::is_directory(Path)) Would it be worth encapsulati

[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

mhjacobson created this revision. mhjacobson added reviewers: MaskRay, benshi001. Herald added subscribers: Jim, dylanmckay. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test that ensures that an avr-libc in `$SYSROOT/avr`

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932423 , @MaskRay wrote: > @benshi001 This was prematurely committed. It has no test and has apparent > unaddressed issue. (I revamped many parts in the Linux/Gnu search paths so > am quite confident about my obs

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932413 , @mhjacobson wrote: > At first glance, I think you're right: avr-gcc does expect avr-libc to be > relative to itself. That seems slightly weird to me (since avr-libc is > technically separate from GCC),

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932406 , @MaskRay wrote: > I know nearly nothing about AVR, but from `avr-gcc a.c '-###'` I doubt this > is the GCC behavior. GCC's library path is relative to the GCC installation. > `/usr/lib/gcc/avr/5.4.0/../..

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. In D107672#2932190 , @mhjacobson wrote: > I'm also tempted to remove `/usr/lib/avr`, because these paths make no sense > to me: `$SYSROOT/usr/lib/avr/lib` and `$SYSROOT/usr/lib/avr/include`. Ah. According to https://reviews

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson added a comment. I'm also tempted to remove `/usr/lib/avr`, because these paths make no sense to me: `$SYSROOT/usr/lib/avr/lib` and `$SYSROOT/usr/lib/avr/include`. But I haven't done that here, in case there's some reason those paths do make sense. (Also, the files in `clang/test/Dr

[PATCH] D107672: [AVR][clang] Search for avr-libc in $SYSROOT/avr

mhjacobson created this revision. mhjacobson added reviewers: benshi001, MaskRay, dylanmckay. Herald added a subscriber: Jim. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The paths in PossibleAVRLibcLocations are appended with

[PATCH] D107610: [AVR][clang] Pass '-fno-use-init-array' to cc1

mhjacobson added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107610/new/ https://reviews.llvm.org/D107610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D107610: [AVR][clang] Pass '-fno-use-init-array' to cc1

mhjacobson created this revision. mhjacobson added reviewers: benshi001, MaskRay, dylanmckay. Herald added subscribers: Jim, krytarowski. mhjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AVR, `.ctors` is used, not `.init_array`

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson added a comment. Thanks, Ben. Yes, would you mind to land the patch for me? Name and e-mail are Matt Jacobson And yes, please do change the title as appropriate. I wasn't sure what the proper naming convention was. Thanks again! Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson updated this revision to Diff 362277. mhjacobson marked an inline comment as done. mhjacobson added a comment. Explicitly added `--start-group` and `--end-group` to the expectation in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson marked an inline comment as done. mhjacobson added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:430 +CmdArgs.push_back("--end-group"); + benshi001 wrote: > You are appreciated to use 'git show -U99' or 'git diff -U99'

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson updated this revision to Diff 362275. mhjacobson added a comment. Updated the diff to add more context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106854/new/ https://reviews.llvm.org/D106854 Files: clang/lib/Driver/ToolChains/AVR.

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson updated this revision to Diff 362185. mhjacobson added a comment. Modified regression test `Driver/avr-ld.c` to account for the new arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106854/new/ https://reviews.llvm.org/D106854 Fi

[PATCH] D106854: Pass `--start-group` and `--end-group` to the linker when using the AVR toolchain

mhjacobson created this revision. mhjacobson added a reviewer: dylanmckay. mhjacobson added a project: clang. Herald added a subscriber: Jim. mhjacobson requested review of this revision. Herald added a subscriber: cfe-commits. The way the GNU linker deals with static archives is that it only load