mhjacobson added a comment. In D107684#2932609 <https://reviews.llvm.org/D107684#2932609>, @benshi001 wrote:
> In D107684#2932605 <https://reviews.llvm.org/D107684#2932605>, @mhjacobson > wrote: > >> In D107684#2932603 <https://reviews.llvm.org/D107684#2932603>, @benshi001 >> wrote: >> >>> We need not add another `basic_avr_tree_opt_local`, since you added `/avr` >>> to possible avr-libc pathes, you can test your change by specifying >>> `--sysroot %S/Inputs/basic_avr_tree/usr/lib/` . >> >> Oh, good idea. > > Sorry, only spefifying `--sysroot %S/Inputs/basic_avr_tree/usr/lib/` does > not work, since the search for avr-ld also relies on `--sysroot`. For the purpose of the test, that doesn't matter, since we're just looking for the existence of the `-internal-isystem` argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107684/new/ https://reviews.llvm.org/D107684 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
