Leporacanthicus wrote:
Working on a fix - it should be trivial, just need to check that that it still
builds and passes.
[Trying to generate code without the correct target enabled!]
https://github.com/llvm/llvm-project/pull/95411
___
cfe-commits ma
https://github.com/Leporacanthicus closed
https://github.com/llvm/llvm-project/pull/95411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus edited
https://github.com/llvm/llvm-project/pull/95411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Leporacanthicus wrote:
> Yes, thank you!
This is now part of this PR.
https://github.com/llvm/llvm-project/pull/95411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -21,4 +22,14 @@ CodeGenOptions::CodeGenOptions() {
#include "flang/Frontend/CodeGenOptions.def"
}
+std::optional getCodeModel(llvm::StringRef string) {
+ return llvm::StringSwitch>(string)
+ .Case("tiny", llvm::CodeModel::Model::Tiny)
+ .Case("small", llvm::CodeM
@@ -2823,3 +2823,84 @@ void tools::addOffloadCompressArgs(const
llvm::opt::ArgList &TCArgs,
CmdArgs.push_back(
TCArgs.MakeArgString(Twine("-compression-level=") + Arg->getValue()));
}
+
+void tools::addMCModel(const Driver &D, const llvm::opt::ArgList &Args,
--
https://github.com/Leporacanthicus edited
https://github.com/llvm/llvm-project/pull/95411
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/95411
>From 0ef4b61d0429517b92f7b6de7fa52c516f3a1468 Mon Sep 17 00:00:00 2001
From: David Truby
Date: Thu, 13 Jun 2024 14:01:36 +
Subject: [PATCH 1/5] [flang] Implement -mcmodel flag
This patch implements
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/95411
>From 0ef4b61d0429517b92f7b6de7fa52c516f3a1468 Mon Sep 17 00:00:00 2001
From: David Truby
Date: Thu, 13 Jun 2024 14:01:36 +
Subject: [PATCH 1/4] [flang] Implement -mcmodel flag
This patch implements
@@ -39,6 +39,7 @@ ENUM_CODEGENOPT(RelocationModel, llvm::Reloc::Model, 3,
llvm::Reloc::PIC_) ///<
ENUM_CODEGENOPT(DebugInfo, llvm::codegenoptions::DebugInfoKind, 4,
llvm::codegenoptions::NoDebugInfo) ///< Level of debug info to generate
ENUM_CODEGENOPT(VecLib, llvm::driver::
@@ -39,6 +39,7 @@ ENUM_CODEGENOPT(RelocationModel, llvm::Reloc::Model, 3,
llvm::Reloc::PIC_) ///<
ENUM_CODEGENOPT(DebugInfo, llvm::codegenoptions::DebugInfoKind, 4,
llvm::codegenoptions::NoDebugInfo) ///< Level of debug info to generate
ENUM_CODEGENOPT(VecLib, llvm::driver::
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/95411
>From 0ef4b61d0429517b92f7b6de7fa52c516f3a1468 Mon Sep 17 00:00:00 2001
From: David Truby
Date: Thu, 13 Jun 2024 14:01:36 +
Subject: [PATCH 1/3] [flang] Implement -mcmodel flag
This patch implements
https://github.com/Leporacanthicus closed
https://github.com/llvm/llvm-project/pull/92430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Leporacanthicus wrote:
> progress?
I'm afraid I'm still waiting for review from some of the key people here.
Apparently there was some OpenMP conference last week, which kept some people
very busy, so I'm hoping by the time they've read emails and got over jet-lag,
etc, they'll get round to t
https://github.com/Leporacanthicus approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus commented:
Nit-pick, otherwise OK by me.
https://github.com/llvm/llvm-project/pull/94763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus edited
https://github.com/llvm/llvm-project/pull/94763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,15 @@
+! Test -mlink-builtin-bitcode flag
+! RUN: %flang -emit-llvm -c -o %t.bc %S/Inputs/libfun.f90
+! RUN: %flang_fc1 -emit-llvm -o - -mlink-builtin-bitcode %t.bc %s 2>&1 |
FileCheck %s
+
+! CHECK: define internal void @libfun_
+
+! RUN: not %flang_fc1 -emit-llvm -tr
@@ -1146,6 +1150,54 @@ void CodeGenAction::embedOffloadObjects() {
}
}
+void CodeGenAction::linkBuiltinBCLibs() {
Leporacanthicus wrote:
This is a fairly large chunk of code - does it come from Clang in some way - if
so, is it possible to have one common f
https://github.com/Leporacanthicus edited
https://github.com/llvm/llvm-project/pull/94763
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Leporacanthicus wrote:
Would it be possible to generate this, rather than supply it as a binary - just
out of safety-concerns with binaries, really.
I expect the contents isn't particularly complex or time-consuming to build.
https://github.com/llvm/llvm-proj
https://github.com/Leporacanthicus commented:
Overall looks good. Minor nits on "binary files in repo" and duplication of
code [although I couldn't find the corresponding bit in Clang - I didn't spend
much time on searching for it].
https://github.com/llvm/llvm-project/pull/94763
_
Leporacanthicus wrote:
@ergawy Could you take a look at this, given that you did something similar
[even if it was much smaller] recently?
https://github.com/llvm/llvm-project/pull/92430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/92430
>From 629f5785738fdc52d4dc8d193aa43b3d011b1039 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Apr 2024 18:00:58 +0100
Subject: [PATCH 1/6] Fix for changed code at the end of AllocaIP.
Some o
Leporacanthicus wrote:
> Allocas should be placed at the start of the entry block.
Would it be acceptable to make this change such that the alloca's are at the
very start of the block? I have tried that, and it seems to work. It will still
mean changes to the tests, and I can't guarantee ALL a
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/92430
>From 629f5785738fdc52d4dc8d193aa43b3d011b1039 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Apr 2024 18:00:58 +0100
Subject: [PATCH 1/6] Fix for changed code at the end of AllocaIP.
Some o
@@ -0,0 +1,23 @@
+!! The main point of this test is to check that the code compiles at all, so
the
Leporacanthicus wrote:
I have created an internal ticket to improve the code generation. It's just a
much bigger task than this one started out as. I then found m
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/92430
>From e08c19ced1b2bcdd4a83ffcd3c5f5656c2021d52 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Apr 2024 18:00:58 +0100
Subject: [PATCH 1/5] Fix for changed code at the end of AllocaIP.
Some o
https://github.com/Leporacanthicus closed
https://github.com/llvm/llvm-project/pull/86816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/86816
>From 372995f4e755e3c0bc4a0b5dd09e27c21a3faf2e Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 15 Mar 2024 17:38:52 +
Subject: [PATCH 1/2] [FLANG] allow -fopenmp=
This enables the -fopenmp=
@@ -764,6 +762,32 @@ void Flang::ConstructJob(Compilation &C, const JobAction
&JA,
// Add other compile options
addOtherOptions(Args, CmdArgs);
+ // Forward flags for OpenMP. We don't do this if the current action is an
+ // device offloading action other than OpenMP.
+
@@ -764,6 +762,32 @@ void Flang::ConstructJob(Compilation &C, const JobAction
&JA,
// Add other compile options
addOtherOptions(Args, CmdArgs);
+ // Forward flags for OpenMP. We don't do this if the current action is an
+ // device offloading action other than OpenMP.
+
@@ -764,6 +762,32 @@ void Flang::ConstructJob(Compilation &C, const JobAction
&JA,
// Add other compile options
addOtherOptions(Args, CmdArgs);
+ // Forward flags for OpenMP. We don't do this if the current action is an
+ // device offloading action other than OpenMP.
+
@@ -764,6 +762,32 @@ void Flang::ConstructJob(Compilation &C, const JobAction
&JA,
// Add other compile options
addOtherOptions(Args, CmdArgs);
+ // Forward flags for OpenMP. We don't do this if the current action is an
+ // device offloading action other than OpenMP.
+
https://github.com/Leporacanthicus created
https://github.com/llvm/llvm-project/pull/86816
This enables the -fopenmp= option to the set of options supported by
flang.
The generated arguments for the FC1 compilation will appear in a slightly
different order, so one test had to be updated to be
Leporacanthicus wrote:
Thanks for letting me klnow. I have a fix in
https://github.com/llvm/llvm-project/pull/80717
I'm not entirely sure why it's broken on Arm but not x86 - the tests run on
both, and should give identical output [but clearly doesn't].
--
Mats
[https://opengraph.githubassets
https://github.com/Leporacanthicus closed
https://github.com/llvm/llvm-project/pull/78755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/78755
>From a0e256f379130a98ba03793f7102c67d02cbdef1 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Jan 2024 16:30:31 +
Subject: [PATCH 1/7] [flang]Add support for -moutline-atomics and
-mno-o
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/78755
>From a0e256f379130a98ba03793f7102c67d02cbdef1 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Jan 2024 16:30:31 +
Subject: [PATCH 1/6] [flang]Add support for -moutline-atomics and
-mno-o
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/78755
>From a0e256f379130a98ba03793f7102c67d02cbdef1 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Jan 2024 16:30:31 +
Subject: [PATCH 1/5] [flang]Add support for -moutline-atomics and
-mno-o
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/78755
>From a0e256f379130a98ba03793f7102c67d02cbdef1 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Jan 2024 16:30:31 +
Subject: [PATCH 1/4] [flang]Add support for -moutline-atomics and
-mno-o
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/78755
>From a0e256f379130a98ba03793f7102c67d02cbdef1 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Jan 2024 16:30:31 +
Subject: [PATCH 1/3] [flang]Add support for -moutline-atomics and
-mno-o
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/78755
>From a0e256f379130a98ba03793f7102c67d02cbdef1 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Jan 2024 16:30:31 +
Subject: [PATCH 1/2] [flang]Add support for -moutline-atomics and
-mno-o
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/78755
>From 1bf1060607dc8d4fedb227de35271e0b0307f564 Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 19 Jan 2024 16:30:31 +
Subject: [PATCH 1/2] [flang]Add support for -moutline-atomics and
-mno-o
https://github.com/Leporacanthicus created
https://github.com/llvm/llvm-project/pull/78755
This adds the support to add the target-feature.
It will be fully supported once the generic support for adding target-cpu and
target-features attributes to functions has landed. See #78289. Regression
https://github.com/Leporacanthicus closed
https://github.com/llvm/llvm-project/pull/74598
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/73111
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -242,10 +242,24 @@ static void
parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts,
clang::driver::options::OPT_fno_loop_versioning, false))
opts.LoopVersioning = 1;
- opts.AliasAnalysis =
- args.hasFlag(clang::driver::options::OPT_falias_
@@ -311,7 +311,7 @@ inline void createDefaultFIRCodeGenPassPipeline(
if (config.VScaleMin != 0)
pm.addPass(fir::createVScaleAttrPass({config.VScaleMin,
config.VScaleMax}));
- fir::addFIRToLLVMPass(pm, config.OptLevel);
+ fir::addFIRToLLVMPass(pm, config.OptLevel, conf
https://github.com/Leporacanthicus approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/68595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/68595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Dmitriy Smirnov
Date: 2023-10-06T12:29:06+01:00
New Revision: e13bed4c5f3544c076ce57e36d9a11eefa5a7815
URL:
https://github.com/llvm/llvm-project/commit/e13bed4c5f3544c076ce57e36d9a11eefa5a7815
DIFF:
https://github.com/llvm/llvm-project/commit/e13bed4c5f3544c076ce57e36d9a11eefa5a7815.dif
https://github.com/Leporacanthicus closed
https://github.com/llvm/llvm-project/pull/67676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/67676
>From 17e128e808ecb170b71a4713692cff3dee8d50aa Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 15 Sep 2023 18:52:11 +0100
Subject: [PATCH 1/4] [flang]Add vscale argument parsing
Support for vect
@@ -0,0 +1,55 @@
+! -
+! Tests for the -msve-vector-bits flag (taken from the clang test)
+! -
+
+! RUN: %flang -c %s -### --targ
@@ -0,0 +1,55 @@
+! -
+! Tests for the -msve-vector-bits flag (taken from the clang test)
+! -
+
+! RUN: %flang -c %s -### --targ
https://github.com/Leporacanthicus resolved
https://github.com/llvm/llvm-project/pull/67676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -170,6 +169,38 @@ void Flang::addPicOptions(const ArgList &Args,
ArgStringList &CmdArgs) const {
}
}
+void Flang::AddAArch64TargetArgs(const ArgList &Args,
+ ArgStringList &CmdArgs) const {
+ // Handle -msve_vector_bits=
+ if (Arg *A = A
Leporacanthicus wrote:
> Please could you add testing, like the tests you wrote for the loop
> versioning flag.
Tests added.
https://github.com/llvm/llvm-project/pull/67676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/Leporacanthicus resolved
https://github.com/llvm/llvm-project/pull/67676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus resolved
https://github.com/llvm/llvm-project/pull/67676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Leporacanthicus updated
https://github.com/llvm/llvm-project/pull/67676
>From 25b53fa1d6d52e8f22dcdaaf5c7fbf47132e Mon Sep 17 00:00:00 2001
From: Mats Petersson
Date: Fri, 15 Sep 2023 18:52:11 +0100
Subject: [PATCH 1/3] [flang]Add vscale argument parsing
Support for vect
@@ -170,6 +170,39 @@ void Flang::addPicOptions(const ArgList &Args,
ArgStringList &CmdArgs) const {
}
}
+
+void Flang::AddAArch64TargetArgs(const ArgList &Args,
+ ArgStringList &CmdArgs) const {
+ // Handle -msve_vector_bits=
+ if (Arg *A =
https://github.com/Leporacanthicus created
https://github.com/llvm/llvm-project/pull/67676
Support for vector scale range arguments, for AArch64 scalable vector extension
(SVE) support.
Adds -msve-vector-bits to the flang frontend, and for flang fc1 the options are
-mvscale-min and -mvscale-m
Author: Mats Petersson
Date: 2023-04-18T09:47:54+01:00
New Revision: efae695d52ccc987ddd3eb042eeb11f06cb2383b
URL:
https://github.com/llvm/llvm-project/commit/efae695d52ccc987ddd3eb042eeb11f06cb2383b
DIFF:
https://github.com/llvm/llvm-project/commit/efae695d52ccc987ddd3eb042eeb11f06cb2383b.diff
Author: Mats Petersson
Date: 2022-10-05T19:43:02+01:00
New Revision: 4d1460c77d0095fb5eb974b42d96ca4f4567a7cd
URL:
https://github.com/llvm/llvm-project/commit/4d1460c77d0095fb5eb974b42d96ca4f4567a7cd
DIFF:
https://github.com/llvm/llvm-project/commit/4d1460c77d0095fb5eb974b42d96ca4f4567a7cd.diff
MatsPetersson added a subscriber: MatsPetersson.
MatsPetersson added a comment.
Obvious typo in title. Pipe, not piep.
http://reviews.llvm.org/D17955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
MatsPetersson added a comment.
@Anastasia: Yes, I agree, printf should be done as a separate patch.
http://reviews.llvm.org/D16928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MatsPetersson added a comment.
I think adding printf as a builtin function is a good idea.
If not, I feel that the error message should distinguish between (for example):
int printf(global char* fmt, ...);
and
void myfunc(int n, ...);
since the former is "incorrect prototype of printf" an
MatsPetersson added inline comments.
Comment at: test/SemaOpenCL/invalid-func.cl:6
@@ +5,2 @@
+void foo(int, ...); // expected-error{{OpenCL does not allow variadic
arguments}}
+int printf(const char *, ...);
pekka.jaaskelainen wrote:
> I wonder should we check f
MatsPetersson added a subscriber: MatsPetersson.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7700
@@ -7698,2 +7699,3 @@
+ "OpenCL does not allow variadic arguments">;
// OpenCL v2.0 s6.13.6 -- Builtin Pipe Functions
Looks good
Comm
Leporacanthicus added a subscriber: Leporacanthicus.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7684
@@ +7683,3 @@
+ "the __block storage type is not permitted">;
+
+def err_opencl_variadic_prototype_not_allowed : Error<
Is this blank line there for a
On 5 October 2015 at 15:51, Aaron Ballman wrote:
> On Mon, Oct 5, 2015 at 10:49 AM, mats petersson
> wrote:
> >
> >
> > On 5 October 2015 at 15:41, Aaron Ballman via cfe-commits
> > wrote:
> >>
> >> Author: aaronballman
> >> Date: Mon Oct 5 09:41:27 2015
> >> New Revision: 249321
> >>
> >> URL
On 5 October 2015 at 15:41, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Mon Oct 5 09:41:27 2015
> New Revision: 249321
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249321&view=rev
> Log:
> Adding a narrowing AST matcher for FunctionDecl::i
On 2 October 2015 at 22:07, Aaron Ballman wrote:
> On Fri, Oct 2, 2015 at 4:01 PM, mats petersson
> wrote:
> > Since "varargs" often involve some kind of special passing mechanisms
> [I've
> > seen implementations that build data block and pass a pointer to that,
> > rather than passing on the s
Since "varargs" often involve some kind of special passing mechanisms [I've
seen implementations that build data block and pass a pointer to that,
rather than passing on the stack, for example], or additional code in the
recipient function, I would say that `f2()` does not mean `f2(...)`.
--
Mats
76 matches
Mail list logo
