@@ -355,6 +349,9 @@ function(add_link_opts target_name)
set_property(TARGET ${target_name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-brtl")
endif()
+
+ check_linker_flag(CXX "-Wl,-Bsymbolic-functions"
mati865 wrote:
I'd argue it's much f
@@ -314,6 +308,11 @@ function(add_link_opts target_name)
set_property(TARGET ${target_name} APPEND_STRING PROPERTY
LINK_FLAGS " -Wl,-brtl")
endif()
+
+ if (NOT MINGW)
+llvm_check_linker_flag(CXX "-Wl,-Bsymbolic-functions"
+
mati865 wrote:
> But people build mingw clang with gcc, right?
Dunno.
> It seems like having explicit dllexport annotations as libclang does should
> turn off auto-export. I didn't see `--export-all-symbols` in the command line
> anyway.
Yes, linker exports all the symbols by default, but ex
mati865 wrote:
I think it works when you build with Clang rather than GCC. Clang will not
export symbols with hidden visibility.
https://github.com/llvm/llvm-project/pull/138351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
mati865 wrote:
Looks good, thanks.
https://github.com/llvm/llvm-project/pull/138120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mati865 closed
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
Thank you for taking care of it!
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
> Defining `_WIN32` in cygwin mode compilations, and including w32api headers
> from there, feels brittle; I'm not familiar enough with cygwin to know if
> this is something that one usually can do, or whether it is commonly done, or
> what caveats that involves (doesn't e.g. cy
@@ -106,7 +106,8 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC))
+if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+ ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUIL
https://github.com/mati865 edited
https://github.com/llvm/llvm-project/pull/135691
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,77 @@
+// RUN: %clang -### %s --target=i686-pc-windows-cygnus
--sysroot=%S/Inputs/basic_cygwin_tree \
+// RUN: -resource-dir=%S/Inputs/resource_dir \
+// RUN: --stdlib=platform 2>&1 | FileCheck --check-prefix=CHECK %s
+// CHECK: "-cc1"
+// CHECK-SAME: "-resour
https://github.com/mati865 edited
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
Okay, you were right.
Keeping this in a single description hurts readability a lot.
So I have opened a series of smaller PRs:
https://github.com/llvm/llvm-project/pull/138117
https://github.com/llvm/llvm-project/pull/138118
https://github.com/llvm/llvm-project/pull/138119
https://
https://github.com/mati865 created
https://github.com/llvm/llvm-project/pull/138120
With this define present and building with Clang the build fails:
```
In file included from
/h/projects/llvm-project/clang/tools/libclang/CIndexer.cpp:36:
In file included from /usr/include/w32api/windows.h:69:
https://github.com/mati865 created
https://github.com/llvm/llvm-project/pull/138119
This change follows MinGW decisions, otherwise build with GCC fail with:
```
FAILED: bin/msys-clang-cpp-21.0git.dll lib/libclang-cpp.dll.a
...
/usr/lib/gcc/x86_64-pc-msys/13.3.0/../../../../x86_64-pc-msys/bin/ld:
https://github.com/mati865 created
https://github.com/llvm/llvm-project/pull/138118
Currently building for Cygwin hits this error:
```
In file included from
/h/projects/llvm-project/clang/lib/Basic/Attributes.cpp:17:
/h/projects/llvm-project/clang/include/clang/Basic/ParsedAttrInfo.h:180:73:
e
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From b7a5fab29b810f72f2ffa65fb0945abd302c2411 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Signals compatibility w
https://github.com/mati865 converted_to_draft
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
> These changes mostly look good to me, but it all feels a bit unclear to me
> still. So I'd appreciate e.g. one or a few sentences in the commit message on
> each of these commits, to explain a bit about the why/how and how things work
> in other preexisting environments.
Sure
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From ede237421177b81181900b915eeda7fc5ee6ae12 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/5] [LLVM][Cygwin] Fix Signals compatibility w
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From ee496adcd21933ce9c8f0304c27b8a070d2b83f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/5] [LLVM][Cygwin] Fix Signals compatibility w
mati865 wrote:
So this is basically `hack: dynamically resolve G++ include dir` and `hack: add
system search paths` from
https://github.com/mati865/llvm-project/commits/cygwin-more-fixes/ but done the
proper way.
It will take a few more changes to get everything working, but this is a good
s
@@ -847,7 +847,11 @@ void llvm::sys::PrintStackTrace(raw_ostream &OS, int
Depth) {
const char *name = strrchr(dlinfo.dli_fname, '/');
if (!name)
+#ifdef __CYGWIN__
+ OS << format(" %-*s", width, &dlinfo.dli_fname);
mati865 wrote:
Right, I doubte
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC))
+if(LLVM_ENABLE_PIC OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
mat
https://github.com/mati865 ready_for_review
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From ee496adcd21933ce9c8f0304c27b8a070d2b83f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Signals compatibility w
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From ee496adcd21933ce9c8f0304c27b8a070d2b83f0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/5] [LLVM][Cygwin] Fix Signals compatibility w
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC))
+if(LLVM_ENABLE_PIC OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
mat
https://github.com/mati865 edited
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mati865 edited
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -847,7 +847,11 @@ void llvm::sys::PrintStackTrace(raw_ostream &OS, int
Depth) {
const char *name = strrchr(dlinfo.dli_fname, '/');
if (!name)
+#ifdef __CYGWIN__
+ OS << format(" %-*s", width, &dlinfo.dli_fname);
mati865 wrote:
Simple cast res
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From cf2678bbd9052e125dc056a07d8eaa6a55d734d5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Signals compatibility w
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From 0b1b897e988e38d22735d8768e9421f2c42d517b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Signals compatibility w
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From 80edab2cb3114b327d6debc904f77bfb790f7e14 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Singals compatibility w
https://github.com/mati865 edited
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -847,7 +847,11 @@ void llvm::sys::PrintStackTrace(raw_ostream &OS, int
Depth) {
const char *name = strrchr(dlinfo.dli_fname, '/');
if (!name)
+#ifdef __CYGWIN__
+ OS << format(" %-*s", width, &dlinfo.dli_fname);
mati865 wrote:
Good point, som
https://github.com/mati865 edited
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mati865 edited
https://github.com/llvm/llvm-project/pull/134494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134494
From e3efa736cf6c95d536c58e5dbf5bc3916aeef58a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 5 Apr 2025 13:18:35 +0200
Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Singals compatibility w
https://github.com/mati865 created
https://github.com/llvm/llvm-project/pull/134494
With these changes, LLVM and Clang become buildable for Cygwin.
GCC config (using MSYS2 GCC):
`CFLAGS="-D_GNU_SOURCE=1" CXXFLAGS="-D_GNU_SOURCE=1" CPPFLAGS="-D_GNU_SOURCE=1"
cmake -GNinja -DCMAKE_BUILD_TYPE=Rel
https://github.com/mati865 closed
https://github.com/llvm/llvm-project/pull/134458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mati865 converted_to_draft
https://github.com/llvm/llvm-project/pull/134458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
Sure, I'll split this in the upcoming days.
https://github.com/llvm/llvm-project/pull/134458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134458
From adbcc7f650edfb4f2f86d1146b8116794a9de6df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 8 Feb 2025 01:13:06 +0100
Subject: [PATCH 1/4] [Clang][Cygwin] Enable few conditions that
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/134458
From adbcc7f650edfb4f2f86d1146b8116794a9de6df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Sat, 8 Feb 2025 01:13:06 +0100
Subject: [PATCH 1/5] [Clang][Cygwin] Enable few conditions that
https://github.com/mati865 created
https://github.com/llvm/llvm-project/pull/134458
This is part of the fixes from
https://github.com/mati865/llvm-project/commits/cygwin-more-fixes/ that I
consider good enough to upstream.
The other branch with hacky changes even goes as far as making Clang
https://github.com/mati865 closed
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
Guess this is not happening.
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
I'd be fine with closing this PR and #10148 if that is the preferred solution.
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/mati865 updated
https://github.com/llvm/llvm-project/pull/121442
From b4a5daabac693aa3021c81180a9d25ac34177f62 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mateusz=20Miku=C5=82a?=
Date: Wed, 1 Jan 2025 21:38:49 +0100
Subject: [PATCH] [Clang][Driver] Declare win32 threads on Windo
https://github.com/mati865 converted_to_draft
https://github.com/llvm/llvm-project/pull/121442
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -619,7 +619,13 @@ class ToolChain {
virtual bool SupportsEmbeddedBitcode() const { return false; }
/// getThreadModel() - Which thread model does this target use?
- virtual std::string getThreadModel() const { return "posix"; }
+ virtual std::string getThreadModel() c
https://github.com/mati865 created
https://github.com/llvm/llvm-project/pull/121442
Fixes https://github.com/llvm/llvm-project/issues/10148
Recently I saw a user confused by it and thought Clang was using `winpthreads`.
Note: this does not change structures like
https://github.com/llvm/llvm-p
https://github.com/mati865 approved this pull request.
Thank you
https://github.com/llvm/llvm-project/pull/76949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
54 matches
Mail list logo
