[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

marejde added a comment. > Do you need me to commit the patch for you? Yes please. I do not have commit access. Comment at: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp:48 +bool UsingNamespaceDirectiveCheck::isStdLiteralsNamespace( +const NamespaceDecl *NS) { -

[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

marejde updated this revision to Diff 99011. marejde added a comment. Modified isStdLiteralsNamespace() to be a static method. https://reviews.llvm.org/D33010 Files: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp clang-tidy/google/UsingNamespaceDirectiveCheck.h test/clang-tidy/google-

[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

marejde updated this revision to Diff 98914. marejde added a comment. Removed use of nested namespace definition in test (C++17) and added a couple of more namespaces with "literals" in name that check should warn for. https://reviews.llvm.org/D33010 Files: clang-tidy/google/UsingNamespaceDi

[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

marejde updated this revision to Diff 98893. marejde added a comment. Removed use of getQualifiedNameAsString(). https://reviews.llvm.org/D33010 Files: clang-tidy/google/UsingNamespaceDirectiveCheck.cpp clang-tidy/google/UsingNamespaceDirectiveCheck.h test/clang-tidy/google-namespaces.cpp