[PATCH] D88446: docs: add documentation describing API Notes

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. Thanks for pushing this forward! Current proposal seems to be only dealing with annotating ObjC for Swift, but API notes seem like a feature that would be useful for other languages as well.

[PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

hlopko added a comment. Herald added a subscriber: JDevlieghere. Friendly ping, this change will remove HAVE_VCS_VERSION_INC define. If you disagree, please complain :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84623/new/ https://reviews.llvm.

[PATCH] D84623: Remove HAVE_VCS_VERSION_INC, not needed

hlopko created this revision. hlopko added a reviewer: gribozavr2. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, mgorny. Herald added a reviewer: MaskRay. Herald added projects: clang, LLDB, LLVM. This preprocessor define was meant to be used to conditionally include headers w

[PATCH] D81150: Use libClangTesting in the unittest for AST matchers

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. Nice! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81150/new/ https://reviews.llvm.org/D81150 ___

[PATCH] D81107: Make syntax tree test print the line number when it fails

hlopko accepted this revision. hlopko added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81107/new/ https://reviews.llvm.org/D81107 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D81040: Split syntax tree tests into more granular ones

hlopko accepted this revision. hlopko added a comment. Thanks for working on this! :) Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:2066 +int func3b(int *); +int func4(int a, float b); +int func4a(int, float); func4 -> func4a func4a -> func4b? Repos

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81019/new/ https://reviews.llvm.org/D81019

[PATCH] D81000: Renamed Lang_C to Lang_C99, Lang_CXX to Lang_CXX03, and 2a to 20

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81000/new/ https://reviews.llvm.org/D81000

[PATCH] D80822: Run syntax tree tests in many language modes

hlopko accepted this revision. hlopko added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80822/new/ https://reviews.llvm.org/D80822 __

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255654. hlopko added a comment. Assert the Spelled subrange more effectively Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, &Spelled.front()); + unsigned SpelledFrontI = &Spelled.front() - File.SpelledTokens.data(); + unsigned ExpandedBegin; gr

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255610. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling/Syntax/To

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255609. hlopko marked 6 inline comments as done. hlopko added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko marked an inline comment as done. hlopko added a comment. Adressing comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:264 + auto *FrontMapping = mappingStartingBeforeSpelled(File, &Spelled.front()); + unsigned SpelledFrontI = &Spelled.front() - File.SpelledToke

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 255326. hlopko marked 4 inline comments as done. hlopko added a comment. Adressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/

[PATCH] D72581: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko marked 5 inline comments as done. hlopko added a comment. I'm submitting this patch at https://reviews.llvm.org/D77209 (with Ilya's permission). Let's continue the review there. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:228 + /// multiple times and this f

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko updated this revision to Diff 254188. hlopko added a comment. Adding comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77209/new/ https://reviews.llvm.org/D77209 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/Tooling

[PATCH] D77209: [Syntax] Add mapping from spelled to expanded tokens for TokenBuffer

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same restrictions apply as in the other direction: macro arguments are not supported yet, only full macro expansions can be mapped. Taking over from https://reviews.llvm.org/D72581. Repository:

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko added a comment. I propose adding those tests in a separate patch to keep this one focused. Those tests are currently failing, because: - we assume initializer, if present, is extending the declarator range, but `struct P {} p;` has initializer ending where declarator ended already. - Un

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko updated this revision to Diff 253787. hlopko marked an inline comment as done. hlopko added a comment. Remove unnecessary cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooli

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko abandoned this revision. hlopko added a comment. Talked to gribozavr2 offline and decided to abandon this patch. If in the future we'll have a need for a tool to dump syntax trees, we'll probably implement it in clang behind hidden options, and we'll provide a json output format as well.

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko updated this revision to Diff 253561. hlopko added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77053/new/ https://reviews.llvm.org/D77053 Files: clang/test/CMakeLists.txt clang/test/clang-syntax/no_args.cpp clang/

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko updated this revision to Diff 253562. hlopko added a comment. Cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77053/new/ https://reviews.llvm.org/D77053 Files: clang/test/CMakeLists.txt clang/test/clang-syntax/no_args.cpp clang/

[PATCH] D77053: [Syntax] A tool to dump syntax tree and token buffer

hlopko created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. hlopko updated this revision to Diff 253561. hlopko added a comment. hlopko updated this revision to Diff 253562. hlopko added a reviewer: gribozavr2. hlopko edited the summary of this revisi

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko updated this revision to Diff 253517. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/Tokens.

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko updated this revision to Diff 253122. hlopko added a comment. Polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/Tokens.

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko updated this revision to Diff 253123. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/Tokens.

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko updated this revision to Diff 253108. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files: clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/Token

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko updated this revision to Diff 253108. hlopko added a comment. hlopko edited the summary of this revision. Reformat This patch removes delayed folding and replaces it with forward peeking.

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 252045. hlopko marked 5 inline comments as done. hlopko added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/To

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko added a comment. PTAL. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:173 +private: + // Keys are either Stmt* or Decl*. + llvm::DenseMap Nodes; gribozavr2 wrote: > The comment is not needed anymore. Clang tidy complains when I remove it :/ Repos

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:570 + auto *N = new (allocator()) syntax::SimpleDeclarator; + Builder.foldNode(Builder.getRange(R.getBegin(), R.getEnd()), N, D); + Builder.markChild(N, syntax::NodeRole::SimpleDeclara

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 251993. hlopko marked 6 inline comments as done. hlopko added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/To

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 251968. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooling/Syntax/Bu

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251646. hlopko added a comment. Polish Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76497/new/ https://reviews.llvm.org/D76497 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/Tool

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251649. hlopko added a comment. .equals -> == :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76497/new/ https://reviews.llvm.org/D76497 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unit

[PATCH] D76497: [Syntax] Test both the default and windows target platforms in unittests

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This increases the coverage for things that differ between Linux and Windows, such as -fdelayed-template-parsing. This would have prevented the rollback of https://reviews.llvm.org/D76346. While

[PATCH] D72446: [Syntax] Build mapping from AST to syntax tree nodes

hlopko added a comment. Taking over the patch in https://reviews.llvm.org/D76355. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:147 + void add(ASTPtr From, syntax::Tree *To) { +assert(To != nullptr); + gribozavr2 wrote: > Also assert that From is not

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko updated this revision to Diff 251603. hlopko added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76355/new/ https://reviews.llvm.org/D76355 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/lib/Tooli

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251582. hlopko marked 3 inline comments as done. hlopko added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files: clang/unittests/Tooli

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251585. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/Tool

[PATCH] D76433: [Syntax] Test both the default and windows target platforms in unittests

hlopko updated this revision to Diff 251576. hlopko added a comment. Refactored to run tests on both default and windows platforms. Opting out Templates test for now since it doesn't work with -fdelayed-template-parsing yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D76366: [Syntax] Split syntax tests

hlopko updated this revision to Diff 251571. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://reviews.llvm.org/D76366 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/Tooli

[PATCH] D76433: [Syntax] Make TreeTest independent from the host platform.

hlopko updated this revision to Diff 251399. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76433/new/ https://reviews.llvm.org/D76433 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp Index: clang/unittests/To

[PATCH] D76433: [Syntax] Make TreeTest independent from the host platform.

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko added a parent revision: D76366: [Syntax] Split syntax tests. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76433 Files: clang/unittests/Tooling/Syntax/TreeTest.cpp I

[PATCH] D76422: Testing presubmits

hlopko updated this revision to Diff 251387. hlopko added a comment. Removing fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76422/new/ https://reviews.llvm.org/D76422 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Synt

[PATCH] D76422: Testing presubmits

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ignore me Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76422 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/

[PATCH] D76418: [Syntax] Build template declaration nodes

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rollforward of https://reviews.llvm.org/rGdd12826808f9079e164b82e64b0697a077379241 after temporarily adding -fno-delayed-template-parsing to the TreeTest. Original summary: > Copy of https://revi

[PATCH] D76366: [Syntax] Split syntax tests

hlopko added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://reviews.llvm.org/D76366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D76366: [Syntax] Split syntax tests

hlopko updated this revision to Diff 251102. hlopko marked 5 inline comments as done. hlopko added a comment. Renaming some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://reviews.llvm.org/D76366 Files: clang/unittests/To

[PATCH] D76346: [Syntax] Build template declaration nodes

hlopko updated this revision to Diff 251095. hlopko added a comment. Clang tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76346/new/ https://reviews.llvm.org/D76346 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax

[PATCH] D76366: [Syntax] Split syntax tests

hlopko created this revision. hlopko added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko added a parent revision: D76346: [Syntax] Build template declaration nodes. This patch split Basic test into multple individual tests to allow simpler f

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko edited the summary of this revision. hlopko added a parent revision: D76346: [Syntax] Build template declaration nodes. Copy of https://reviews.llvm.org/D72446, submitting with Ilya's permi

[PATCH] D72334: [Syntax] Build nodes for template declarations.

hlopko added a comment. Let's continue the review at https://reviews.llvm.org/D76346. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:190 + // Set role for the node that may or may not be delayed. Node must span + // exactly \p Range. + void markMaybeDelayedChild(llvm::Ar

[PATCH] D76346: Build template declaration nodes

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko added a reviewer: gribozavr2. Copy of https://reviews.llvm.org/D72334, submitting with Ilya's permission. Handles template declaration of all kinds. Also builds template declaration nodes

[PATCH] D76220: [Syntax] Build declarator nodes

hlopko updated this revision to Diff 250591. hlopko added a comment. Fix clang tidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76220/new/ https://reviews.llvm.org/D76220 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/T

[PATCH] D76220: [Syntax] Build declarator nodes

hlopko updated this revision to Diff 250574. hlopko marked 8 inline comments as done. hlopko added a comment. Resolving comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76220/new/ https://reviews.llvm.org/D76220 Files: clang/include/clang

[PATCH] D76220: [Syntax] Build declarator nodes

hlopko added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:522 +/// `(volatile int a)` in `int foo(volatile int a);` +/// `(int&& a)` in `int foo(int&& a);` +/// `() -> int` in `auto foo() -> int;` gribozavr2 wrote: > I meant: > > `i

[PATCH] D76220: Build declarator nodes

hlopko created this revision. hlopko added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Copy of https://reviews.llvm.org/D72089 with Ilya's permission. See https://reviews.llvm.org/D72089 for the first batch of comments. Repository: rG LLVM Git

[PATCH] D72089: [Syntax] Build declarator nodes

hlopko added a comment. I'm taking over of this patch (with a kind permission from Ilya :) I've replied to comments here, but let's continue the review over at https://reviews.llvm.org/D76220. Thanks :) Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:395 } + /// FI

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250162. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/SourceLocationTest.cpp Index: clang/unittests/AST/S

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250163. hlopko added a comment. Remove extra blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/SourceLocationTest.cpp Index: clan

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250160. hlopko added a comment. Rename D->VD, rebase master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Par

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250161. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp cla

[PATCH] D76121: Modernize DeclTest

hlopko updated this revision to Diff 250159. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76121/new/ https://reviews.llvm.org/D76121 Files: clang/unittests/AST/DeclTest.cpp Index: clang/unittests/AST/DeclTest.cp

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250158. hlopko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/DeclTest.cpp Index: clang/unittests/AST/DeclTest.cp

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250152. hlopko added a comment. Wrap the test with an anonymous namespace, remove fully qualified name to Lang_*. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files:

[PATCH] D76121: Modernize DeclTest

hlopko created this revision. hlopko added a reviewer: gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch removes a call to the old ASTUnit::findFileRegionDecls and replaces it with ast matchers. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250143. hlopko added a comment. Rearrange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250141. hlopko added a comment. Refactor the test to use matchers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/l

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko created this revision. hlopko added a reviewer: gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko updated this revision to Diff 250147. hlopko added a comment. Reformat Only for the readability reasons. Repository: rG LLVM Github Monorepo https:

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250142. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76061/new/ https://reviews.llvm.org/D76061 Files: clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp c

[PATCH] D76120: Refactor SourceLocationTest to `using namespace`

hlopko updated this revision to Diff 250147. hlopko added a comment. Reformat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76120/new/ https://reviews.llvm.org/D76120 Files: clang/unittests/AST/SourceLocationTest.cpp Index: clang/unittests/AST

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko updated this revision to Diff 250024. hlopko added a comment. Herald added a subscriber: mgorny. [Sema] Fix location of star ('*') inside MemberPointerTypeLoc Copy of https://reviews.llvm.org/D72073?id=235842, submitting with ilya-biryukov's permission. Repository: rG LLVM Github Mono

[PATCH] D76061: [Sema] Fix location of star ('*') inside MemberPointerTypeLoc

hlopko created this revision. hlopko added a reviewer: gribozavr. hlopko added a project: clang. Herald added a subscriber: cfe-commits. Copy of https://reviews.llvm.org/D72073?id=235842, submitting with ilya-biryukov's permission. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D76001: [AST] Respect shouldTraversePostOrder when traversing type locs

hlopko created this revision. hlopko added a reviewer: gribozavr2. hlopko added a project: clang. Herald added a subscriber: cfe-commits. Copy of https://reviews.llvm.org/D72072, submitting with ilya-biryukov's permission. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76001