hlopko added a comment.

I propose adding those tests in a separate patch to keep this one focused. 
Those tests are currently failing, because:

- we assume initializer, if present, is extending the declarator range, but 
`struct P {} p;` has initializer ending where declarator ended already.
- UnknownExpressions finds its way inside SimpleDeclarator for p in `struct P 
{} p, *pp`;
- typedefs also fail, unable to find the end of declarator properly. I didn't 
investigate further.

Fixing those seems worthy of a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76922/new/

https://reviews.llvm.org/D76922



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to