Author: Manuel Klimek
Date: 2023-04-21T11:59:45Z
New Revision: 9e9e096ae95b9a41bf855cda01963a65313e9560
URL:
https://github.com/llvm/llvm-project/commit/9e9e096ae95b9a41bf855cda01963a65313e9560
DIFF:
https://github.com/llvm/llvm-project/commit/9e9e096ae95b9a41bf855cda01963a65313e9560.diff
LOG:
I am so sorry, thanks for sending out the patch already and fixing the
layout!
On Thu, Mar 23, 2023 at 10:08 AM MyDeveloperDay via Phabricator <
revi...@reviews.llvm.org> wrote:
> MyDeveloperDay added a comment.
>
> I know this is like "telling my grandmother to suck eggs" but @klimek the
> chan
Author: Manuel Klimek
Date: 2023-03-01T12:36:07Z
New Revision: f8d10d5ac9ab4b45b388c74357fc82fb96562e66
URL:
https://github.com/llvm/llvm-project/commit/f8d10d5ac9ab4b45b388c74357fc82fb96562e66
DIFF:
https://github.com/llvm/llvm-project/commit/f8d10d5ac9ab4b45b388c74357fc82fb96562e66.diff
LOG:
Author: Manuel Klimek
Date: 2023-02-27T10:50:42Z
New Revision: 398cddf6acecfb12b5997c2d639ee3cf31b787ad
URL:
https://github.com/llvm/llvm-project/commit/398cddf6acecfb12b5997c2d639ee3cf31b787ad
DIFF:
https://github.com/llvm/llvm-project/commit/398cddf6acecfb12b5997c2d639ee3cf31b787ad.diff
LOG:
Author: Manuel Klimek
Date: 2023-02-27T10:40:22Z
New Revision: f600a5aec52c0aa56e4e47c992b6f10e5cd7b7af
URL:
https://github.com/llvm/llvm-project/commit/f600a5aec52c0aa56e4e47c992b6f10e5cd7b7af
DIFF:
https://github.com/llvm/llvm-project/commit/f600a5aec52c0aa56e4e47c992b6f10e5cd7b7af.diff
LOG:
Author: Manuel Klimek
Date: 2023-02-24T15:44:24Z
New Revision: 01402831aaae76e9c61595f9aa81a506b0d926eb
URL:
https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb
DIFF:
https://github.com/llvm/llvm-project/commit/01402831aaae76e9c61595f9aa81a506b0d926eb.diff
LOG:
Author: Manuel Klimek
Date: 2023-02-15T20:59:43Z
New Revision: 8c1f77af7fd14d5a611246aa16b9693d3ebcee22
URL:
https://github.com/llvm/llvm-project/commit/8c1f77af7fd14d5a611246aa16b9693d3ebcee22
DIFF:
https://github.com/llvm/llvm-project/commit/8c1f77af7fd14d5a611246aa16b9693d3ebcee22.diff
LOG:
Author: Manuel Klimek
Date: 2023-02-15T12:39:24Z
New Revision: 1995d4424505cb5a1c3f0e5f851a660ec32d7af1
URL:
https://github.com/llvm/llvm-project/commit/1995d4424505cb5a1c3f0e5f851a660ec32d7af1
DIFF:
https://github.com/llvm/llvm-project/commit/1995d4424505cb5a1c3f0e5f851a660ec32d7af1.diff
LOG:
Author: Manuel Klimek
Date: 2023-01-31T16:06:46Z
New Revision: 04ed86ff1b7272faf8e62fa32da4acaa2d3c6add
URL:
https://github.com/llvm/llvm-project/commit/04ed86ff1b7272faf8e62fa32da4acaa2d3c6add
DIFF:
https://github.com/llvm/llvm-project/commit/04ed86ff1b7272faf8e62fa32da4acaa2d3c6add.diff
LOG:
Author: Manuel Klimek
Date: 2023-01-31T15:06:20Z
New Revision: be31f2c11d47d3eca28d922a06de181d6e23b355
URL:
https://github.com/llvm/llvm-project/commit/be31f2c11d47d3eca28d922a06de181d6e23b355
DIFF:
https://github.com/llvm/llvm-project/commit/be31f2c11d47d3eca28d922a06de181d6e23b355.diff
LOG:
Author: Manuel Klimek
Date: 2023-01-31T14:32:31Z
New Revision: c3bc61d72f8da9a2b45e610ee3c2ccfc5f884f69
URL:
https://github.com/llvm/llvm-project/commit/c3bc61d72f8da9a2b45e610ee3c2ccfc5f884f69
DIFF:
https://github.com/llvm/llvm-project/commit/c3bc61d72f8da9a2b45e610ee3c2ccfc5f884f69.diff
LOG:
Author: Manuel Klimek
Date: 2022-11-26T18:23:42Z
New Revision: 49aca00d63e14df8bc68fc4329e6cbc9c9805eb8
URL:
https://github.com/llvm/llvm-project/commit/49aca00d63e14df8bc68fc4329e6cbc9c9805eb8
DIFF:
https://github.com/llvm/llvm-project/commit/49aca00d63e14df8bc68fc4329e6cbc9c9805eb8.diff
LOG:
Author: Manuel Klimek
Date: 2022-11-25T14:26:47Z
New Revision: d65019bbcb0a33502ebfc3cfc492e4d3cee9c7b7
URL:
https://github.com/llvm/llvm-project/commit/d65019bbcb0a33502ebfc3cfc492e4d3cee9c7b7
DIFF:
https://github.com/llvm/llvm-project/commit/d65019bbcb0a33502ebfc3cfc492e4d3cee9c7b7.diff
LOG:
Fixed in ca8c6156f27003ffa0e24bace2be7c25307f50a3.
On Thu, Jul 21, 2022 at 3:21 PM Manuel Klimek wrote:
> Ping :)
>
> On Mon, Jul 18, 2022 at 1:22 PM Manuel Klimek wrote:
>
>> Ping :)
>>
>> On Wed, Jul 13, 2022 at 11:43 AM Manuel Klimek wrote:
>>
>>> This is a functional change, as it removes
Author: Manuel Klimek
Date: 2022-11-25T13:53:34Z
New Revision: ca8c6156f27003ffa0e24bace2be7c25307f50a3
URL:
https://github.com/llvm/llvm-project/commit/ca8c6156f27003ffa0e24bace2be7c25307f50a3
DIFF:
https://github.com/llvm/llvm-project/commit/ca8c6156f27003ffa0e24bace2be7c25307f50a3.diff
LOG:
Ping :)
On Mon, Jul 18, 2022 at 1:22 PM Manuel Klimek wrote:
> Ping :)
>
> On Wed, Jul 13, 2022 at 11:43 AM Manuel Klimek wrote:
>
>> This is a functional change, as it removes the debug output when the
>> tokens do not match, which is important for understanding test failures.
>>
>> On Wed, Ju
Ping :)
On Wed, Jul 13, 2022 at 11:43 AM Manuel Klimek wrote:
> This is a functional change, as it removes the debug output when the
> tokens do not match, which is important for understanding test failures.
>
> On Wed, Jul 13, 2022 at 1:47 AM Jorge Gorbe Moya via cfe-commits <
> cfe-commits@lis
This is a functional change, as it removes the debug output when the tokens
do not match, which is important for understanding test failures.
On Wed, Jul 13, 2022 at 1:47 AM Jorge Gorbe Moya via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> Author: Jorge Gorbe Moya
> Date: 2022-07-12T16:46
Author: Manuel Klimek
Date: 2022-07-12T07:43:26Z
New Revision: f44d28f840c0b0877b09d5547fd09e191bbdc90e
URL:
https://github.com/llvm/llvm-project/commit/f44d28f840c0b0877b09d5547fd09e191bbdc90e
DIFF:
https://github.com/llvm/llvm-project/commit/f44d28f840c0b0877b09d5547fd09e191bbdc90e.diff
LOG:
Author: Manuel Klimek
Date: 2022-07-12T07:11:46Z
New Revision: d6d0dc1f45377ddaf5c10a48d64b09308b71501a
URL:
https://github.com/llvm/llvm-project/commit/d6d0dc1f45377ddaf5c10a48d64b09308b71501a
DIFF:
https://github.com/llvm/llvm-project/commit/d6d0dc1f45377ddaf5c10a48d64b09308b71501a.diff
LOG:
Author: Manuel Klimek
Date: 2022-07-05T08:23:42Z
New Revision: 4de0680fbf4e4a9b9136ab5ee1ca549954eb8590
URL:
https://github.com/llvm/llvm-project/commit/4de0680fbf4e4a9b9136ab5ee1ca549954eb8590
DIFF:
https://github.com/llvm/llvm-project/commit/4de0680fbf4e4a9b9136ab5ee1ca549954eb8590.diff
LOG:
Author: Manuel Klimek
Date: 2021-12-01T14:39:00+01:00
New Revision: 4dcfae6a003aa541600e5af42c0bec5d8e1abef0
URL:
https://github.com/llvm/llvm-project/commit/4dcfae6a003aa541600e5af42c0bec5d8e1abef0
DIFF:
https://github.com/llvm/llvm-project/commit/4dcfae6a003aa541600e5af42c0bec5d8e1abef0.diff
Author: Manuel Klimek
Date: 2021-12-01T11:57:41+01:00
New Revision: d688b31628004ed9e109e63c2b43701f97252ff3
URL:
https://github.com/llvm/llvm-project/commit/d688b31628004ed9e109e63c2b43701f97252ff3
DIFF:
https://github.com/llvm/llvm-project/commit/d688b31628004ed9e109e63c2b43701f97252ff3.diff
Author: Manuel Klimek
Date: 2021-12-01T11:23:04+01:00
New Revision: 59788422609433c50c3d3c16ca531fa56b9acb4f
URL:
https://github.com/llvm/llvm-project/commit/59788422609433c50c3d3c16ca531fa56b9acb4f
DIFF:
https://github.com/llvm/llvm-project/commit/59788422609433c50c3d3c16ca531fa56b9acb4f.diff
Author: Manuel Klimek
Date: 2021-11-24T12:58:35+01:00
New Revision: 1b5a43ac3f1113cd0512752e021fc70740726698
URL:
https://github.com/llvm/llvm-project/commit/1b5a43ac3f1113cd0512752e021fc70740726698
DIFF:
https://github.com/llvm/llvm-project/commit/1b5a43ac3f1113cd0512752e021fc70740726698.diff
Author: Manuel Klimek
Date: 2021-11-22T11:08:38+01:00
New Revision: 84bf5e328664db2e744c4651c52d2460b1733d09
URL:
https://github.com/llvm/llvm-project/commit/84bf5e328664db2e744c4651c52d2460b1733d09
DIFF:
https://github.com/llvm/llvm-project/commit/84bf5e328664db2e744c4651c52d2460b1733d09.diff
Author: Manuel Klimek
Date: 2021-11-19T14:44:06+01:00
New Revision: c2271926a4fc395e05cf75a8e57c2dfab1f02d3d
URL:
https://github.com/llvm/llvm-project/commit/c2271926a4fc395e05cf75a8e57c2dfab1f02d3d
DIFF:
https://github.com/llvm/llvm-project/commit/c2271926a4fc395e05cf75a8e57c2dfab1f02d3d.diff
Author: Manuel Klimek
Date: 2020-09-25T14:08:13+02:00
New Revision: e336b74c995d665bc3fb75164375bbb0f78f516c
URL:
https://github.com/llvm/llvm-project/commit/e336b74c995d665bc3fb75164375bbb0f78f516c
DIFF:
https://github.com/llvm/llvm-project/commit/e336b74c995d665bc3fb75164375bbb0f78f516c.diff
Author: Manuel Klimek
Date: 2020-07-07T11:56:34+02:00
New Revision: 8c2a613976075368a1f6e3ac3c9c8b1927b465ec
URL:
https://github.com/llvm/llvm-project/commit/8c2a613976075368a1f6e3ac3c9c8b1927b465ec
DIFF:
https://github.com/llvm/llvm-project/commit/8c2a613976075368a1f6e3ac3c9c8b1927b465ec.diff
Author: Manuel Klimek
Date: 2020-05-13T16:37:58+02:00
New Revision: 53cc90f789996d1e1edc6a9233a85ce8d658aadd
URL:
https://github.com/llvm/llvm-project/commit/53cc90f789996d1e1edc6a9233a85ce8d658aadd
DIFF:
https://github.com/llvm/llvm-project/commit/53cc90f789996d1e1edc6a9233a85ce8d658aadd.diff
*From: *MyDeveloperDay via Phabricator
*Date: *Fri, May 10, 2019 at 12:30 PM
*To: * , , , <
krasi...@google.com>, ,
*Cc: * , , , <
marcosbe...@gmail.com>, , , <
shua2...@gmail.com>, , , <
vit9...@avp.su>, , , <
mydeveloper...@gmail.com>, , <
bderickson+llvm...@gmail.com>, , <
vee...@veegee.org>,
On Mon, Aug 6, 2018 at 4:47 PM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> Ping.
>
> Manuel, I still don't see how could we apply `match(anyOf(node),
> hasDescendant(node))` to the problem of general subtree traversal.
> (I'd like to have support
On Mon, Jul 30, 2018 at 10:02 AM Stephen Kelly via Phabricator <
revi...@reviews.llvm.org> wrote:
> steveire added a comment.
>
> In https://reviews.llvm.org/D49840#1176405, @klimek wrote:
>
> > Usually we use match(anyOf(node), hasDescendant(node)). Or did I
> misunderstand what you want?
>
>
> S
On Fri, Jul 27, 2018 at 12:43 PM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> > Finder.match also has an overload that takes the node. Can you wrap
> "Pattern" above in the anyOf(hasDescendant(...), ...) and match on the node
> instead of the full
On Fri, Jul 27, 2018 at 10:39 AM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> > MatchFinder::match allows you to match a node. Wrapping your matcher
> code with:
> > auto m = ;
> > ast_matchers::match(anyOf(m, hashDescendant(m)), node, context);
On Thu, Jul 26, 2018 at 12:44 PM Gabor Marton via Phabricator <
revi...@reviews.llvm.org> wrote:
> martong added a comment.
>
> > Usually we use match(anyOf(node), hasDescendant(node)). Or did I
> misunderstand what you want?
>
> My understanding is that, the free function template `match` uses
>
Author: klimek
Date: Wed May 9 06:20:03 2018
New Revision: 331875
URL: http://llvm.org/viewvc/llvm-project?rev=331875&view=rev
Log:
Do not warn on unused parameters for functions with empty bodies.
If a function has an empty body, all parameters are trivially unused.
Modified:
clang-tools-e
Author: klimek
Date: Mon Apr 23 04:47:59 2018
New Revision: 330580
URL: http://llvm.org/viewvc/llvm-project?rev=330580&view=rev
Log:
Fix tests after changes to clang-format in r330573.
We do now both:
- stop reformatting a sequence after a closing brace in more cases, in
order to not misindent
Author: klimek
Date: Mon Apr 23 02:34:26 2018
New Revision: 330573
URL: http://llvm.org/viewvc/llvm-project?rev=330573&view=rev
Log:
Format closing braces when reformatting the line containing the opening brace.
This required a couple of yaks to be shaved:
1. MatchingOpeningBlockLineIndex was mis
Author: klimek
Date: Wed Apr 11 07:51:54 2018
New Revision: 329816
URL: http://llvm.org/viewvc/llvm-project?rev=329816&view=rev
Log:
Fix bugs around handling C++11 attributes.
Previously, we would format:
int a() { ... }
[[unused]] int b() { ... }
as...
int a() {} [[unused] int b() {}
Now w
Author: klimek
Date: Mon Dec 4 00:53:16 2017
New Revision: 319642
URL: http://llvm.org/viewvc/llvm-project?rev=319642&view=rev
Log:
Fix bug where we wouldn't break columns over the limit.
Before, we would not break:
int a = foo(/* trailing */);
when the end of /* trailing */ was exactly the co
Author: klimek
Date: Fri Dec 1 05:28:08 2017
New Revision: 319541
URL: http://llvm.org/viewvc/llvm-project?rev=319541&view=rev
Log:
Better trade-off for excess characters vs. staying within the column limits.
When we break a long line like:
Column limit: 21
|
// foo foo f
Author: klimek
Date: Wed Nov 29 07:09:12 2017
New Revision: 319318
URL: http://llvm.org/viewvc/llvm-project?rev=319318&view=rev
Log:
Fix 'control reaches end of non-void' warning by using llvm_unreachable.
Modified:
cfe/trunk/lib/Format/BreakableToken.cpp
Modified: cfe/trunk/lib/Format/Break
Author: klimek
Date: Wed Nov 29 06:29:43 2017
New Revision: 319314
URL: http://llvm.org/viewvc/llvm-project?rev=319314&view=rev
Log:
Restructure how we break tokens.
This fixes some bugs in the reflowing logic and splits out the concerns
of reflowing from BreakableToken.
Things to do after this
Author: klimek
Date: Fri Nov 17 03:17:15 2017
New Revision: 318515
URL: http://llvm.org/viewvc/llvm-project?rev=318515&view=rev
Log:
Implement more accurate penalty & trade-offs while breaking protruding tokens.
For each line that we break in a protruding token, compute whether the
penalty of bre
Author: klimek
Date: Tue Nov 14 01:19:53 2017
New Revision: 318141
URL: http://llvm.org/viewvc/llvm-project?rev=318141&view=rev
Log:
Refactor ContinuationIndenter's breakProtrudingToken logic.
Create more orthogonal pieces. The restructuring made it easy to try out
several alternatives to D33589,
On Thu, Nov 9, 2017 at 4:02 AM Richard Smith - zygoloid via Phabricator <
revi...@reviews.llvm.org> wrote:
> rsmith added a comment.
>
> I'm not entirely sure what's happening with this and
> https://reviews.llvm.org/D38818, but the direction looks good to me, and
> I left a couple of comments on
Author: klimek
Date: Wed Sep 20 02:51:03 2017
New Revision: 313744
URL: http://llvm.org/viewvc/llvm-project?rev=313744&view=rev
Log:
clang-format clang-format.
Modified:
cfe/trunk/lib/Format/BreakableToken.cpp
cfe/trunk/lib/Format/ContinuationIndenter.cpp
cfe/trunk/lib/Format/Format.c
Author: klimek
Date: Wed Sep 20 02:29:37 2017
New Revision: 313742
URL: http://llvm.org/viewvc/llvm-project?rev=313742&view=rev
Log:
Fix clang-format's detection of structured bindings.
Correctly determine when [ is part of a structured binding instead of a
lambda.
To be able to reuse the implem
Author: klimek
Date: Tue Sep 19 02:59:30 2017
New Revision: 313622
URL: http://llvm.org/viewvc/llvm-project?rev=313622&view=rev
Log:
Fix formatting of lambda introducers with initializers.
Most of the work was already done when we introduced a look-behind based
lambda introducer detection.
This
Author: klimek
Date: Fri Aug 4 01:41:42 2017
New Revision: 310041
URL: http://llvm.org/viewvc/llvm-project?rev=310041&view=rev
Log:
Fix typo and update documentation.
The hasDeclaration documentation was outdated after r288366.
Modified:
cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h
Mo
Author: klimek
Date: Wed Aug 2 06:13:11 2017
New Revision: 309810
URL: http://llvm.org/viewvc/llvm-project?rev=309810&view=rev
Log:
Adapt clang-tidy checks to changing semantics of hasDeclaration.
Differential Revision: https://reviews.llvm.org/D36154
Modified:
clang-tools-extra/trunk/clang
Author: klimek
Date: Wed Aug 2 06:04:44 2017
New Revision: 309809
URL: http://llvm.org/viewvc/llvm-project?rev=309809&view=rev
Log:
Unify and simplify the behavior of the hasDeclaration matcher.
Originally, we weren't able to match on Type nodes themselves (only QualType),
so the hasDeclaration
Author: klimek
Date: Tue Jul 25 04:34:55 2017
New Revision: 308969
URL: http://llvm.org/viewvc/llvm-project?rev=308969&view=rev
Log:
Fix spelling of FileCheck in test.
Modified:
cfe/trunk/test/CodeGen/x86-ms-inline-asm-enum_feature.cpp
Modified: cfe/trunk/test/CodeGen/x86-ms-inline-asm-enum_
Author: klimek
Date: Tue Jul 25 03:22:06 2017
New Revision: 308962
URL: http://llvm.org/viewvc/llvm-project?rev=308962&view=rev
Log:
Fix incorrect use of current directory to find moved paths in ASTReader.
CurrentDir was set as the path of the current module, but that can change as
part of a chai
Author: klimek
Date: Tue Jul 18 03:15:07 2017
New Revision: 308290
URL: http://llvm.org/viewvc/llvm-project?rev=308290&view=rev
Log:
Add autoload cookies for clang-include-fixer lisp functions.
Annotate all public functions with the autoload magic cookie so that
update-directory-autoloads will fi
Thx. Submitted as r308185.
On Mon, Jul 17, 2017 at 4:28 PM Erik Uhlmann wrote:
> I don’t have commit access, so I’d need you to check it in. Thanks for
> your help!
>
>
>
> *From: *Manuel Klimek
> *Date: *Monday, July 17, 2017 at 03:31
> *To: *Erik Uhlmann , "cfe-commits@lists.llvm.org" <
> cfe
Author: klimek
Date: Mon Jul 17 08:27:53 2017
New Revision: 308185
URL: http://llvm.org/viewvc/llvm-project?rev=308185&view=rev
Log:
Fix dereference of pointers in throw statements.
Before:
throw * x;
After:
throw *x;
Patch by Erik Uhlmann.
Modified:
cfe/trunk/lib/Format/TokenAnnotator
LG, thanks for the patch. For next time, it helps to use phabricator to
make people catch patches faster :)
Do you have commit access or do you need me to check it in?
On Thu, Jul 6, 2017 at 6:53 PM Erik Uhlmann via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> When dereferencing a pointer
Lg
On Tue, Jul 11, 2017, 8:07 PM Sterling Augustine via Phabricator <
revi...@reviews.llvm.org> wrote:
> saugustine added a comment.
>
> Manuel, What do you think?
>
>
> https://reviews.llvm.org/D35131
>
>
>
>
___
cfe-commits mailing list
cfe-commits@li
On Fri, Jun 16, 2017 at 8:26 PM Dan Ciliske via Phabricator <
revi...@reviews.llvm.org> wrote:
> dciliske added a comment.
>
> So... how should I get something added? That patch has been sitting for a
> couple weeks.
>
> Should I work on that patch? If so, how do I work on it? This is the first
>
Hey ho,
this looks like a really cool new feature, and the CL looks good to me; I
was wondering whether in the future we can send CLs like this through
pre-commit review, or have an RFC email thread. If you have more stuff
landing, a single RFC email thread describing how the features work
togethe
On Thu, Feb 23, 2017 at 10:40 PM Sam McCall wrote:
>
>
> On Feb 23, 2017 8:48 PM, "Haojian Wu via Phabricator" <
> revi...@reviews.llvm.org> wrote:
>
> hokein added inline comments.
>
>
>
> Comment at:
> unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp:40
> + voi
Author: klimek
Date: Thu Feb 23 10:02:53 2017
New Revision: 295988
URL: http://llvm.org/viewvc/llvm-project?rev=295988&view=rev
Log:
Make clang-include-fixer--insert-line work when the difference is on an empty
line
`clang-include-fixer--insert-line` has an off-by-one error because it
uses `(got
Author: klimek
Date: Wed Feb 22 03:21:22 2017
New Revision: 295818
URL: http://llvm.org/viewvc/llvm-project?rev=295818&view=rev
Log:
Completion related fixes for clang-include-fixer.el.
1. Quitting inside a process sentinel is not allowed, but the sentinel invokes
completion, where the user is fr
Author: klimek
Date: Wed Feb 22 02:26:04 2017
New Revision: 295814
URL: http://llvm.org/viewvc/llvm-project?rev=295814&view=rev
Log:
Adds a hook clang-include-fixer-add-include-hook that is invoked with the path
and type of the added include.
This patch also adds a new function clang-include-fix
It's by design. Do we want to change this? I always had the impression
turning on the state changes for the list is a bit noisy, but I'm happy if
that's not the general sentiment.
On Mon, Jan 16, 2017, 11:07 PM Benjamin Kramer wrote:
I got an email where it says that I accepted the revision. Loo
Author: klimek
Date: Wed Jan 11 04:32:47 2017
New Revision: 291664
URL: http://llvm.org/viewvc/llvm-project?rev=291664&view=rev
Log:
Improve include fixer's ranking by taking the paths into account.
Instead of just using popularity, we also take into account how similar the
path of the current fi
Author: klimek
Date: Wed Jan 11 01:20:46 2017
New Revision: 291653
URL: http://llvm.org/viewvc/llvm-project?rev=291653&view=rev
Log:
Only launch asynchronously if threading is enabled.
Modified:
clang-tools-extra/trunk/include-fixer/SymbolIndexManager.h
Modified: clang-tools-extra/trunk/incl
Testing phab parsing...
On Wed, Jan 4, 2017 at 4:01 PM Haojian Wu via Phabricator via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL290967: [clang-move] Support moving type alias
> declarations. (a
On Mon, Dec 5, 2016 at 3:53 PM Antonio Maiorano wrote:
> Hi Manuel,
>
> Okay, I'll submit both patches via phabricator as you recommend. I'll add
> you, and I'll add Hans Wennborg and Zachary Turner, who were both involved
> with the first clang-format-vsix patch I worked on:
> http://lists.llvm.
Awesome, thanks for working on this. If you submit the patches via
phabricator (http://llvm.org/docs/Phabricator.html) I'll get to it faster
:) Feel free to directly add me as reviewer, btw (add 'klimek').
On Sat, Dec 3, 2016 at 6:53 AM Antonio Maiorano via cfe-commits <
cfe-commits@lists.llvm.org
Author: klimek
Date: Thu Dec 1 09:45:06 2016
New Revision: 288366
URL: http://llvm.org/viewvc/llvm-project?rev=288366&view=rev
Log:
Adds hasUnqualifiedDesugaredType to allow matching through type sugar.
Differential Revision: https://reviews.llvm.org/D27207
Modified:
cfe/trunk/docs/LibASTMa
klimek created this revision.
klimek added reviewers: rsmith, lukasza.
klimek added a subscriber: cfe-commits.
Originally, we weren't able to match on Type nodes themselves (only QualType),
so the hasDeclaration matcher was initially written to give what we thought are
reasonable results for QualT
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D26745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
On Sun, Nov 6, 2016 at 1:18 AM Michał Górny via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, 14 Oct 2016 17:17:59 +
> Joshua Hurwitz via cfe-commits wrote:
>
> > See attached.
> >
> > Returning a bool from main is a special case of return type mismatch. The
> > common convention
klimek added a comment.
Ok, makes sense. Can you add a comment to the function that explains what
happens with replacements for files that do not exist (we ignore them, unless
I'm mistaken). Otherwise LG.
https://reviews.llvm.org/D26288
___
cfe-co
klimek added a comment.
In https://reviews.llvm.org/D26288#586932, @ioeric wrote:
> - Addressed comments: handle non-existing files.
We're not really handling them now though? We're just printing an error?
My point is that we might run the replacement generation on a distributed
system, and t
+richard
On Fri, Oct 14, 2016 at 10:18 AM Joshua Hurwitz via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> See attached.
>
> Returning a bool from main is a special case of return type mismatch. The
> common convention when returning a bool is that 'true' (== 1) indicates
> success and 'fals
klimek added a comment.
If the files do not exist, how does this work? Won't that potentially give
different results if the files exist locally vs if they don't?
https://reviews.llvm.org/D26288
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: klimek
Date: Tue Nov 1 05:30:50 2016
New Revision: 285685
URL: http://llvm.org/viewvc/llvm-project?rev=285685&view=rev
Log:
Fix parenthesized assert (nfc).
Modified:
cfe/trunk/lib/AST/Decl.cpp
Modified: cfe/trunk/lib/AST/Decl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/l
klimek accepted this revision.
klimek added a comment.
Yep, makes sense. Open issues are all about types :)
https://reviews.llvm.org/D26032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
klimek added a comment.
> It's mostly about how much is "underlined". If there is only a caret, that
> quite often translates into a single character being pointed out, instead of
> an identifier (i.e. the first character). Hene the extension of the range.
Aren't we mostly doing token positions
Author: klimek
Date: Tue Oct 25 06:31:22 2016
New Revision: 285060
URL: http://llvm.org/viewvc/llvm-project?rev=285060&view=rev
Log:
include-fixer: Don't overwrite buffer changes
Raise a signal if the buffer has been modified before replacing it, to
avoid overwriting users' changes.
Patch by Phi
Author: klimek
Date: Tue Oct 25 06:30:28 2016
New Revision: 285059
URL: http://llvm.org/viewvc/llvm-project?rev=285059&view=rev
Log:
Load clang-include-fixer.el from the unit test suite so that the unit tests can
run in batch mode.
Patch by Philipp Stephani.
Modified:
clang-tools-extra/trun
klimek added inline comments.
Comment at: unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:2119
+ "template \n"
+ "void Function(Namespace::Template param) {\n"
+ " param.Method();\n"
lukasza wrote:
> klimek wrote:
> > Given your use case: why d
Author: klimek
Date: Tue Oct 11 04:25:34 2016
New Revision: 283864
URL: http://llvm.org/viewvc/llvm-project?rev=283864&view=rev
Log:
Delete clang-completion-mode.el.
It has been unmaintained for a while (last change was more than four
years ago), and it appears not widely used.
By now there are m
Author: klimek
Date: Tue Oct 11 04:21:20 2016
New Revision: 283863
URL: http://llvm.org/viewvc/llvm-project?rev=283863&view=rev
Log:
clang-include-fixer.el: Don't prompt the user about killing clang-include-fixer
processes
By default, Emacs prompts the user when killing processes on exit. This i
Author: klimek
Date: Tue Oct 11 04:15:10 2016
New Revision: 283861
URL: http://llvm.org/viewvc/llvm-project?rev=283861&view=rev
Log:
Make Emacs libraries compatible with Emacs 24.
Emacs 24 doesn't have format-message, fall back to format in that case.
Patch by Philipp Stephani.
Modified:
cl
Author: klimek
Date: Mon Oct 10 05:22:40 2016
New Revision: 283736
URL: http://llvm.org/viewvc/llvm-project?rev=283736&view=rev
Log:
Use `let' instead of `let*' in one place where `let*' isn't necessary
Differential Revision: https://reviews.llvm.org/D25395
Patch by Philipp Stephani.
Modified:
Author: klimek
Date: Tue Oct 4 04:53:04 2016
New Revision: 283206
URL: http://llvm.org/viewvc/llvm-project?rev=283206&view=rev
Log:
Minor cleanups in clang-format.el.
- Enable lexical binding
- Formatting
- Enable file name completion for the clang-format-executable variable
- Add a missing docs
klimek added inline comments.
> ioeric wrote in MigrateTool.cpp:52
> That sounds like a good design, but I'm not sure if we need this at this
> point since actions on affected files would simply be renaming and include
> fixing now and in the foreseeable future.
Well, my main concern is how we
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rL LLVM
https://reviews.llvm.org/D25049
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
klimek added inline comments.
> MigrateTool.cpp:52
> + // Get all files that are affected by the migration, i.e. users of the
> symbol.
> + auto Files =
> Env.getAffectedFilesFinder().getAffectedFiles(Spec.getOldName());
> + if (!Files)
I'm wondering whether we really want to evolve this to
On Wed, Sep 28, 2016 at 2:58 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Wed Sep 28 07:49:14 2016
> New Revision: 282583
>
> URL: http://llvm.org/viewvc/llvm-project?rev=282583&view=rev
> Log:
> Trying to buildbot failures caused by r282577.
>
A bit m
Author: klimek
Date: Wed Sep 28 05:20:10 2016
New Revision: 282573
URL: http://llvm.org/viewvc/llvm-project?rev=282573&view=rev
Log:
Fix warnings in clang-completion-mode.el.
- Use defvar to declare variables
- Don't use delete-backward-char, which is for interactive use only
Patch by Philipp St
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+// `R` and `Replaces` are order-independent if applying them in either order
+// has the same effect, so
klimek added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:179-181
@@ +178,5 @@
+llvm::Expected
+Replacements::mergeIfOrderIndependent(const Replacement &R) const {
+ Replacements Rs(R);
+ Replacements RsShiftedByReplaces(getReplacementInChangedCode(R));
+ Repla
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:177-178
@@ +176,4 @@
+ /// - are insertions at the same offset and applying them in either order
+ /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the
+ /// other
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:177-178
@@ +176,4 @@
+ /// - are insertions at the same offset and applying them in either order
+ /// has the same effect, i.e. X + Y = Y + X if one inserts text X and the
+ /// other
1 - 100 of 588 matches
Mail list logo
