mcarrasco added a comment.
@jroelofs yes please :p
After you mentioned it, I rechecked the guidelines and read:
> Once a patch has been reviewed and approved on Phabricator it can then be
> committed to trunk. If you do not have commit access, someone has to commit
> the change for you (with a
mcarrasco marked an inline comment as done.
mcarrasco added a comment.
Great!
Thanks a lot for your answer @jroelofs !!
Then, do you think this current proposal to BareMetal.cpp is enough?
Best,
Manuel.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87164/new/
https://reviews.llvm.org
mcarrasco marked an inline comment as done.
mcarrasco added a comment.
@jroelofs no worries, thanks a lot for your time.
Please tell me if I understood you correctly.
It is acceptable just to append the -lgcc if -rtlib=libgcc is used, although
the user is responsible to ensure that correct path
mcarrasco updated this revision to Diff 291262.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87164/new/
https://reviews.llvm.org/D87164
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/test/Driver/baremetal.cpp
Index: clang/test/Driver/baremetal.cpp
=
mcarrasco created this revision.
mcarrasco added reviewers: jroelofs, clang.
mcarrasco added a project: clang-modules.
Herald added subscribers: cfe-commits, abidh, kristof.beyls.
Herald added a project: clang.
mcarrasco requested review of this revision.
The Baremetal toolchain currently has a fi
