mcarrasco added a comment. @jroelofs yes please :p
After you mentioned it, I rechecked the guidelines and read: > Once a patch has been reviewed and approved on Phabricator it can then be > committed to trunk. If you do not have commit access, someone has to commit > the change for you (with attribution). It is sufficient to add a comment to > the approved review indicating you cannot commit the patch yourself. Best, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87164/new/ https://reviews.llvm.org/D87164 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits