https://github.com/ldionne approved this pull request.
I'm fine with the libc++ part of this patch. I like this new approach a lot
more. I think it gives us most of the benefits without raising difficult
questions.
https://github.com/llvm/llvm-project/pull/116709
__
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/138524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Merging since this is both small and seems obviously correct. I technically
don't have oversight of libc, but I don't think the owners would oppose this
change.
https://github.com/llvm/llvm-project/pull/138524
___
cfe-commits mailing l
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/138524
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
I think this is great and I don't think it impacts libc++ since we moved off of
the builtin a few months ago (in preparation for these kinds of changes).
https://github.com/llvm/llvm-project/pull/138835
_
https://github.com/ldionne commented:
I don't have comment on the diff but I think it's great that AIX is moving
towards the mechanism that we want to use for all targets!
https://github.com/llvm/llvm-project/pull/132821
___
cfe-commits mailing list
c
https://github.com/ldionne commented:
I think this should also impact the set of headers being searched. On
per-target runtimes, I think we look for libc++ headers under
`include/c++/v1/` in addition to `include/c++/v1` (since that's where
`__config_site` ends up)? I'm not super familiar with
https://github.com/ldionne approved this pull request.
Waiving `reviewers/libcxx` code review.
https://github.com/llvm/llvm-project/pull/132870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/ldionne commented:
I would like this patch to also deprecate the old builtin. I think the
existence of the old builtin is going to cause significant confusion and risk
introducing bugs. I always imagined that the old builtin would in fact be
"fixed in place" once the Standar
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
@@ -223,6 +223,13 @@ endif()
# This can be used to detect whether we're in the runtimes build.
set(LLVM_RUNTIMES_BUILD ON)
+if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME}
MATCHES "AIX")
+ # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s
@@ -0,0 +1,646 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Sure, but I am not certain why you added some newlines though.
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -102,8 +102,9 @@ _LIBUNWIND_EXPORT uintptr_t _Unwind_GetIP(struct
_Unwind_Context *context) {
}
/// Not used in Wasm.
-_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *context,
- uintptr_t value) {}
+_LIBUNWIND_EXPORT void
+_
https://github.com/ldionne commented:
IMO this is reasonable but it's simpler to drop the parameter names in this
case, no need for `[[maybe_unused]]`.
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/125412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -116,7 +117,7 @@ _Unwind_GetLanguageSpecificData(struct _Unwind_Context
*context) {
/// Not used in Wasm.
_LIBUNWIND_EXPORT uintptr_t
-_Unwind_GetRegionStart(struct _Unwind_Context *context) {
+_Unwind_GetRegionStart([[maybe_unused]] struct _Unwind_Context *context) {
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/119241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Closing in the meantime, please reopen this PR or create a new one with the new
approach whenever you're ready!
https://github.com/llvm/llvm-project/pull/119241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
ldionne wrote:
Which identifiers exactly are causing issues? I think we could tackle that by
adding them to `__undef_macros` and to `_LIBCPP_PUSH_MACROS` and
`_LIBCPP_POP_MACROS` instead. That's generally what we do to work around name
collisions on individual platforms: it's more robust and d
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/123098
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -121,11 +121,12 @@ def InitPriorityDocs : Documentation {
In C++, the order in which global variables are initialized across translation
units is unspecified, unlike the ordering within a single translation unit. The
``init_priority`` attribute allows you to specify a relati
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/123098
>From 05bb2f8554e7dab1e084738155348389284bcc36 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 15 Jan 2025 13:03:04 -0500
Subject: [PATCH 1/2] [clang] Improve the documentation for the init_priority
attr
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/123098
The documentation wasn't very clear about whether ordering is controlled within
or across TUs, and same for dylibs. Clarify that, and also add mentions for the
state of support on Mach-O platforms.
>From 05bb2
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Closing as stale, please feel free to reopen if you want to pursue this.
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
> > @erichkeane @ldionne should the `libcxx` tests
> > ([common_reference.compile.pass.cpp](https://github.com/llvm/llvm-project/blob/main/libcxx/test/std/utilities/meta/meta.trans/meta.trans.other/common_reference.compile.pass.cpp),
> >
> > [apply_extended_types.pass.cpp](https
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"],
"internal-externc-isystem">,
"implicit extern \"C\" semantics; these are assumed to not be "
"user-provided and are used to model system and standard headers' "
"paths.">;
+d
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"],
"internal-externc-isystem">,
"implicit extern \"C\" semantics; these are assumed to not be "
"user-provided and are used to model system and standard headers' "
"paths.">;
+d
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120149
>From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 16 Dec 2024 13:28:38 -0500
Subject: [PATCH 1/8] [clang][Darwin] Remove legacy framework search path logic
in
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"],
"internal-externc-isystem">,
"implicit extern \"C\" semantics; these are assumed to not be "
"user-provided and are used to model system and standard headers' "
"paths.">;
+d
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120149
>From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 16 Dec 2024 13:28:38 -0500
Subject: [PATCH 1/7] [clang][Darwin] Remove legacy framework search path logic
in
@@ -8265,6 +8265,11 @@ def internal_externc_isystem : Separate<["-"],
"internal-externc-isystem">,
"implicit extern \"C\" semantics; these are assumed to not be "
"user-provided and are used to model system and standard headers' "
"paths.">;
+d
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120149
>From ac165075f270af65395a3709a1457b61ed97ea31 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 16 Dec 2024 13:28:38 -0500
Subject: [PATCH 1/6] [clang][Darwin] Remove legacy framework search path logic
in
@@ -2539,6 +2550,18 @@ void DarwinClang::AddClangSystemIncludeArgs(const
llvm::opt::ArgList &DriverArgs
llvm::sys::path::append(P, "usr", "include");
addExternCSystemInclude(DriverArgs, CC1Args, P.str());
}
+
+ // Add default framework search paths
+ auto addFramew
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120149
>From e578bd75d82a5ff16168222e4f30c32f9aa5e6bd Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 16 Dec 2024 13:28:38 -0500
Subject: [PATCH 1/3] [clang][Darwin] Remove legacy framework search path logic
in
@@ -2539,6 +2550,18 @@ void DarwinClang::AddClangSystemIncludeArgs(const
llvm::opt::ArgList &DriverArgs
llvm::sys::path::append(P, "usr", "include");
addExternCSystemInclude(DriverArgs, CC1Args, P.str());
}
+
+ // Add default framework search paths
+ auto addFramew
@@ -0,0 +1,26 @@
+// UNSUPPORTED: system-windows
+// Windows is unsupported because we use the Unix path separator `/` in the
test.
+
+// Add default directories before running clang to check default
+// search paths.
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: cp -R %S/Inputs/M
@@ -1,13 +1,6 @@
-// RUN: %clang -cc1 -fcuda-is-device -isysroot /var/empty \
-// RUN: -triple nvptx-nvidia-cuda -aux-triple i386-apple-macosx \
-// RUN: -E -fcuda-is-device -v -o /dev/null -x cuda %s 2>&1 | FileCheck %s
-
-// RUN: %clang -cc1 -isysroot /var/empty \
-// RUN:
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/3] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/2] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
@@ -1,13 +1,6 @@
-// RUN: %clang -cc1 -fcuda-is-device -isysroot /var/empty \
-// RUN: -triple nvptx-nvidia-cuda -aux-triple i386-apple-macosx \
-// RUN: -E -fcuda-is-device -v -o /dev/null -x cuda %s 2>&1 | FileCheck %s
-
-// RUN: %clang -cc1 -isysroot /var/empty \
-// RUN:
ldionne wrote:
Sorry for the spurious request for review here, this is the wrong PR.
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths(
if (triple.isOSDarwin()) {
ldionne wrote:
I'm trying to revive this as https://github.com/llvm/llvm-project/pull/120149
https://github.com/llvm/llvm-project/pull/118543
_
ldionne wrote:
@brad0 Revived as https://github.com/llvm/llvm-project/pull/120149
https://github.com/llvm/llvm-project/pull/75841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/120149
This removes a long standing piece of technical debt. Most other platforms have
moved all their header search path logic to the driver, but Darwin still had
some logic for setting framework search paths present
@@ -339,13 +340,11 @@ void InitHeaderSearch::AddDefaultIncludePaths(
if (triple.isOSDarwin()) {
ldionne wrote:
FWIW I agree with your assessment @cyndyishida. I just did the exercise of
picking up #75841 and we basically need to pass `-iframework` from the dr
@@ -150,3 +150,23 @@ clang::parseDarwinSDKInfo(llvm::vfs::FileSystem &VFS,
StringRef SDKRootPath) {
return llvm::make_error("invalid SDKSettings.json",
llvm::inconvertibleErrorCode());
}
+
+// For certain platforms/environments al
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 7b8f1538b452d6c16874d0f076baa2d54abb66b0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends
by a
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120013
>From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Sun, 15 Dec 2024 21:18:23 +0300
Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan
---
libunwind/test/
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/120013
>From 51c5f794e4c3253675f83821fd58bdefdfcf0c67 Mon Sep 17 00:00:00 2001
From: Dmitry Chestnykh
Date: Sun, 15 Dec 2024 21:18:23 +0300
Subject: [PATCH] [Libunwind] Don't XFAIL tests with msan
---
libunwind/test/
https://github.com/ldionne approved this pull request.
LGTM if the CI is green.
https://github.com/llvm/llvm-project/pull/120013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Rebased onto `main` to re-trigger CI, which should solve the errors you were
seeing.
I don't remember why these `XFAIL`s were added, but if the CI passes with them
removed, I'm happy.
https://github.com/llvm/llvm-project/pull/120013
_
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/119370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/119370
>From 259f1eecac3abf0ffdc5c41ef9edae35c604ee26 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 10 Dec 2024 07:42:00 -0500
Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying
to
ldionne wrote:
Gentle ping
https://github.com/llvm/llvm-project/pull/117362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/119370
>From c9f83596fbfa0423245eecbc9c4d9f65163648f1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 10 Dec 2024 07:42:00 -0500
Subject: [PATCH] [libc++abi][libunwind] Provide an explicit error when trying
to
https://github.com/ldionne requested changes to this pull request.
Instead, can't you `#undef` these macros? We're trying to move away from
defining names with `__libcpp`.
https://github.com/llvm/llvm-project/pull/119241
___
cfe-commits mailing list
c
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/114382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -172,6 +172,7 @@ def parseScript(test, preamble):
f"{compileFlags} "
"-Wno-reserved-module-identifier
-Wno-reserved-user-defined-literal "
"-fmodule-file=std=%T/std.pcm " # The std.compat module
imports std.
+
https://github.com/ldionne commented:
I didn't have time to gather much context around this patch, sorry, I just
noticed your question on Discord.
https://github.com/llvm/llvm-project/pull/114382
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -188,6 +189,7 @@ def parseScript(test, preamble):
"%dbg(MODULE std) %{cxx} %{flags} "
f"{compileFlags} "
"-Wno-reserved-module-identifier
-Wno-reserved-user-defined-literal "
+"-fexperimental-modules-reduced-bmi "
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/118309
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/117491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Since we support only the latest released GCC in the runtimes, so I don't think
it makes sense to merge this. Newer GCCs don't seem to have this issue.
Closing, please reopen if you'd like to pursue this despite the above
information and we can chat.
https://github.com/llvm/llv
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/118555
None
>From b3b1cb221aa7388a3d72f1774c70392042139b04 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 3 Dec 2024 17:06:22 -0500
Subject: [PATCH 1/2] [libc++][libunwind] Fix documentation CI job after
#118
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From fbb6db25d2d52b19486c395d0855e7af4b8812a3 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/6] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
ldionne wrote:
Ah, I didn't realize this was only required for much older compilers. In that
case, indeed we don't support GCC 8 so we probably don't want to merge this.
https://github.com/llvm/llvm-project/pull/117491
___
cfe-commits mailing list
cfe
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 7c156ea8545fd9b5211c488ba5c4386c368d5f82 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/6] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 7c156ea8545fd9b5211c488ba5c4386c368d5f82 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/5] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From 3db70453e07f1378ed4d07023dc2a6cf2541b935 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
ldionne wrote:
Closing as stale, please reopen if you still want to pursue.
https://github.com/llvm/llvm-project/pull/101688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/101688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
The libc++ part LGTM. I don't really understand the `Fuchsia-stage2.cmake`
changes but I'm not sure I need to.
However, please rebase this on top of `main` and make sure that the CI is green
before you merge.
https://github.com/llvm/llvm-
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/117491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
>
> AFAICT we have one test for `invoke` plus a constexpr test which should
> really just be rolled into the generic `invoke` test. That test is ~400 LoC,
> which is definitely not nothing, but also not unmanageable IMO. We could
> probably also simplify that by not explicitly
ldionne wrote:
>
> 1. I'm not convinced the library part is true. The reality is that we support
> Clang and GCC, and if they both support the builtins (or provide different
> ones for the same feature) we remove our fallback implementations and thus
> reducing the complexity for libc++. GCC
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/112978
>From e42db172b2397e6358dc60850e4c8b085c6bd4bf Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Fri, 13 May 2022 09:26:01 -0400
Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY &
friends
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/101399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
> I do care. I sometimes like to compare benchmarks from different iterations.
> Currently when I build a benchmark I get a message where the executable is
> stored. The new approach makes harder to find the location of the executable.
> I wonder whether we can show a message wh
ldionne wrote:
I'm not sure what's special about your usage of Graphite, but I've seen other
people use it without triggering these notifications to everyone. This is
disruptive: if everyone started doing this, our Github notification system with
CODEOWNERS.txt would break down completely beca
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From 2e50f00dfc6636abbaf0c8350c6e7c92b7b3dba0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 25 Jul 2024 10:41:10 -0400
Subject: [PATCH] [libc++] Unify the benchmarks with the test suite
Instead of bui
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From f19ffaabcf0fdf6fc2dbb02200973418fe32be13 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 25 Jul 2024 10:41:10 -0400
Subject: [PATCH] [libc++] Unify the benchmarks with the test suite
Instead of bui
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From 504518235aa19ab517b59e41c003b86dc610bbb0 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 25 Jul 2024 10:41:10 -0400
Subject: [PATCH] [libc++] Unify the benchmarks with the test suite
Instead of bui
@@ -230,11 +230,22 @@ else()
endif()
set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt
libstdc++ libsupc++ vcruntime)
-set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++
ABI library to use. Supported values are ${LIBCXX_SUP
@@ -230,11 +230,22 @@ else()
endif()
set(LIBCXX_SUPPORTED_ABI_LIBRARIES none libcxxabi system-libcxxabi libcxxrt
libstdc++ libsupc++ vcruntime)
-set(LIBCXX_CXX_ABI "${LIBCXX_DEFAULT_ABI_LIBRARY}" CACHE STRING "Specify C++
ABI library to use. Supported values are ${LIBCXX_SUP
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From b52b55d2c25c6b0800c934885d0c6a389145bbf6 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 25 Jul 2024 10:41:10 -0400
Subject: [PATCH] [libc++] Unify the benchmarks with the test suite
Instead of bui
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From dd2d2ee9ff54b5263d0f65bcac64407ffb0c9e12 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 25 Jul 2024 10:41:10 -0400
Subject: [PATCH] [libc++] Unify the benchmarks with the test suite
Instead of bui
ldionne wrote:
Both CI failures seem to be unrelated.
https://github.com/llvm/llvm-project/pull/112741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@petrhosek I'm curious to know what you think of this design.
https://github.com/llvm/llvm-project/pull/112978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
> Looking at our current cmake config, we're using:
>
> ```
> -DLIBCXX_STATICALLY_LINK_ABI_IN_STATIC_LIBRARY=ON \
> -DLIBCXX_ENABLE_ABI_LINKER_SCRIPT=ON \
> ```
>
> Do I understand correctly that the new replacement for that would be?
>
> ```
> -DLIBCXX_ABILIB_FOR_SHARED="shared
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From cff8de9231ad461b82f9522d7a93b73ea0641e52 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 31 Jul 2024 13:00:25 -0400
Subject: [PATCH 1/4] [libc++] Make benchmarks forward-compatible with the test
su
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From a50fa3f81b486c949f20c614101a66e38e0f92e6 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 31 Jul 2024 13:00:25 -0400
Subject: [PATCH 1/4] [libc++] Make benchmarks forward-compatible with the test
su
ldionne wrote:
FWIW, I didn't mean to derail this effort or create significant additional
complexity by saying what I said above. My intention was only to point out the
tradeoff of adding new functionality for a temporary benefit, which wasn't
clear to me had been thought about in those terms.
ldionne wrote:
Just to clarify, I'm mostly neutral on this. A Clang reviewer should chime in
and evaluate the change for what it is. It does simplify the setup of the
libc++ test suite for GPU, but it's not required since we have other options to
set things up.
https://github.com/llvm/llvm-pr
ldionne wrote:
Ack, thanks for the confirmation.
> If we wanted to send the report as a comment on GitHub, we can certainly look
> into that as mentioned here
> https://discourse.llvm.org/t/using-plugins-in-buildkite-ci-that-require-docker/82701/6?u=davidspickett.
> The Buildkite specific par
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/108357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
> The script is already written and works, and there still isn't a concrete
> timeline for when we are going to move things over to Github actions. This
> solves a valid complaint I hear somewhat often. For libc++ at least, there
> are definitely platforms that will not be able
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/101399
>From cb6359e96c6fd2c2af90f84c32487977a6e1b819 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 31 Jul 2024 13:00:25 -0400
Subject: [PATCH 1/3] [libc++] Make benchmarks forward-compatible with the test
su
1 - 100 of 937 matches
Mail list logo
