ldionne wrote: Which identifiers exactly are causing issues? I think we could tackle that by adding them to `__undef_macros` and to `_LIBCPP_PUSH_MACROS` and `_LIBCPP_POP_MACROS` instead. That's generally what we do to work around name collisions on individual platforms: it's more robust and doesn't require changing libc++'s source code due to name conflicts, which could be arbitrary (in principle, a platform could also be defining `__libcpp_strtof`, so the only bulletproof way of addressing this issue is push/pop).
https://github.com/llvm/llvm-project/pull/119241 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
