[PATCH] D140925: [CMake] Use Clang to infer the target triple

ldionne accepted this revision. ldionne added inline comments. This revision is now accepted and ready to land. Comment at: runtimes/CMakeLists.txt:167 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_T

[PATCH] D158694: [libc++] Re-enable the __std_module test

ldionne abandoned this revision. ldionne added a comment. [Github PR transition cleanup] Abandoning here, will re-open as a Github PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158694/new/ https://reviews.llvm.org/D158694

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added a comment. Gentle ping. Are we waiting on anything to ship this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 ___ cfe-commits mailing list cfe-

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

ldionne added a comment. In D157283#4614177 , @DmitryPolukhin wrote: > @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa > (I > don't know what it is)? > Al

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

ldionne added a comment. I just did some digging. We completed the transition to the libcxx-headers-in-the-SDK already, and now upstream and downstream Clang are the same with respect to those search paths. I think it might just be the case that you need the very latest AppleClang for that to b

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

ldionne resigned from this revision. ldionne added a comment. Unfortunately I am too backed up with libc++ stuff to review with the PR transition, so I'm resigning from this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://re

[PATCH] D140538: [Clang][CodeGen] Use poison instead of undef for dummy values in CGExpr [NFC]

ldionne added a comment. Ping. This should be updated to avoid touching libcxxabi. Comment at: libcxxabi/test/test_demangle.pass.cpp:3172 {"_ZN5clang7CodeGen15CodeGenFunction24EmitComplexPrePostIncDecEPKNS_13UnaryOperatorENS0_6LValueEbb", "clang::CodeGen::CodeGenFunctio

[PATCH] D72959: Relative VTables ABI on Fuchsia

ldionne added a comment. Herald added subscribers: abrachet, jdoerfert, pengfei, MaskRay. Herald added a project: All. [Github PR transition cleanup] I think this work has landed as multiple separate patches, right? If so, can we please close this to clear up the review queue? Repository: rG

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

ldionne added inline comments. Comment at: runtimes/CMakeLists.txt:20 +set(RUNTIMES_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + This shouldn't be necessary, CMake already creates a `Project_SOURCE_DIR` variable for each declared `project()` IIRC. Repository:

[PATCH] D143524: Make the -Wunused-template default.

ldionne removed reviewers: ldionne, libc++. ldionne added a comment. Herald added a subscriber: wangpc. [Github PR transition cleanup] Dropping libc++ since this shouldn't affect libc++ since D144667 . Repository: rC Clang CHANGES SINCE LAST ACTION https:

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

ldionne added a comment. Ping. What's missing to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

ldionne resigned from this revision. ldionne added a subscriber: philnik. ldionne added a comment. Herald added a subscriber: wangpc. Herald added a project: All. @philnik you might be interested by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. The libc++ changes are reasonable. We could discuss more around how to handle C++03 in `__libcpp_is_constant_evaluated` but I don't think it's worth delaying this patch for that.

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

ldionne abandoned this revision. ldionne added a comment. Herald added a project: All. Abandoning since this LWG issue isn't voted yet and we don't need this to implement other features. I've moved it to https://github.com/ldionne/llvm-project/tree/wip/LWG3436-construct_at-arrays and create a G

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

ldionne abandoned this revision. ldionne added a comment. In D155713#4592852 , @hans wrote: >> I think this does actually matter for libc++, I think I have seen this >> pattern: >> >> template >> struct Foo { >> _LIBCPP_FUNC_VIS _LIBCPP_EXCLUDE_

[PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

ldionne added a comment. (sorry, no idea why it says "this revision is now accepted and ready to land on my behalf, I was just removing the libc++ review group to clear our review queue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ h

[PATCH] D114903: [clang] Support array placement new in constant expressions

ldionne abandoned this revision. ldionne added a comment. Herald added a project: All. I've run out of time to work on this. It's also not clear that it's supported by the Standard right now since there's a not-voted-yet LWG issue about it (http://wg21.link/LWG3436). Abandoning. This isn't bloc

[PATCH] D137338: Fix dupe word typos

ldionne added a comment. Herald added subscribers: wangpc, gysit, Dinistro, hoy, bviyer, wlei, jplehr, PiotrZSL, luke, sunshaoce. Herald added a reviewer: springerm. Herald added a reviewer: kiranchandramohan. Herald added a project: clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne commandeered this revision. ldionne added a reviewer: t-tye. ldionne added a comment. Herald added a subscriber: jplehr. Herald added a project: All. [GitHub PR transition cleanup] This has been open for 2 years with multiple subscribers able to see this discussion, but there doesn't see

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddb1b5da4: [clang][ci] Don't block all jobs on clang-format (authored by ldionne). Repository: rG LLVM Github Monore

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

ldionne added a comment. In D159197#4628232 , @aaron.ballman wrote: > Thank you for this! I'm not qualified to say the changes are correct (they > look sensible to me though), but I am really appreciative of the change. Yup this is mostly for awareness

[PATCH] D159197: [clang][ci] Don't block all jobs on clang-format

ldionne created this revision. ldionne added a reviewer: aaron.ballman. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was expressed in some reviews that Clang folks didn't want to hold off other tes

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb27be95a4c6: [clang] Add a Windows build in the Clang pre-commit

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne added a comment. This looks good, the Windows CI is failing with the original premerge checks in exactly the same way as this new job, so I guess it's a current issue on `main`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ htt

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1a3d93581f: Implement the monolithic CI pipeline in the monorepo (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554420. ldionne marked an inline comment as done. ldionne added a comment. Address review comments. I did some testing using GH PRs and this should work, but some tweaks might be necessary. After discussing with Mikhail, I'll merge this now and we can make t

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne marked an inline comment as done. ldionne added inline comments. Comment at: .ci/generate-buildkite-pipeline-premerge:163 + +if [[ ! ${SPECIFIC_PIPELINE_AVAILABLE} -eq 1 ]]; then + # Figure out which projects need to be built on each platform goncharov w

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554295. ldionne added a comment. Poke CI -- Phabricator keeps timing out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.y

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554277. ldionne added a comment. Don't upload the Windows build artifacts cause we don't use them and it fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554115. ldionne added a comment. Poke CI -- it seemed to time out this afternoon due to Phab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne added a comment. Herald added a subscriber: JDevlieghere. Sorry for spamming everyone, I'm trying to ensure that the CI will work with all the sub-projects in the monorepo once we move to GH PRs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554016. ldionne marked an inline comment as done. ldionne added a comment. Herald added a reviewer: bollu. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, Enna1, yota9, ayermolo, jvesely. Herald ad

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 554015. ldionne added a comment. Set VC variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553995. ldionne added a comment. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/run-buildbot

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

ldionne accepted this revision. ldionne added a comment. Sorry for missing a couple of direct pings. I have no concerns with the patch, perhaps I should not have marked my review as blocking in the first place. Thanks for doing this work, it's about time we updated this default! Repository:

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne updated this revision to Diff 553968. ldionne added a comment. Run script through bash on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 Files: clang/utils/ci/buildkite-pipeline.yml

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne added a subscriber: aaron.ballman. ldionne added a comment. @aaron.ballman for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158995/new/ https://reviews.llvm.org/D158995 ___ cfe-commits

[PATCH] D158995: [clang] Add a Windows build in the Clang pre-commit CI

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a CI job for Clang on Windows that is separate from the monolithic job that gets added automatically via the

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG5e603450bb33: [clang] Also run the clang tests as part of the Clang-specific CI pipeline (authored by ldionne). Repositor

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne updated this revision to Diff 553255. ldionne added a comment. Only run check-clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158765/new/ https://reviews.llvm.org/D158765 Files: clang/utils/ci/buildkite-pipeline.yml clang/utils/ci/

[PATCH] D158765: [clang] Also run the clang tests as part of the Clang-specific CI pipeline

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We used to rely on the monorepo-wide premerge checks for running Clang tests, but I think it makes more sense to run the Cla

[PATCH] D158694: [libc++] Re-enable the __std_module test

ldionne updated this revision to Diff 553120. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also touch a Clang file just to trigger their CI pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne added a comment. The follow-up to the temporary workaround is going to be done tomorrow in D158694 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158690/new/ https://reviews.llvm.org/D158690

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6073c7e32b: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline (authored by ldionne). Repository: rG LLVM Github M

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Along with aa60b2687ce3b67e454ba7c8c58a8688247df0b8 , this will make the Clang CI green again. We'll figure out what's th

[PATCH] D158690: [clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We made some changes to the libc++ CI pipeline that take for granted that we're running on libc++'s own Docker images. This

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added a comment. Also we should figure out why the Clang modules build is failing on top of this, it doesn't look like a false positive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 __

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM. I think what we discussed in https://reviews.llvm.org/D157757#inline-1534166 makes sense and we should do it, but it belongs to a different patch for sure. Anybody wants to take that

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; iana wrote: > aaron.ballman wrote: > > ldionne wrote: > > > iana wrote: > > > > aa

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added inline comments. Comment at: clang/lib/Headers/stddef.h:1 /*=== stddef.h - Basic type definitions === * Making a thread out of this: > The relationship between clang's stddef.h and the C Standard Library stdde

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added a comment. This is going to be really naive, but can someone explain why we need these `__need_X` macros? Why doesn't `` simply always declare what it should declare? Also, does anybody understand the expected relationship between the C Standard Library headers and these Clang

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

ldionne added a comment. I think I like this attribute. However, I am concerned that this would make it seem more acceptable to add extensions to the library, when our policy has been that we don't (and for good reasons, we ran into big issues with e.g. `std::string_view` and we learned from t

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

This revision was automatically updated to reflect the committed changes. Closed by commit rG042abb477c3f: [clang] Move the Clang CI jobs off of the libc++ builders (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ htt

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne updated this revision to Diff 547950. ldionne added a comment. Try to fix build on queue=linux builders Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157324/new/ https://reviews.llvm.org/D157324 Files: clang/utils/ci/buildkite-pipeline.y

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne added a subscriber: goncharov. ldionne added a comment. @goncharov Now that we have a `buildkite-pipeline.yml` for Clang, would it make sense to stop running the "builtin" jobs like https://buildkite.com/llvm-project/premerge-checks/builds/169498#0189d1af-3c81-4ab5-a87a-ac8db177ccf0 and

[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

ldionne created this revision. Herald added a subscriber: JDevlieghere. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The libc++ builders do not have the capacity to serve both libc++ and Clang CI need

[PATCH] D157227: [Clang] Don't add `undef` for `operator new` under -fno-exceptions.

ldionne added a comment. In D157227#4564817 , @nikic wrote: > Removing noundef makes no sense to me, because the return value is noundef > even under fno-exceptions. If we remove something, it should be the nonnull > attribute, because that's what's act

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

ldionne added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1515 const NamedDecl *D) const { - if (D && D->isExternallyVisible()) { + if (D && D->isExternallyVisible() && !D->hasAttr()) { if (D->hasAttr())

[PATCH] D155713: [clang] Fix interaction between dllimport and exclude_from_explicit_instantiation

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, bd1976llvm. Herald added a project: clang. When an entity is marked with both dllimport and exclude_from_explicit_instantiation, the compiler should not as

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

ldionne accepted this revision as: libc++. ldionne added a comment. LGTM for libc++. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155064/new/ https://reviews.llvm.org/D155064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

ldionne added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will always evaluate to 'true' in a ma

[PATCH] D152632: [Clang] Add warnings for CWG2521

ldionne added a comment. This breaks libc++: https://buildkite.com/llvm-project/clang-ci/builds/26#01894b7d-8d6f-4893-ab14-1147229390dc Doesn't mean don't land it, but please try to address the issues in this patch to keep everyone green. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG298f207e0649: [ci] Make libc++ and Clang CI scripts independent (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D155078?v

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. I will land this because I can tell this is correct after following the CI pipeline's execution, and https://github.com/google/llvm-premerge-checks/pull/452 has already landed so the CI could start becoming red anytime now. If there are concerns about Clang having its

[PATCH] D155081: Specify the developer policy around links to external resources

ldionne added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345"; to automate closing + the issue in GitHub. If the patch has been reviewed,

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. In D155078#4493995 , @aaron.ballman wrote: > In D155078#4493468 , @ldionne wrote: > >> Ok, this is ready to go. More context around this change: >> >> I created a clang-specific CI pipeli

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. See https://github.com/google/llvm-premerge-checks/pull/452 for the other side of this change. https://github.com/google/llvm-premerge-checks/pull/452 must land after this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539553. ldionne added a comment. Poke CI after fixing Clang CI pipeline clone URL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files: .ci/generate-buildkite-pip

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne added a comment. Ok, this is ready to go. More context around this change: I created a clang-specific CI pipeline (https://buildkite.com/llvm-project/clang-ci) and Clang CI jobs will now trigger inside that pipeline instead of inside the libc++ pipeline (https://buildkite.com/llvm-proj

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539534. ldionne added a comment. Poke CI after fixing pipeline settings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/ https://reviews.llvm.org/D155078 Files: .ci/generate-buildkite-pipeline-prem

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

ldionne abandoned this revision. ldionne added a comment. Superseded by D155078 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141423/new/ https://reviews.llvm.org/D141423 _

[PATCH] D138042: [libc++] Trigger both Clang and libc++ CI when there are changes to both

ldionne abandoned this revision. ldionne added a comment. This will be superseded by D155078 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138042/new/ https://reviews.llvm.org/D138042 ___

[PATCH] D155078: [ci] Make libc++ and Clang CI scripts independent

ldionne updated this revision to Diff 539526. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Touch a file inside Clang to test the triggering. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155078/new/

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a3322bab069: [clang] Create a buildkite-pipeline.yml file for clang (authored by philnik, committed by ldionne). Changed prior to commit: https:/

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This LGTM but the CI has to pass! Also don't forget to undo the changes to `buildkite-pipeline.yml` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D153920: [clang] Move the clang formatting job to run-buildbot to fix the CI

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. I really like where this is going, this will create a framework where Clang can add more pre-commit CI checks if they desire. Comment at: clang/utils/ci/run-buil

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

ldionne added a comment. LGTM, but as a matter of process, please try to wait for someone from the libc++ review group before submitting. Thanks for the fix! Comment at: libcxx/include/__tree:379-380 _LIBCPP_ASSERT_UNCATEGORIZED(__z != nullptr, "The node to remove should

[PATCH] D143052: [CMake] Replace llvm_check_linker_flag and llvm_check_compiler_linker_flag

ldionne added a comment. Herald added a subscriber: ekilmer. What is the status of this? We now require CMake 3.20, can this be rebased and landed in some form? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143052/new/ https://reviews.llvm.org/D14

[PATCH] D151963: [clang][NFC] Remove trailing whitespaces and enforce it in lib, include and docs

ldionne added inline comments. Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:20-31 + - label: "Format" +commands: + - "! grep -rnI '[[:blank:]]$' clang/lib clang/include clang/docs || false" + +agents: + queue: "libcxx-builders" + os: "linux" -

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:105 // RUN: -nostdinc \ // RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \ // RUN: -DTOOLCHAIN=%S/Inputs/basic_darwin_toolchain \ ldion

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This LGTM w/ comments applied. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 ___

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:95 // Make sure that using -nostdinc, -nostdinc++ or -nostdlib will drop both the toolchain // C++ include path and the sysroot one. Comment at:

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:119 // RUN: -nostdinc++ \ -// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:431 + // libc++.dylib in the toolchain. + if ((!Args.hasArg(options::OPT_nostdinc, options::OPT_nostdlibinc, +options::OPT_nostdincxx)) && arphaman wrote: > ld

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

ldionne accepted this revision as: libc++abi. ldionne added a comment. This revision is now accepted and ready to land. Code changes in libc++ and libc++abi LGTM. I am neutral on whether the diagnostic is worth adding, but don't consider libc++ and libc++abi as blockers for this patch. ==

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519824. ldionne added a comment. Use tarball Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149752/new/ https://reviews.llvm.org/D149752 Files: clang/foo libcxx/utils/ci/buildkite-pipeline-clang.yml libcx

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519483. ldionne added a comment. Make sure we run the Clang pipeline always Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149752/new/ https://reviews.llvm.org/D149752 Files: clang/foo libcxx/utils/ci/build

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519476. ldionne added a comment. Herald added subscribers: libcxx-commits, arichardson. Herald added a project: libc++. Herald added a reviewer: libc++. Check file type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D149752: WIP: Debug symlink creation

ldionne updated this revision to Diff 519218. ldionne added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Poke CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149752/new/ https://reviews.llvm.org/D149752 Files:

[PATCH] D149553: [clang] Use -std=c++23 instead of -std=c++2b

ldionne added a comment. Thanks for doing this! No objection, will let Aaron give the thumbs up. Comment at: clang/test/Parser/cxx2b-label.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -verify=expected,cxx2b -std=c++2b -Wpre-c++2b-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify=

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

This revision was automatically updated to reflect the committed changes. Closed by commit rG5084ba395e48: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

ldionne added subscribers: phosek, Ericson2314, aaron.ballman. ldionne added a comment. CCing some folks that were watching D132324 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148945/new/ https://reviews.llvm.o

[PATCH] D148945: [clang] Remove workaround for old LLVM_ENABLE_PROJECTS=libcxx build

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. We don't support the LLVM_ENABLE_PROJECTS=libcxx build anymore (and have not for over a year), so it should be fine

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added a subscriber: arphaman. ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:431 + // libc++.dylib in the toolchain. + if ((!Args.hasArg(options::OPT_nostdinc, options::OPT_nostdlibinc, +options::OPT_nostdincxx)) &&

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:413-414 + // Including the path to the just-built libc++.dylib if libc++ is bootstrapped + // and /bin/../lib/libc++.dylib is a valid path + I would reword this to: ``` // If

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Thanks for working on this! This generally LGTM, with a few comments. You should be able to add tests in a way similar to `clang/test/Driver/darwin-header-search-libcxx.cpp`. The i

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG731264b0c2af: [clang][NFC] Fix location of 2>&1 in a few -print tests (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

ldionne added a reviewer: aaron.ballman. ldionne added a comment. Gentle ping, this was likely a copy-paste error. Adding Aaron in case he has time to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146155/new/ https://reviews.llvm.org/

[PATCH] D146155: [clang][NFC] Fix location of 2>&1 in a few -print tests

ldionne created this revision. Herald added a project: All. ldionne requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While it's apparently valid to place Bash redirections anywhere in a command-line, it is by far most frequently placed last.

[PATCH] D35820: [Driver] Search compiler-rt paths in -print-file-name=

ldionne added inline comments. Herald added a project: All. Comment at: cfe/trunk/include/clang/Driver/ToolChain.h:312 + virtual std::string getCompilerRTPath() const; + By introducing a second way of getting the path to compiler-rt, this created inconsistenc

  1   2   3   4   5   6   7   8   >