ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:119 // RUN: -nostdinc++ \ -// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \ +// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr_cxx_v1 \ // RUN: -DTOOLCHAIN=%S/Inputs/basic_darwin_toolchain \ ---------------- Is this change really needed anymore? Why? ================ Comment at: clang/test/Driver/darwin-link-libcxx-from-toolchain.cpp:11 // RUN: -ccc-install-dir %S/Inputs/basic_darwin_toolchain_no_libcxx/usr/bin \ -// RUN: | FileCheck --check-prefix=CHECK-LIBCXX-NONE %s -// CHECK-LIBCXX-NONE: "-cc1" +// RUN: | FileCheck -DTOOLCHAIN=%S/Inputs/basic_darwin_toolchain_no_libcxx --check-prefix=CHECK-TOOLCHAIN-LIBCXX-LINKING-2 %s ---------------- I don't see `CHECK-TOOLCHAIN-LIBCXX-LINKING-2` defined anywhere? ================ Comment at: clang/test/Driver/darwin-link-libcxx-from-toolchain.cpp:13 // Check with only headers alongside the installation (those should be used). // ---------------- Some of these test cases and comments don't make sense for this test -- you copy-pasted the test for header search paths and that's fine, but please go through it to make sure you make the necessary edits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
