Author: rizsotto
Date: Fri Apr 7 06:04:49 2017
New Revision: 299759
URL: http://llvm.org/viewvc/llvm-project?rev=299759&view=rev
Log:
[scan-build-py] merge runner module to analyzer
Differential Revision: https://reviews.llvm.org/D31237
Removed:
cfe/trunk/tools/scan-build-py/libscanbuild/ru
Author: rizsotto
Date: Tue Mar 21 05:15:18 2017
New Revision: 298355
URL: http://llvm.org/viewvc/llvm-project?rev=298355&view=rev
Log:
[scan-build-py] reuse command line output parameter for report directory
Differential Revision: https://reviews.llvm.org/D30861
Modified:
cfe/trunk/tools/sca
Author: rizsotto
Date: Mon Mar 20 04:03:24 2017
New Revision: 298238
URL: http://llvm.org/viewvc/llvm-project?rev=298238&view=rev
Log:
[scan-build-py] use python tempfile for tempdir
Differential Revision: https://reviews.llvm.org/D30862
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/_
Author: rizsotto
Date: Wed Mar 8 15:22:32 2017
New Revision: 297308
URL: http://llvm.org/viewvc/llvm-project?rev=297308&view=rev
Log:
[scan-build-py] move argument parsing into separate module
Forgot to add the new module.
Added:
cfe/trunk/tools/scan-build-py/libscanbuild/arguments.py
Adde
Author: rizsotto
Date: Wed Mar 8 15:18:51 2017
New Revision: 297307
URL: http://llvm.org/viewvc/llvm-project?rev=297307&view=rev
Log:
[scan-build-py] move argument parsing into separate module
Differential Revision: https://reviews.llvm.org/D30601
Modified:
cfe/trunk/tools/scan-build-py/bin
Author: rizsotto
Date: Wed Mar 8 03:27:53 2017
New Revision: 297266
URL: http://llvm.org/viewvc/llvm-project?rev=297266&view=rev
Log:
[scan-build-py] fix some line separator issues
Differential Revision: https://reviews.llvm.org/D30600
Modified:
cfe/trunk/tools/scan-build-py/libear/__init__
Author: rizsotto
Date: Fri Mar 3 19:08:05 2017
New Revision: 296937
URL: http://llvm.org/viewvc/llvm-project?rev=296937&view=rev
Log:
[scan-build-py] create decorator for compiler wrapper methods
Differential Revision: https://reviews.llvm.org/D29260
Modified:
cfe/trunk/tools/scan-build-py/
Author: rizsotto
Date: Tue Feb 14 04:43:38 2017
New Revision: 295045
URL: http://llvm.org/viewvc/llvm-project?rev=295045&view=rev
Log:
[scan-build-py] move function report_directory from report module to analyze
module
Differential Revision: https://reviews.llvm.org/D29255
Modified:
cfe/tru
Author: rizsotto
Date: Tue Feb 14 04:30:50 2017
New Revision: 295043
URL: http://llvm.org/viewvc/llvm-project?rev=295043&view=rev
Log:
[scan-build-py] use subprocess wrapper to execute build
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/__init__.py
cfe/trunk/tools/scan-build-py/lib
Author: rizsotto
Date: Sat Jan 28 22:59:32 2017
New Revision: 293418
URL: http://llvm.org/viewvc/llvm-project?rev=293418&view=rev
Log:
[scan-build-py] remove not used flag
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/intercept.py
Modified: cfe/trunk/tools/scan-build-py/libscanbuild/i
Author: rizsotto
Date: Sat Jan 28 16:55:25 2017
New Revision: 293397
URL: http://llvm.org/viewvc/llvm-project?rev=293397&view=rev
Log:
[scan-build-py] remove batch files
Removed:
cfe/trunk/tools/scan-build-py/bin/analyze-build.bat
cfe/trunk/tools/scan-build-py/bin/analyze-c++.bat
cfe/
Author: rizsotto
Date: Sat Jan 28 16:48:26 2017
New Revision: 293396
URL: http://llvm.org/viewvc/llvm-project?rev=293396&view=rev
Log:
[scan-build-py] use subprocess wrapper
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/__init__.py
cfe/trunk/tools/scan-build-py/libscanbuild/clang.p
rizsotto.mailinglist closed this revision.
rizsotto.mailinglist added a comment.
commited at r282317
https://reviews.llvm.org/D19260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rizsotto
Date: Fri Sep 23 19:20:59 2016
New Revision: 282317
URL: http://llvm.org/viewvc/llvm-project?rev=282317&view=rev
Log:
[analyzer][scan-build-py] subprocess output handling reviewed in clang module
Modified:
cfe/trunk/tools/scan-build-py/libscanbuild/analyze.py
cfe/trunk/to
rizsotto.mailinglist accepted this revision.
rizsotto.mailinglist added a comment.
This revision is now accepted and ready to land.
thanks Devin, i like smaller code, have no problem with this change. :)
about the file/directory paths: i agree that the situation is not ideal. but
there are/were
rizsotto.mailinglist added a comment.
In https://reviews.llvm.org/D24040#532718, @o.gyorgy wrote:
> In https://reviews.llvm.org/D24040#530293, @rizsotto.mailinglist wrote:
>
> > Gyorgy and the ericsson team, thanks for doing this. very good job! good
> > targeted functionality. i don't want to u
rizsotto.mailinglist added a comment.
looks good to me. i like the test. :) but would keep the `pep8` cleanness.
Comment at: tools/scan-build-py/libscanbuild/report.py:38
@@ -36,3 +37,3 @@
-stamp = time.strftime('scan-build-%Y-%m-%d-%H%M%S-', time.localtime())
+stamp =
rizsotto.mailinglist added a comment.
Gyorgy and the ericsson team, thanks for doing this. very good job! good
targeted functionality. i don't want to underestimate the complexity it
requires, but to me this is a giant code. i do miss the explanation of the
overall functional description what a
rizsotto.mailinglist added a comment.
hey Devin, thanks for looking to it.
Comment at: tools/scan-build-py/libscanbuild/clang.py:90
@@ -89,2 +89,3 @@
-{: (, )} """
+predicate.patterns = [re.compile(r'^' + a + r'(\.|$)') for a in checkers]
+return predicate
rizsotto.mailinglist created this revision.
rizsotto.mailinglist added reviewers: zaks.anna, dcoughlin.
rizsotto.mailinglist added a subscriber: cfe-commits.
In python subprocess.check_output is an easy way to collect child process
output. Current implementation does deal with Popen class, which
Author: rizsotto
Date: Tue Apr 19 07:03:03 2016
New Revision: 266726
URL: http://llvm.org/viewvc/llvm-project?rev=266726&view=rev
Log:
D17487: [analyzer][scan-build-py] flag filter modification for compilation
database creation
Added:
cfe/trunk/tools/scan-build-py/libscanbuild/compilation.py
rizsotto.mailinglist added a comment.
the semicolon at the end of line 39 is an issue for PEP8. please remove it.
http://reviews.llvm.org/D17091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
rizsotto.mailinglist accepted this revision.
rizsotto.mailinglist added a comment.
This revision is now accepted and ready to land.
thanks Anton, LGTM!
http://reviews.llvm.org/D17091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
yes, it is just an initial drop. improvements are planed to make a full
replacement of the one written in Perl.
On Thu, Jan 14, 2016 at 12:14 AM, Ismail Donmez wrote:
> Hi,
>
> On Wed, Jan 13, 2016 at 12:38 AM, Laszlo Nagy via cfe-commits
> wrote:
> > Author: rizsotto
>
rizsotto.mailinglist added a comment.
Thank you guys for your review and help! The latest patch is commited. Let's do
the next steps too. ;)
@danielmarjamaki the standalone Bear will be maintained. and your comments will
also be considered.
http://reviews.llvm.org/D9600
___
rizsotto.mailinglist added a comment.
sorry for the delay, hard to get free time these days. ;)
Comment at: tools/scan-build-py/libscanbuild/intercept.py:146
@@ +145,3 @@
+})
+elif sys.platform == 'darwin':
+logging.debug('intercept gonna preload libear on OS
rizsotto.mailinglist added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:142
@@ +141,3 @@
+#endif
+if (!initialized)
+initialized = bear_capture_env_t(&initial_env);
dcoughlin wrote:
> rizsotto.mailinglist wrote:
> > rizsotto.mailinglis
rizsotto.mailinglist added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:142
@@ +141,3 @@
+#endif
+if (!initialized)
+initialized = bear_capture_env_t(&initial_env);
to run the full test set
> PATH=$(pwd)/bin:$PATH python -m unittest d
rizsotto.mailinglist marked 6 inline comments as done.
Comment at: tools/scan-build-py/README.md:86
@@ +85,3 @@
+The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload
+is available from the dynamic loader. On OSX System Integrity Protection
security
+feat
rizsotto.mailinglist added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:141
@@ +140,3 @@
+environ = *_NSGetEnviron();
+#endif
+if (!initialized)
this call just sets up the `environ` variables for the `bear_capture_env_t`
method, two lines
rizsotto.mailinglist marked an inline comment as done.
Comment at: tools/scan-build-py/bin/analyze-c++:2
@@ +1,3 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
+# The LLVM Compiler Infrastructure
zaks.anna wrote:
> Where/How is analyze-c++
rizsotto.mailinglist added inline comments.
Comment at: tools/scan-build-py/libear/ear.c:282
@@ +281,3 @@
+DLSYM(func, fp, "execve");
+
+char const **const menvp = bear_update_environment(envp, &initial_env);
okay, since i don't have access for OSX machine
rizsotto.mailinglist marked 7 inline comments as done.
rizsotto.mailinglist added a comment.
thanks for the comments.
Comment at: tools/scan-build-py/bin/analyze-c++:1
@@ +1,2 @@
+#!/usr/bin/env python
+# -*- coding: utf-8 -*-
zaks.anna wrote:
> What calls this
rizsotto.mailinglist marked an inline comment as done.
rizsotto.mailinglist added a comment.
> Also, what do you think about renaming intercept-build to "log-build" or some
> of the other alternatives I proposed above? I think it is important for the
> name of the executable to communicate its p
rizsotto.mailinglist marked 3 inline comments as done.
rizsotto.mailinglist added a comment.
updated comments before upload a new diff.
Comment at: tools/scan-build-py/MANIFEST.in:1
@@ +1,2 @@
+include README.md
+include *.txt
dcoughlin wrote:
> rizsotto.mailing
rizsotto.mailinglist marked 13 inline comments as done.
rizsotto.mailinglist added a comment.
thanks Devin for your comments. made some changes already (will upload it
tonight after some tests).
Comment at: tools/scan-build-py/CHANGES.txt:1
@@ +1,1 @@
+v, -- Initial release.
-
rizsotto.mailinglist added a comment.
I think the `scan-build` user experience would be improved by config file! And
I really like how the `clang-tidy` guys were doing it. (In case if you are not
familiar with it, copy from the help output)
Configuration files:
clang-tidy attempts to read
rizsotto.mailinglist added a comment.
In http://reviews.llvm.org/D9600#290031, @jroelofs wrote:
> Thanks for re-uploading!
thanks for your comments! :)
most of your comments are about to embed it more into the clang build, test
infrastructure. i think these are valid points!
i would like to
rizsotto.mailinglist added a comment.
> The reason to squash all your patches together is that partial diffs from a
> patch series don't work well with Phabricator's "Revision Update History"
> tool. Also, it makes it hard to pull out a patch that I can apply on my local
> tree to try it out.
rizsotto.mailinglist added a comment.
In http://reviews.llvm.org/D9600#287157, @jroelofs wrote:
> Would you mind re-uploading this patch as a diff against upstream trunk with
> full context?
i'm not sure i do understand what do you ask. i wish i could upload these
changes as a single patch, b
rizsotto.mailinglist added a comment.
the latest update has the following improvements:
- makes it work without installation.
- pass the `SATestBuild.py` test harness against different projects with
`--strictness 2` arguments. (coreutils-8.23, gawk-4.1.1, make-4.0,
openssl-1.0.0s, patch-2.7.4,
rizsotto.mailinglist updated this revision to Diff 39703.
rizsotto.mailinglist added a comment.
findings from compare from older Perl implementation
http://reviews.llvm.org/D9600
Files:
tools/scan-build-py/README.md
tools/scan-build-py/libear/CMakeLists.txt
tools/scan-build-py/libear/__in
42 matches
Mail list logo
